[v7] Introduce runtime modifiable Energy Model

[PATCH v7 01/23] PM: EM: Add missing newline for the message log

Posted by Lukasz Luba 1 year, 11 months ago

Fix missing newline for the string long in the error code path.

Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
---
 kernel/power/energy_model.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c
index 7b44f5b89fa1..8b9dd4a39f63 100644
--- a/kernel/power/energy_model.c
+++ b/kernel/power/energy_model.c
@@ -250,7 +250,7 @@ static void em_cpufreq_update_efficiencies(struct device *dev)
 
 	policy = cpufreq_cpu_get(cpumask_first(em_span_cpus(pd)));
 	if (!policy) {
-		dev_warn(dev, "EM: Access to CPUFreq policy failed");
+		dev_warn(dev, "EM: Access to CPUFreq policy failed\n");
 		return;
 	}
 
-- 
2.25.1

Re: [PATCH v7 01/23] PM: EM: Add missing newline for the message log

Posted by Hongyan Xia 1 year, 11 months ago

On 17/01/2024 09:56, Lukasz Luba wrote:
> Fix missing newline for the string long in the error code path.
> 
> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
> ---
>   kernel/power/energy_model.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c
> index 7b44f5b89fa1..8b9dd4a39f63 100644
> --- a/kernel/power/energy_model.c
> +++ b/kernel/power/energy_model.c
> @@ -250,7 +250,7 @@ static void em_cpufreq_update_efficiencies(struct device *dev)
>   
>   	policy = cpufreq_cpu_get(cpumask_first(em_span_cpus(pd)));
>   	if (!policy) {
> -		dev_warn(dev, "EM: Access to CPUFreq policy failed");
> +		dev_warn(dev, "EM: Access to CPUFreq policy failed\n");
>   		return;
>   	}
>   

Reviewed-by: Hongyan Xia <hongyan.xia2@arm.com>