[PATCH v2 1/2] dt-bindings: arm: fsl: Add i.MX93 PHYTEC with Segin

Mathieu Othacehe posted 2 patches 1 year, 11 months ago
[PATCH v2 1/2] dt-bindings: arm: fsl: Add i.MX93 PHYTEC with Segin
Posted by Mathieu Othacehe 1 year, 11 months ago
Add support for i.MX93 PHYTEC with Segin board.

Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 228dcc5c7d6f..196935d3abf0 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1275,6 +1275,12 @@ properties:
           - const: tq,imx93-tqma9352        # TQ-Systems GmbH i.MX93 TQMa93xxCA/LA SOM
           - const: fsl,imx93
 
+      - description: i.MX93 PHYTEC phyBOARD-Segin
+        items:
+          - const: phytec,imx93-phycore-segin
+          - const: phytec,imx93-phycore-som
+          - const: fsl,imx93
+
       - description:
           Freescale Vybrid Platform Device Tree Bindings
 
-- 
2.41.0
Re: [PATCH v2 1/2] dt-bindings: arm: fsl: Add i.MX93 PHYTEC with Segin
Posted by Primoz Fiser 1 year, 11 months ago
Hi Mathieu,

On 17. 01. 24 08:49, Mathieu Othacehe wrote:
> Add support for i.MX93 PHYTEC with Segin board.
> 
> Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 228dcc5c7d6f..196935d3abf0 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1275,6 +1275,12 @@ properties:
>            - const: tq,imx93-tqma9352        # TQ-Systems GmbH i.MX93 TQMa93xxCA/LA SOM
>            - const: fsl,imx93
>  
> +      - description: i.MX93 PHYTEC phyBOARD-Segin
> +        items:
> +          - const: phytec,imx93-phycore-segin
> +          - const: phytec,imx93-phycore-som
> +          - const: fsl,imx93
> +

PHYTEC has the following in their downstream kernel:

>       - description: PHYTEC phyCORE-i.MX93 SoM based boards
>         items:
>           - const: phytec,imx93-phyboard-segin # phyBOARD-Segin with i.MX93
>           - const: phytec,imx93-phycore-som    # phyCORE-i.MX93 SoM
>           - const: fsl,imx93

so there will be additional boards based on phyCORE-i.MX93 SoMs just
like with phyCORE-i.MX8MM.

Please consider fixing this in v3.


>        - description:
>            Freescale Vybrid Platform Device Tree Bindings
>
Re: [PATCH v2 1/2] dt-bindings: arm: fsl: Add i.MX93 PHYTEC with Segin
Posted by Krzysztof Kozlowski 1 year, 11 months ago
On 17/01/2024 08:49, Mathieu Othacehe wrote:
> Add support for i.MX93 PHYTEC with Segin board.
> 
> Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)

This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.

Best regards,
Krzysztof