[v1] ARM: dts: tps65217: add power regulator & backlight drivers support

[PATCH] ARM: dts: tps65217: add power regulator & backlight drivers support

Posted by Xulin Sun 1 year, 11 months ago

Support TPS65217 voltage regulator driver and TPS65217 Backlight driver.
And enable them by default. This will avoid below booting failed
information:
tps65217-pmic: Failed to locate of_node [id: -1]
tps65217-bl: Failed to locate of_node [id: -1]

Signed-off-by: Xulin Sun <xulin.sun@windriver.com>
---
 arch/arm/boot/dts/tps65217.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/tps65217.dtsi b/arch/arm/boot/dts/tps65217.dtsi
index 0d463de5650f..f412e7476660 100644
--- a/arch/arm/boot/dts/tps65217.dtsi
+++ b/arch/arm/boot/dts/tps65217.dtsi
@@ -13,6 +13,16 @@ &tps {
 	interrupt-controller;
 	#interrupt-cells = <1>;
 
+	pmic {
+		compatible = "ti,tps65217-pmic";
+		status = "okay";
+	};
+
+	bl {
+		compatible = "ti,tps65217-bl";
+		status = "okay";
+	};
+
 	charger {
 		compatible = "ti,tps65217-charger";
 		interrupts = <0>, <1>;
-- 
2.34.1

Re: [PATCH] ARM: dts: tps65217: add power regulator & backlight drivers support

Posted by Krzysztof Kozlowski 1 year, 11 months ago

On 17/01/2024 05:33, Xulin Sun wrote:
> Support TPS65217 voltage regulator driver and TPS65217 Backlight driver.
> And enable them by default. This will avoid below booting failed
> information:
> tps65217-pmic: Failed to locate of_node [id: -1]
> tps65217-bl: Failed to locate of_node [id: -1]
> 
> Signed-off-by: Xulin Sun <xulin.sun@windriver.com>
> ---
>  arch/arm/boot/dts/tps65217.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/tps65217.dtsi b/arch/arm/boot/dts/tps65217.dtsi
> index 0d463de5650f..f412e7476660 100644
> --- a/arch/arm/boot/dts/tps65217.dtsi
> +++ b/arch/arm/boot/dts/tps65217.dtsi
> @@ -13,6 +13,16 @@ &tps {
>  	interrupt-controller;
>  	#interrupt-cells = <1>;
>  
> +	pmic {
> +		compatible = "ti,tps65217-pmic";
> +		status = "okay";

Why do you need status here?

Best regards,
Krzysztof

Re: [PATCH] ARM: dts: tps65217: add power regulator & backlight drivers support

Posted by Xulin Sun 1 year, 11 months ago

On 1/17/24 15:24, Krzysztof Kozlowski wrote:
> On 17/01/2024 05:33, Xulin Sun wrote:
>> Support TPS65217 voltage regulator driver and TPS65217 Backlight driver.
>> And enable them by default. This will avoid below booting failed
>> information:
>> tps65217-pmic: Failed to locate of_node [id: -1]
>> tps65217-bl: Failed to locate of_node [id: -1]
>>
>> Signed-off-by: Xulin Sun <xulin.sun@windriver.com>
>> ---
>>   arch/arm/boot/dts/tps65217.dtsi | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/tps65217.dtsi b/arch/arm/boot/dts/tps65217.dtsi
>> index 0d463de5650f..f412e7476660 100644
>> --- a/arch/arm/boot/dts/tps65217.dtsi
>> +++ b/arch/arm/boot/dts/tps65217.dtsi
>> @@ -13,6 +13,16 @@ &tps {
>>   	interrupt-controller;
>>   	#interrupt-cells = <1>;
>>   
>> +	pmic {
>> +		compatible = "ti,tps65217-pmic";
>> +		status = "okay";
> Why do you need status here?


It corresponds to the drvier: drivers/regulator/tps65217-regulator.c, 
and regulator is one of the main function of TPS65217.

I think it should be enabled by default, so set status to "okay" here.


Thanks

Xulin

>
> Best regards,
> Krzysztof
>

Re: [PATCH] ARM: dts: tps65217: add power regulator & backlight drivers support

Posted by Krzysztof Kozlowski 1 year, 11 months ago

On 17/01/2024 08:56, Xulin Sun wrote:
> On 1/17/24 15:24, Krzysztof Kozlowski wrote:
>> On 17/01/2024 05:33, Xulin Sun wrote:
>>> Support TPS65217 voltage regulator driver and TPS65217 Backlight driver.
>>> And enable them by default. This will avoid below booting failed
>>> information:
>>> tps65217-pmic: Failed to locate of_node [id: -1]
>>> tps65217-bl: Failed to locate of_node [id: -1]
>>>
>>> Signed-off-by: Xulin Sun <xulin.sun@windriver.com>
>>> ---
>>>   arch/arm/boot/dts/tps65217.dtsi | 10 ++++++++++
>>>   1 file changed, 10 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/tps65217.dtsi b/arch/arm/boot/dts/tps65217.dtsi
>>> index 0d463de5650f..f412e7476660 100644
>>> --- a/arch/arm/boot/dts/tps65217.dtsi
>>> +++ b/arch/arm/boot/dts/tps65217.dtsi
>>> @@ -13,6 +13,16 @@ &tps {
>>>   	interrupt-controller;
>>>   	#interrupt-cells = <1>;
>>>   
>>> +	pmic {
>>> +		compatible = "ti,tps65217-pmic";
>>> +		status = "okay";
>> Why do you need status here?
> 
> 
> It corresponds to the drvier: drivers/regulator/tps65217-regulator.c, 
> and regulator is one of the main function of TPS65217.

status does not correspond to the driver.

> 
> I think it should be enabled by default, so set status to "okay" here.

It is the default. Is it disabled anywhere?

Best regards,
Krzysztof