[PATCH] MIPS: Cobalt: Fix missing prototypes

Florian Fainelli posted 1 patch 1 year, 11 months ago
arch/mips/cobalt/setup.c                   | 3 ---
arch/mips/include/asm/mach-cobalt/cobalt.h | 3 +++
2 files changed, 3 insertions(+), 3 deletions(-)
[PATCH] MIPS: Cobalt: Fix missing prototypes
Posted by Florian Fainelli 1 year, 11 months ago
Fix missing prototypes warnings for cobalt_machine_halt() and
cobalt_machine_restart() by moving their prototypes to cobalt.h which is
included by setup.c.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 arch/mips/cobalt/setup.c                   | 3 ---
 arch/mips/include/asm/mach-cobalt/cobalt.h | 3 +++
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/mips/cobalt/setup.c b/arch/mips/cobalt/setup.c
index 2e099d55a564..9a266bf78339 100644
--- a/arch/mips/cobalt/setup.c
+++ b/arch/mips/cobalt/setup.c
@@ -23,9 +23,6 @@
 
 #include <cobalt.h>
 
-extern void cobalt_machine_restart(char *command);
-extern void cobalt_machine_halt(void);
-
 const char *get_system_type(void)
 {
 	switch (cobalt_board_id) {
diff --git a/arch/mips/include/asm/mach-cobalt/cobalt.h b/arch/mips/include/asm/mach-cobalt/cobalt.h
index 5b9fce73f11d..97f9d5e9446d 100644
--- a/arch/mips/include/asm/mach-cobalt/cobalt.h
+++ b/arch/mips/include/asm/mach-cobalt/cobalt.h
@@ -19,4 +19,7 @@ extern int cobalt_board_id;
 #define COBALT_BRD_ID_QUBE2    0x5
 #define COBALT_BRD_ID_RAQ2     0x6
 
+void cobalt_machine_halt(void);
+void cobalt_machine_restart(char *command);
+
 #endif /* __ASM_COBALT_H */
-- 
2.34.1
Re: [PATCH] MIPS: Cobalt: Fix missing prototypes
Posted by Thomas Bogendoerfer 1 year, 10 months ago
On Tue, Jan 16, 2024 at 08:30:59PM -0800, Florian Fainelli wrote:
> Fix missing prototypes warnings for cobalt_machine_halt() and
> cobalt_machine_restart() by moving their prototypes to cobalt.h which is
> included by setup.c.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  arch/mips/cobalt/setup.c                   | 3 ---
>  arch/mips/include/asm/mach-cobalt/cobalt.h | 3 +++
>  2 files changed, 3 insertions(+), 3 deletions(-)

applied to mips-fixes

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]