[PATCH] scsi: initio: remove redundant variable rb

Colin Ian King posted 1 patch 1 year, 11 months ago
drivers/scsi/initio.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
[PATCH] scsi: initio: remove redundant variable rb
Posted by Colin Ian King 1 year, 11 months ago
The variable rb is being assigned a value but it isn't being
read afterwards. The assignment is redundant and so rb can be
removed.

Cleans up clang scan build warning:
warning: Although the value stored to 'rb' is used in the
enclosing expression, the value is never actually read from
'rb'[deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/scsi/initio.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c
index 2a50fda3a628..625fd547ee60 100644
--- a/drivers/scsi/initio.c
+++ b/drivers/scsi/initio.c
@@ -371,7 +371,6 @@ static u16 initio_se2_rd(unsigned long base, u8 addr)
  */
 static void initio_se2_wr(unsigned long base, u8 addr, u16 val)
 {
-	u8 rb;
 	u8 instr;
 	int i;
 
@@ -400,7 +399,7 @@ static void initio_se2_wr(unsigned long base, u8 addr, u16 val)
 		udelay(30);
 		outb(SE2CS, base + TUL_NVRAM);			/* -CLK */
 		udelay(30);
-		if ((rb = inb(base + TUL_NVRAM)) & SE2DI)
+		if (inb(base + TUL_NVRAM) & SE2DI)
 			break;	/* write complete */
 	}
 	outb(0, base + TUL_NVRAM);				/* -CS */
-- 
2.39.2
Re: [PATCH] scsi: initio: remove redundant variable rb
Posted by Martin K. Petersen 1 year, 11 months ago
> The variable rb is being assigned a value but it isn't being read
> afterwards. The assignment is redundant and so rb can be removed.

Applied to 6.8/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering