drm/panel: nt36523: Set 120Hz fps for xiaomi,elish panels

[PATCH] drm/panel: nt36523: Set 120Hz fps for xiaomi,elish panels

Posted by Jianhua Lu 1 year, 11 months ago

After commit e6c0de5f4450 ("drm/msm/dpu: try multirect based on mdp clock limits")
merged, 120Hz is working on xiaomi,elish panels, so feature it.

Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
---
 drivers/gpu/drm/panel/panel-novatek-nt36523.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36523.c b/drivers/gpu/drm/panel/panel-novatek-nt36523.c
index a189ce236328..d6fa76dbf948 100644
--- a/drivers/gpu/drm/panel/panel-novatek-nt36523.c
+++ b/drivers/gpu/drm/panel/panel-novatek-nt36523.c
@@ -933,8 +933,7 @@ static int j606f_boe_init_sequence(struct panel_info *pinfo)
 
 static const struct drm_display_mode elish_boe_modes[] = {
 	{
-		/* There is only one 120 Hz timing, but it doesn't work perfectly, 104 Hz preferred */
-		.clock = (1600 + 60 + 8 + 60) * (2560 + 26 + 4 + 168) * 104 / 1000,
+		.clock = (1600 + 60 + 8 + 60) * (2560 + 26 + 4 + 168) * 120 / 1000,
 		.hdisplay = 1600,
 		.hsync_start = 1600 + 60,
 		.hsync_end = 1600 + 60 + 8,
@@ -948,8 +947,7 @@ static const struct drm_display_mode elish_boe_modes[] = {
 
 static const struct drm_display_mode elish_csot_modes[] = {
 	{
-		/* There is only one 120 Hz timing, but it doesn't work perfectly, 104 Hz preferred */
-		.clock = (1600 + 200 + 40 + 52) * (2560 + 26 + 4 + 168) * 104 / 1000,
+		.clock = (1600 + 200 + 40 + 52) * (2560 + 26 + 4 + 168) * 120 / 1000,
 		.hdisplay = 1600,
 		.hsync_start = 1600 + 200,
 		.hsync_end = 1600 + 200 + 40,
-- 
2.41.0

Re: [PATCH] drm/panel: nt36523: Set 120Hz fps for xiaomi,elish panels

Posted by Neil Armstrong 1 year, 11 months ago

Hi,

On Fri, 12 Jan 2024 22:00:47 +0800, Jianhua Lu wrote:
> After commit e6c0de5f4450 ("drm/msm/dpu: try multirect based on mdp clock limits")
> merged, 120Hz is working on xiaomi,elish panels, so feature it.
> 
> 

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

[1/1] drm/panel: nt36523: Set 120Hz fps for xiaomi,elish panels
      https://cgit.freedesktop.org/drm/drm-misc/commit/?id=de8ac5696ebc3a2d89c88b70aa3996ee112e76ef

-- 
Neil

Re: [PATCH] drm/panel: nt36523: Set 120Hz fps for xiaomi,elish panels

Posted by Jessica Zhang 1 year, 11 months ago


On 1/12/2024 6:00 AM, Jianhua Lu wrote:
> After commit e6c0de5f4450 ("drm/msm/dpu: try multirect based on mdp clock limits")
> merged, 120Hz is working on xiaomi,elish panels, so feature it.
> 
> Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>

Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>

> ---
>   drivers/gpu/drm/panel/panel-novatek-nt36523.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36523.c b/drivers/gpu/drm/panel/panel-novatek-nt36523.c
> index a189ce236328..d6fa76dbf948 100644
> --- a/drivers/gpu/drm/panel/panel-novatek-nt36523.c
> +++ b/drivers/gpu/drm/panel/panel-novatek-nt36523.c
> @@ -933,8 +933,7 @@ static int j606f_boe_init_sequence(struct panel_info *pinfo)
>   
>   static const struct drm_display_mode elish_boe_modes[] = {
>   	{
> -		/* There is only one 120 Hz timing, but it doesn't work perfectly, 104 Hz preferred */
> -		.clock = (1600 + 60 + 8 + 60) * (2560 + 26 + 4 + 168) * 104 / 1000,
> +		.clock = (1600 + 60 + 8 + 60) * (2560 + 26 + 4 + 168) * 120 / 1000,
>   		.hdisplay = 1600,
>   		.hsync_start = 1600 + 60,
>   		.hsync_end = 1600 + 60 + 8,
> @@ -948,8 +947,7 @@ static const struct drm_display_mode elish_boe_modes[] = {
>   
>   static const struct drm_display_mode elish_csot_modes[] = {
>   	{
> -		/* There is only one 120 Hz timing, but it doesn't work perfectly, 104 Hz preferred */
> -		.clock = (1600 + 200 + 40 + 52) * (2560 + 26 + 4 + 168) * 104 / 1000,
> +		.clock = (1600 + 200 + 40 + 52) * (2560 + 26 + 4 + 168) * 120 / 1000,
>   		.hdisplay = 1600,
>   		.hsync_start = 1600 + 200,
>   		.hsync_end = 1600 + 200 + 40,
> -- 
> 2.41.0
>