[PATCH 09/15] arm64: dts: mediatek: radxa-nio-12l: Enable System Companion Processor

AngeloGioacchino Del Regno posted 15 patches 10 months ago
There is a newer version of this series
[PATCH 09/15] arm64: dts: mediatek: radxa-nio-12l: Enable System Companion Processor
Posted by AngeloGioacchino Del Regno 10 months ago
The SCP is used by the SoC for various tasks, including initializing
hardware video encoding/decoding hardware and managing other remote
processors. Enable this node and assign its own DMA pool to it.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
index 8492cf52413f..5a9e33013209 100644
--- a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
@@ -587,6 +587,11 @@ &pmic {
 	interrupts-extended = <&pio 222 IRQ_TYPE_LEVEL_HIGH>;
 };
 
+&scp {
+	memory-region = <&scp_mem>;
+	status = "okay";
+};
+
 &spmi {
 	#address-cells = <2>;
 	#size-cells = <0>;
-- 
2.43.0
Re: [PATCH 09/15] arm64: dts: mediatek: radxa-nio-12l: Enable System Companion Processor
Posted by Krzysztof Kozlowski 10 months ago
On 12/01/2024 10:46, AngeloGioacchino Del Regno wrote:
> The SCP is used by the SoC for various tasks, including initializing
> hardware video encoding/decoding hardware and managing other remote
> processors. Enable this node and assign its own DMA pool to it.
> 

Please provide reason why this cannot be included in initial submission
and must be split into separate patch. I really do not understand except
some patch count stats.

Best regards,
Krzysztof
Re: [PATCH 09/15] arm64: dts: mediatek: radxa-nio-12l: Enable System Companion Processor
Posted by AngeloGioacchino Del Regno 10 months ago
Il 16/01/24 09:18, Krzysztof Kozlowski ha scritto:
> On 12/01/2024 10:46, AngeloGioacchino Del Regno wrote:
>> The SCP is used by the SoC for various tasks, including initializing
>> hardware video encoding/decoding hardware and managing other remote
>> processors. Enable this node and assign its own DMA pool to it.
>>
> 
> Please provide reason why this cannot be included in initial submission
> and must be split into separate patch. I really do not understand except
> some patch count stats.
> 

This was done to describe both the reasons why each node was enabled at
which point and the actual workflow for the bringup with each commit.

I don't care about the stats.

I will squash some of those patches for v2, anyway.

Regards,
Angelo