[PATCH] scsi: isci: request: Fix an error code problem in isci_io_request_build

Su Hui posted 1 patch 1 year, 11 months ago
drivers/scsi/isci/request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] scsi: isci: request: Fix an error code problem in isci_io_request_build
Posted by Su Hui 1 year, 11 months ago
Clang static complains that Value stored to 'status' is never read.
Return 'status' rather than 'SCI_SUCCESS'.

Fixes: f1f52e75939b ("isci: uplevel request infrastructure")
Signed-off-by: Su Hui <suhui@nfschina.com>
---
 drivers/scsi/isci/request.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/isci/request.c b/drivers/scsi/isci/request.c
index 71f711cb0628..355a0bc0828e 100644
--- a/drivers/scsi/isci/request.c
+++ b/drivers/scsi/isci/request.c
@@ -3387,7 +3387,7 @@ static enum sci_status isci_io_request_build(struct isci_host *ihost,
 		return SCI_FAILURE;
 	}
 
-	return SCI_SUCCESS;
+	return status;
 }
 
 static struct isci_request *isci_request_from_tag(struct isci_host *ihost, u16 tag)
-- 
2.30.2
Re: [PATCH] scsi: isci: request: Fix an error code problem in isci_io_request_build
Posted by Martin K. Petersen 1 year, 11 months ago
> Clang static complains that Value stored to 'status' is never read.
> Return 'status' rather than 'SCI_SUCCESS'.

Applied to 6.8/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering
Re: [PATCH] scsi: isci: request: Fix an error code problem in isci_io_request_build
Posted by Artur Paszkiewicz 1 year, 11 months ago
On 1/12/24 05:19, Su Hui wrote:
> Clang static complains that Value stored to 'status' is never read.
> Return 'status' rather than 'SCI_SUCCESS'.
> 
> Fixes: f1f52e75939b ("isci: uplevel request infrastructure")
> Signed-off-by: Su Hui <suhui@nfschina.com>

Reviewed-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>