[v1] scsi: Replace {v}snprintf() variants with safer alternatives

[PATCH 0/5] scsi: Replace {v}snprintf() variants with safer alternatives

Posted by Lee Jones 1 year, 11 months ago

For a far better description of the problem than I could author, see
Jon's write-up on LWN [1] and/or Alex's on the Kernel Self Protection
Project [1].

[0] https://lwn.net/Articles/69419/
[1] https://github.com/KSPP/linux/issues/105

Lee Jones (5):
  scsi: 3w-9xxx: Remove snprintf() from sysfs call-backs and replace
    with sysfs_emit()
  scsi: 3w-sas: Remove snprintf() from sysfs call-backs and replace with
    sysfs_emit()
  scsi: 3w-xxxx: Remove snprintf() from sysfs call-backs and replace
    with sysfs_emit()
  scsi: 53c700: Remove snprintf() from sysfs call-backs and replace with
    sysfs_emit()
  scsi: aacraid: aachba: Replace snprintf() with the safer scnprintf()
    variant

 drivers/scsi/3w-9xxx.c        |  44 +++++++-------
 drivers/scsi/3w-sas.c         |  36 ++++++------
 drivers/scsi/3w-xxxx.c        |  46 +++++++--------
 drivers/scsi/53c700.c         | 104 +++++++++++++++++-----------------
 drivers/scsi/aacraid/aachba.c |   6 +-
 5 files changed, 118 insertions(+), 118 deletions(-)

Cc: Adam Radford <aradford@gmail.com>
Cc: Adaptec OEM Raid Solutions <aacraid@microsemi.com>
Cc: Andre Hedrick <andre@suse.com>
Cc: de Melo <acme@conectiva.com.br>
Cc: Joel Jacobson <linux@3ware.com>
Cc: "PMC-Sierra, Inc" <aacraid@pmc-sierra.com>
Cc: Richard Hirst <rhirst@linuxcare.com>
-- 
2.43.0.275.g3460e3d667-goog

Re: [PATCH 0/5] scsi: Replace {v}snprintf() variants with safer alternatives

Posted by Martin K. Petersen 1 year, 10 months ago

On Thu, 11 Jan 2024 13:17:21 +0000, Lee Jones wrote:

> For a far better description of the problem than I could author, see
> Jon's write-up on LWN [1] and/or Alex's on the Kernel Self Protection
> Project [1].
> 
> [0] https://lwn.net/Articles/69419/
> [1] https://github.com/KSPP/linux/issues/105
> 
> [...]

Applied to 6.9/scsi-queue, thanks!

[1/5] scsi: 3w-9xxx: Remove snprintf() from sysfs call-backs and replace with sysfs_emit()
      https://git.kernel.org/mkp/scsi/c/a977c8158a42
[2/5] scsi: 3w-sas: Remove snprintf() from sysfs call-backs and replace with sysfs_emit()
      https://git.kernel.org/mkp/scsi/c/7eaa48e9e497
[3/5] scsi: 3w-xxxx: Remove snprintf() from sysfs call-backs and replace with sysfs_emit()
      https://git.kernel.org/mkp/scsi/c/30cc6aa09eee
[4/5] scsi: 53c700: Remove snprintf() from sysfs call-backs and replace with sysfs_emit()
      https://git.kernel.org/mkp/scsi/c/f615c74de383
[5/5] scsi: aacraid: aachba: Replace snprintf() with the safer scnprintf() variant
      https://git.kernel.org/mkp/scsi/c/bc978cc18d46

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH 0/5] scsi: Replace {v}snprintf() variants with safer alternatives

Posted by Martin K. Petersen 1 year, 11 months ago

Lee,

> For a far better description of the problem than I could author, see
> Jon's write-up on LWN [1] and/or Alex's on the Kernel Self Protection
> Project [1].

Applied to 6.9/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering