[v1] staging: vt6655: Remove extra blank lines between code blocks

[PATCH] staging: vt6655: Remove extra blank lines between code blocks

Posted by Pranav Athreya 1 year, 11 months ago

Adhere to Linux kernel coding style.

Reported by checkpatch:

drivers/staging/vt6655/rxtx.h:22: CHECK: Please don't use multiple blank lines

drivers/staging/vt6655/vt6655_stage.mod.c:38: CHECK: Please don't use multiple blank lines
^Ignore the blank lines in vt6655_stage.mod.c since *.mod.c files
are included in .gitignore.

Signed-off-by: Pranav Athreya <pranavsubbu@gmail.com>
---
 drivers/staging/vt6655/rxtx.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/vt6655/rxtx.h b/drivers/staging/vt6655/rxtx.h
index a67757c9bb5c..be1e5180d57b 100644
--- a/drivers/staging/vt6655/rxtx.h
+++ b/drivers/staging/vt6655/rxtx.h
@@ -19,7 +19,6 @@
 #define DEFAULT_MSDU_LIFETIME_RES_64us	8000 /* 64us */
 #define DEFAULT_MGN_LIFETIME_RES_64us	125  /* 64us */
 
-
 /*---------------------  Export Definitions -------------------------*/
 
 /*---------------------  Export Variables  --------------------------*/
-- 
2.34.1

Re: [PATCH] staging: vt6655: Remove extra blank lines between code blocks

Posted by Greg Kroah-Hartman 1 year, 11 months ago

On Thu, Jan 11, 2024 at 12:36:52PM +0530, Pranav Athreya wrote:
> Adhere to Linux kernel coding style.
> 
> Reported by checkpatch:
> 
> drivers/staging/vt6655/rxtx.h:22: CHECK: Please don't use multiple blank lines
> 
> drivers/staging/vt6655/vt6655_stage.mod.c:38: CHECK: Please don't use multiple blank lines
> ^Ignore the blank lines in vt6655_stage.mod.c since *.mod.c files
> are included in .gitignore.

*.mod.c files are not something that you can change, and are not in your
patch either:

> Signed-off-by: Pranav Athreya <pranavsubbu@gmail.com>
> ---
>  drivers/staging/vt6655/rxtx.h | 1 -
>  1 file changed, 1 deletion(-)

So the text is not correct :(

thanks,

greg k-h