Fixes for hang on MT8195-Tomato during mediatek-cpufreq-hw init

[PATCH v2 1/2] arm64: dts: mediatek: cherry: Describe CPU supplies

Posted by Nícolas F. R. A. Prado 2 years, 1 month ago

Describe in each CPU node the regulator supplying it.

Fixes: 260c04d425eb ("arm64: dts: mediatek: cherry: Enable MT6315 regulators on SPMI bus")
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

---

Changes in v2:
- Moved supplies to CPU nodes
- Added fixes tag

 .../boot/dts/mediatek/mt8195-cherry.dtsi      | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
index 3c6079edda19..1f3a6755f155 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
@@ -264,6 +264,38 @@ &auxadc {
 	status = "okay";
 };
 
+&cpu0 {
+	cpu-supply = <&mt6359_vcore_buck_reg>;
+};
+
+&cpu1 {
+	cpu-supply = <&mt6359_vcore_buck_reg>;
+};
+
+&cpu2 {
+	cpu-supply = <&mt6359_vcore_buck_reg>;
+};
+
+&cpu3 {
+	cpu-supply = <&mt6359_vcore_buck_reg>;
+};
+
+&cpu4 {
+	cpu-supply = <&mt6315_6_vbuck1>;
+};
+
+&cpu5 {
+	cpu-supply = <&mt6315_6_vbuck1>;
+};
+
+&cpu6 {
+	cpu-supply = <&mt6315_6_vbuck1>;
+};
+
+&cpu7 {
+	cpu-supply = <&mt6315_6_vbuck1>;
+};
+
 &dp_intf0 {
 	status = "okay";
 
-- 
2.43.0

Re: [PATCH v2 1/2] arm64: dts: mediatek: cherry: Describe CPU supplies

Posted by Nícolas F. R. A. Prado 1 year, 11 months ago

+CC Nicolas Dufresne <nicolas.dufresne@collabora.com>

As he told me he was experiencing the hangs fixed in this series too.

On Wed, Jan 10, 2024 at 11:23:01AM -0300, Nícolas F. R. A. Prado wrote:
> Describe in each CPU node the regulator supplying it.
> 
> Fixes: 260c04d425eb ("arm64: dts: mediatek: cherry: Enable MT6315 regulators on SPMI bus")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> 
> ---
> 
> Changes in v2:
> - Moved supplies to CPU nodes
> - Added fixes tag
> 
>  .../boot/dts/mediatek/mt8195-cherry.dtsi      | 32 +++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> index 3c6079edda19..1f3a6755f155 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> @@ -264,6 +264,38 @@ &auxadc {
>  	status = "okay";
>  };
>  
> +&cpu0 {
> +	cpu-supply = <&mt6359_vcore_buck_reg>;
> +};
> +
> +&cpu1 {
> +	cpu-supply = <&mt6359_vcore_buck_reg>;
> +};
> +
> +&cpu2 {
> +	cpu-supply = <&mt6359_vcore_buck_reg>;
> +};
> +
> +&cpu3 {
> +	cpu-supply = <&mt6359_vcore_buck_reg>;
> +};
> +
> +&cpu4 {
> +	cpu-supply = <&mt6315_6_vbuck1>;
> +};
> +
> +&cpu5 {
> +	cpu-supply = <&mt6315_6_vbuck1>;
> +};
> +
> +&cpu6 {
> +	cpu-supply = <&mt6315_6_vbuck1>;
> +};
> +
> +&cpu7 {
> +	cpu-supply = <&mt6315_6_vbuck1>;
> +};
> +
>  &dp_intf0 {
>  	status = "okay";
>  
> -- 
> 2.43.0
>

Re: [PATCH v2 1/2] arm64: dts: mediatek: cherry: Describe CPU supplies

Posted by AngeloGioacchino Del Regno 2 years, 1 month ago

Il 10/01/24 15:23, Nícolas F. R. A. Prado ha scritto:
> Describe in each CPU node the regulator supplying it.
> 
> Fixes: 260c04d425eb ("arm64: dts: mediatek: cherry: Enable MT6315 regulators on SPMI bus")
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> 

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Re: [PATCH v2 1/2] arm64: dts: mediatek: cherry: Describe CPU supplies

Posted by Nícolas F. R. A. Prado 1 year, 11 months ago

On Wed, Jan 10, 2024 at 03:32:02PM +0100, AngeloGioacchino Del Regno wrote:
> Il 10/01/24 15:23, Nícolas F. R. A. Prado ha scritto:
> > Describe in each CPU node the regulator supplying it.
> > 
> > Fixes: 260c04d425eb ("arm64: dts: mediatek: cherry: Enable MT6315 regulators on SPMI bus")
> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> > 
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Hello,

looks like this patch was never picked up, while the cpufreq part has been
merged for a while, so I'm still getting the mentioned hangs on linux-next.
Could this be queued? :)

Thanks,
Nícolas

Re: [PATCH v2 1/2] arm64: dts: mediatek: cherry: Describe CPU supplies

Posted by AngeloGioacchino Del Regno 1 year, 11 months ago

Il 29/02/24 21:23, Nícolas F. R. A. Prado ha scritto:
> On Wed, Jan 10, 2024 at 03:32:02PM +0100, AngeloGioacchino Del Regno wrote:
>> Il 10/01/24 15:23, Nícolas F. R. A. Prado ha scritto:
>>> Describe in each CPU node the regulator supplying it.
>>>
>>> Fixes: 260c04d425eb ("arm64: dts: mediatek: cherry: Enable MT6315 regulators on SPMI bus")
>>> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>>>
>>
>> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> 
> Hello,
> 
> looks like this patch was never picked up, while the cpufreq part has been
> merged for a while, so I'm still getting the mentioned hangs on linux-next.
> Could this be queued? :)
> 
> Thanks,
> Nícolas

Will send that on the next -fixes round.

Thanks for the reminder.