1. Patchew
  2. linux
  3. View series

[PATCH] wangxunx: select CONFIG_PHYLINK where needed

Arnd Bergmann posted 1 patch 1 year, 11 months ago
There is a newer version of this series
drivers/net/ethernet/wangxun/Kconfig | 1 +
1 file changed, 1 insertion(+)
[PATCH] wangxunx: select CONFIG_PHYLINK where needed
Posted by Arnd Bergmann 1 year, 11 months ago 
From: Arnd Bergmann <arnd@arndb.de>

The ngbe driver needs phylink:

arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_nway_reset':
wx_ethtool.c:(.text+0x458): undefined reference to `phylink_ethtool_nway_reset'
arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/ngbe/ngbe_main.o: in function `ngbe_remove':
ngbe_main.c:(.text+0x7c): undefined reference to `phylink_destroy'
arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/ngbe/ngbe_main.o: in function `ngbe_open':
ngbe_main.c:(.text+0xf90): undefined reference to `phylink_connect_phy'
arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/ngbe/ngbe_mdio.o: in function `ngbe_mdio_init':
ngbe_mdio.c:(.text+0x314): undefined reference to `phylink_create'

Add the missing Kconfig description for this.

Fixes: bc2426d74aa3 ("net: ngbe: convert phylib to phylink")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/ethernet/wangxun/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/wangxun/Kconfig b/drivers/net/ethernet/wangxun/Kconfig
index 23cd610bd376..46630f05d8dd 100644
--- a/drivers/net/ethernet/wangxun/Kconfig
+++ b/drivers/net/ethernet/wangxun/Kconfig
@@ -26,6 +26,7 @@ config NGBE
 	tristate "Wangxun(R) GbE PCI Express adapters support"
 	depends on PCI
 	select LIBWX
+	select PHYLINK
 	select PHYLIB
 	help
 	  This driver supports Wangxun(R) GbE PCI Express family of
-- 
2.39.2
Re: [PATCH] wangxunx: select CONFIG_PHYLINK where needed
Posted by Russell King (Oracle) 1 year, 11 months ago 
On Tue, Jan 09, 2024 at 08:56:21AM +0100, Arnd Bergmann wrote:
> diff --git a/drivers/net/ethernet/wangxun/Kconfig b/drivers/net/ethernet/wangxun/Kconfig
> index 23cd610bd376..46630f05d8dd 100644
> --- a/drivers/net/ethernet/wangxun/Kconfig
> +++ b/drivers/net/ethernet/wangxun/Kconfig
> @@ -26,6 +26,7 @@ config NGBE
>  	tristate "Wangxun(R) GbE PCI Express adapters support"
>  	depends on PCI
>  	select LIBWX
> +	select PHYLINK
>  	select PHYLIB

You can drop PHYLIB when adding PHYLINK.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Re: [PATCH] wangxunx: select CONFIG_PHYLINK where needed
Posted by Russell King (Oracle) 1 year, 11 months ago 
On Tue, Jan 09, 2024 at 09:35:50AM +0000, Russell King (Oracle) wrote:
> On Tue, Jan 09, 2024 at 08:56:21AM +0100, Arnd Bergmann wrote:
> > diff --git a/drivers/net/ethernet/wangxun/Kconfig b/drivers/net/ethernet/wangxun/Kconfig
> > index 23cd610bd376..46630f05d8dd 100644
> > --- a/drivers/net/ethernet/wangxun/Kconfig
> > +++ b/drivers/net/ethernet/wangxun/Kconfig
> > @@ -26,6 +26,7 @@ config NGBE
> >  	tristate "Wangxun(R) GbE PCI Express adapters support"
> >  	depends on PCI
> >  	select LIBWX
> > +	select PHYLINK
> >  	select PHYLIB
> 
> You can drop PHYLIB when adding PHYLINK.

Arnd,

There are repeated complaints from the kernel build bot about this, and
it would be good to get it solved. Could we have an updated patch
submitted to netdev please? This is in net-next only at the moment,
so I think that means it needs to be submitted with:

	[PATCH net-next ...]

and please make it clear that it is a fix for code only in net-next.
(However, netdev folk may request it to be referred until net-next is
merged and then against the net tree...)

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Re: [PATCH] wangxunx: select CONFIG_PHYLINK where needed
Posted by Arnd Bergmann 1 year, 11 months ago 
On Thu, Jan 11, 2024, at 16:49, Russell King (Oracle) wrote:
> On Tue, Jan 09, 2024 at 09:35:50AM +0000, Russell King (Oracle) wrote:
>> On Tue, Jan 09, 2024 at 08:56:21AM +0100, Arnd Bergmann wrote:
>> > diff --git a/drivers/net/ethernet/wangxun/Kconfig b/drivers/net/ethernet/wangxun/Kconfig
>> > index 23cd610bd376..46630f05d8dd 100644
>> > --- a/drivers/net/ethernet/wangxun/Kconfig
>> > +++ b/drivers/net/ethernet/wangxun/Kconfig
>> > @@ -26,6 +26,7 @@ config NGBE
>> >  	tristate "Wangxun(R) GbE PCI Express adapters support"
>> >  	depends on PCI
>> >  	select LIBWX
>> > +	select PHYLINK
>> >  	select PHYLIB
>> 
>> You can drop PHYLIB when adding PHYLINK.
>
> Arnd,
>
> There are repeated complaints from the kernel build bot about this, and
> it would be good to get it solved. Could we have an updated patch
> submitted to netdev please? This is in net-next only at the moment,
> so I think that means it needs to be submitted with:
>
> 	[PATCH net-next ...]
>
> and please make it clear that it is a fix for code only in net-next.
> (However, netdev folk may request it to be referred until net-next is
> merged and then against the net tree...)

Sent now, thanks for the reminder.

     Arnd
RE: [PATCH] wangxunx: select CONFIG_PHYLINK where needed
Posted by Jiawen Wu 1 year, 11 months ago 
> -----Original Message-----
> From: Arnd Bergmann <arnd@kernel.org>
> Sent: Tuesday, January 9, 2024 3:56 PM
> To: Jiawen Wu <jiawenwu@trustnetic.com>; Mengyuan Lou <mengyuanlou@net-swift.com>; Jakub Kicinski <kuba@kernel.org>
> Cc: Arnd Bergmann <arnd@arndb.de>; David S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Paolo
> Abeni <pabeni@redhat.com>; Russell King <linux@armlinux.org.uk>; Andrew Lunn <andrew@lunn.ch>; Maciej Fijalkowski
> <maciej.fijalkowski@intel.com>; Andy Shevchenko <andriy.shevchenko@linux.intel.com>; Russell King (Oracle)
> <rmk+kernel@armlinux.org.uk>; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] wangxunx: select CONFIG_PHYLINK where needed
> 
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The ngbe driver needs phylink:
> 
> arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/libwx/wx_ethtool.o: in function `wx_nway_reset':
> wx_ethtool.c:(.text+0x458): undefined reference to `phylink_ethtool_nway_reset'
> arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/ngbe/ngbe_main.o: in function `ngbe_remove':
> ngbe_main.c:(.text+0x7c): undefined reference to `phylink_destroy'
> arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/ngbe/ngbe_main.o: in function `ngbe_open':
> ngbe_main.c:(.text+0xf90): undefined reference to `phylink_connect_phy'
> arm-linux-gnueabi-ld: drivers/net/ethernet/wangxun/ngbe/ngbe_mdio.o: in function `ngbe_mdio_init':
> ngbe_mdio.c:(.text+0x314): undefined reference to `phylink_create'
> 
> Add the missing Kconfig description for this.
> 
> Fixes: bc2426d74aa3 ("net: ngbe: convert phylib to phylink")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/net/ethernet/wangxun/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/wangxun/Kconfig b/drivers/net/ethernet/wangxun/Kconfig
> index 23cd610bd376..46630f05d8dd 100644
> --- a/drivers/net/ethernet/wangxun/Kconfig
> +++ b/drivers/net/ethernet/wangxun/Kconfig
> @@ -26,6 +26,7 @@ config NGBE
>  	tristate "Wangxun(R) GbE PCI Express adapters support"
>  	depends on PCI
>  	select LIBWX
> +	select PHYLINK
>  	select PHYLIB
>  	help
>  	  This driver supports Wangxun(R) GbE PCI Express family of
> --
> 2.39.2

Reviewed-by: Jiawen Wu <jiawenwu@trustnetic.com>

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.