[PATCH -next] cxl: Remove duplicated include in cdat.c

Yang Li posted 1 patch 1 year, 11 months ago
drivers/cxl/core/cdat.c | 1 -
1 file changed, 1 deletion(-)
[PATCH -next] cxl: Remove duplicated include in cdat.c
Posted by Yang Li 1 year, 11 months ago
The header files core.h is included twice in cdat.c,
so one inclusion can be removed.

Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/cxl/core/cdat.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c
index f5e649407b8b..6fe11546889f 100644
--- a/drivers/cxl/core/cdat.c
+++ b/drivers/cxl/core/cdat.c
@@ -9,7 +9,6 @@
 #include "cxlmem.h"
 #include "core.h"
 #include "cxl.h"
-#include "core.h"
 
 struct dsmas_entry {
 	struct range dpa_range;
-- 
2.20.1.7.g153144c
RE: [PATCH -next] cxl: Remove duplicated include in cdat.c
Posted by Dan Williams 1 year, 11 months ago
Yang Li wrote:
> The header files core.h is included twice in cdat.c,
> so one inclusion can be removed.
> 
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/cxl/core/cdat.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c
> index f5e649407b8b..6fe11546889f 100644
> --- a/drivers/cxl/core/cdat.c
> +++ b/drivers/cxl/core/cdat.c
> @@ -9,7 +9,6 @@
>  #include "cxlmem.h"
>  #include "core.h"
>  #include "cxl.h"
> -#include "core.h"

I believe that was due to a bad merge by me. That's fixed up now with a
better merge commit.

Thanks for spotting this though!
Re: [PATCH -next] cxl: Remove duplicated include in cdat.c
Posted by Dave Jiang 1 year, 11 months ago

On 1/8/24 17:47, Yang Li wrote:
> The header files core.h is included twice in cdat.c,
> so one inclusion can be removed.
> 
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  drivers/cxl/core/cdat.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c
> index f5e649407b8b..6fe11546889f 100644
> --- a/drivers/cxl/core/cdat.c
> +++ b/drivers/cxl/core/cdat.c
> @@ -9,7 +9,6 @@
>  #include "cxlmem.h"
>  #include "core.h"
>  #include "cxl.h"
> -#include "core.h"
>  
>  struct dsmas_entry {
>  	struct range dpa_range;
Re: [PATCH -next] cxl: Remove duplicated include in cdat.c
Posted by Jonathan Cameron 1 year, 11 months ago
On Tue, 9 Jan 2024 08:47:28 +0800
Yang Li <yang.lee@linux.alibaba.com> wrote:

> The header files core.h is included twice in cdat.c,
> so one inclusion can be removed.
> 
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Obviously correct :)

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
>  drivers/cxl/core/cdat.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/cxl/core/cdat.c b/drivers/cxl/core/cdat.c
> index f5e649407b8b..6fe11546889f 100644
> --- a/drivers/cxl/core/cdat.c
> +++ b/drivers/cxl/core/cdat.c
> @@ -9,7 +9,6 @@
>  #include "cxlmem.h"
>  #include "core.h"
>  #include "cxl.h"
> -#include "core.h"
>  
>  struct dsmas_entry {
>  	struct range dpa_range;