[v2] checkpatch: ignore deleted lines for comment context

[PATCH v2] checkpatch: ignore deleted lines for comment context

Andreas Dilger posted 1 patch 1 year, 11 months ago

Diff against v1 v1 v2
Download mbox

There is a newer version of this series

scripts/checkpatch.pl | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH v2] checkpatch: ignore deleted lines for comment context

Posted by Andreas Dilger 1 year, 11 months ago

Don't consider lines being removed by a patch as part of the context.
Otherwise, false "WARNING: memory barrier without comment" and similar
warnings can be reported when a comment exists on the previous line.

For example, a change like below was previously incorrectly flagged:

	/* matched by smp_store_release() in some_function() */
 -	if (smp_load_acquire(&list->tail) == head))
 +	if (smp_load_acquire(&list->tail) == head) && flags == 0)

Signed-off-by: Andreas Dilger <adilger@dilger.ca>
---
  V1 -> V2: don't include extra debugging in 'warn' line

 scripts/checkpatch.pl | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 25fdb7fda112..316a65354718 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1973,6 +1973,7 @@ sub ctx_locate_comment {
 	for (my $linenr = $first_line; $linenr < $end_line; $linenr++) {
 		my $line = $rawlines[$linenr - 1];
 		#warn "           $line\n";
+		next if ($line =~ /^-/); # ignore lines removed by patch
 		if ($linenr == $first_line and $line =~ m@^.\s*\*@) {
 			$in_comment = 1;
 		}
-- 
2.25.1