[PATCH v22 7/8] arm64: dts: nuvoton: npcm8xx: replace reg with syscon property

Tomer Maimon posted 8 patches 1 year, 11 months ago
There is a newer version of this series
[PATCH v22 7/8] arm64: dts: nuvoton: npcm8xx: replace reg with syscon property
Posted by Tomer Maimon 1 year, 11 months ago
Replace reg with syscon property since the clock registers handle the
reset registers as well.

Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
---
 arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
index 7d5956e2c9f3..5cc0efdbb3c7 100644
--- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
+++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
@@ -59,10 +59,10 @@ rstc: reset-controller@f0801000 {
 			nuvoton,sysgcr = <&gcr>;
 		};
 
-		clk: clock-controller@f0801000 {
+		clk: clock-controller {
 			compatible = "nuvoton,npcm845-clk";
 			#clock-cells = <1>;
-			reg = <0x0 0xf0801000 0x0 0x1000>;
+			nuvoton,sysclk = <&clk_rst>;
 			clocks = <&refclk>;
 			clock-names = "refclk";
 		};
-- 
2.34.1
Re: [PATCH v22 7/8] arm64: dts: nuvoton: npcm8xx: replace reg with syscon property
Posted by Krzysztof Kozlowski 1 year, 11 months ago
On 08/01/2024 14:54, Tomer Maimon wrote:
> Replace reg with syscon property since the clock registers handle the
> reset registers as well.
> 
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> ---

NAK for the same reasons as previous patch.

Best regards,
Krzysztof
Re: [PATCH v22 7/8] arm64: dts: nuvoton: npcm8xx: replace reg with syscon property
Posted by Tomer Maimon 1 year, 11 months ago
Hi Krzysztof,

Thanks for your comment.

On Wed, 10 Jan 2024 at 22:59, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 08/01/2024 14:54, Tomer Maimon wrote:
> > Replace reg with syscon property since the clock registers handle the
> > reset registers as well.
> >
> > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> > ---
>
> NAK for the same reasons as previous patch.
Will explain more in the commit message
>
> Best regards,
> Krzysztof
>

Best regards,

Tomer
Re: [PATCH v22 7/8] arm64: dts: nuvoton: npcm8xx: replace reg with syscon property
Posted by Krzysztof Kozlowski 1 year, 11 months ago
On 16/01/2024 20:39, Tomer Maimon wrote:
> Hi Krzysztof,
> 
> Thanks for your comment.
> 
> On Wed, 10 Jan 2024 at 22:59, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 08/01/2024 14:54, Tomer Maimon wrote:
>>> Replace reg with syscon property since the clock registers handle the
>>> reset registers as well.
>>>
>>> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
>>> ---
>>
>> NAK for the same reasons as previous patch.
> Will explain more in the commit message

No, this wasn't even tested. Build your code with W=1 and fix all
warnings first. But anyway this is not the way to go.

Best regards,
Krzysztof