scripts/min-tool-version.sh: Raise min clang version to 18.0.0 for loongarch

[PATCH] scripts/min-tool-version.sh: Raise min clang version to 18.0.0 for loongarch

Posted by WANG Rui 1 year, 11 months ago

The existing mainline clang development version encounters diffculties
compiling the LoongArch kernel module. It is anticipated that this issue
will be resolved in the upcoming 18.0.0 release. To prevent user
confusion arising from broken builds, it is advisable to raise the
minimum required clang version for LoongArch to 18.0.0.

Suggested-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Signed-off-by: WANG Rui <wangrui@loongson.cn>
---
 scripts/min-tool-version.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/scripts/min-tool-version.sh b/scripts/min-tool-version.sh
index c62066825f53..9faa4d3d91e3 100755
--- a/scripts/min-tool-version.sh
+++ b/scripts/min-tool-version.sh
@@ -26,6 +26,8 @@ gcc)
 llvm)
 	if [ "$SRCARCH" = s390 ]; then
 		echo 15.0.0
+	elif [ "$SRCARCH" = loongarch ]; then
+		echo 18.0.0
 	else
 		echo 11.0.0
 	fi
-- 
2.43.0

Re: [PATCH] scripts/min-tool-version.sh: Raise min clang version to 18.0.0 for loongarch

Posted by Nathan Chancellor 1 year, 11 months ago

On Mon, Jan 08, 2024 at 11:31:38AM +0800, WANG Rui wrote:
> The existing mainline clang development version encounters diffculties
> compiling the LoongArch kernel module. It is anticipated that this issue
> will be resolved in the upcoming 18.0.0 release. To prevent user
> confusion arising from broken builds, it is advisable to raise the
> minimum required clang version for LoongArch to 18.0.0.
> 
> Suggested-by: Nathan Chancellor <nathan@kernel.org>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> Signed-off-by: WANG Rui <wangrui@loongson.cn>

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

Thanks a lot for all the work driving getting everything to work
properly with LLVM!

> ---
>  scripts/min-tool-version.sh | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/scripts/min-tool-version.sh b/scripts/min-tool-version.sh
> index c62066825f53..9faa4d3d91e3 100755
> --- a/scripts/min-tool-version.sh
> +++ b/scripts/min-tool-version.sh
> @@ -26,6 +26,8 @@ gcc)
>  llvm)
>  	if [ "$SRCARCH" = s390 ]; then
>  		echo 15.0.0
> +	elif [ "$SRCARCH" = loongarch ]; then
> +		echo 18.0.0
>  	else
>  		echo 11.0.0
>  	fi
> -- 
> 2.43.0
> 
>

Re: [PATCH] scripts/min-tool-version.sh: Raise min clang version to 18.0.0 for loongarch

Posted by Huacai Chen 1 year, 11 months ago

Applied with R-b/A-b tags and fix typo together, thanks.

Huacai

On Tue, Jan 9, 2024 at 12:38 AM Nathan Chancellor <nathan@kernel.org> wrote:
>
> On Mon, Jan 08, 2024 at 11:31:38AM +0800, WANG Rui wrote:
> > The existing mainline clang development version encounters diffculties
> > compiling the LoongArch kernel module. It is anticipated that this issue
> > will be resolved in the upcoming 18.0.0 release. To prevent user
> > confusion arising from broken builds, it is advisable to raise the
> > minimum required clang version for LoongArch to 18.0.0.
> >
> > Suggested-by: Nathan Chancellor <nathan@kernel.org>
> > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> > Signed-off-by: WANG Rui <wangrui@loongson.cn>
>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
>
> Thanks a lot for all the work driving getting everything to work
> properly with LLVM!
>
> > ---
> >  scripts/min-tool-version.sh | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/scripts/min-tool-version.sh b/scripts/min-tool-version.sh
> > index c62066825f53..9faa4d3d91e3 100755
> > --- a/scripts/min-tool-version.sh
> > +++ b/scripts/min-tool-version.sh
> > @@ -26,6 +26,8 @@ gcc)
> >  llvm)
> >       if [ "$SRCARCH" = s390 ]; then
> >               echo 15.0.0
> > +     elif [ "$SRCARCH" = loongarch ]; then
> > +             echo 18.0.0
> >       else
> >               echo 11.0.0
> >       fi
> > --
> > 2.43.0
> >
> >
>

Re: [PATCH] scripts/min-tool-version.sh: Raise min clang version to 18.0.0 for loongarch

Posted by Nick Desaulniers 1 year, 11 months ago

On Sun, Jan 7, 2024 at 7:32 PM WANG Rui <wangrui@loongson.cn> wrote:
>
> The existing mainline clang development version encounters diffculties

s/diffculties/difficulties/

> compiling the LoongArch kernel module. It is anticipated that this issue
> will be resolved in the upcoming 18.0.0 release. To prevent user
> confusion arising from broken builds, it is advisable to raise the
> minimum required clang version for LoongArch to 18.0.0.
>
> Suggested-by: Nathan Chancellor <nathan@kernel.org>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> Signed-off-by: WANG Rui <wangrui@loongson.cn>

Thanks for all of the work here; it's nice to observe the progress.

Acked-by: Nick Desaulniers <ndesaulniers@google.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1941

> ---
>  scripts/min-tool-version.sh | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/scripts/min-tool-version.sh b/scripts/min-tool-version.sh
> index c62066825f53..9faa4d3d91e3 100755
> --- a/scripts/min-tool-version.sh
> +++ b/scripts/min-tool-version.sh
> @@ -26,6 +26,8 @@ gcc)
>  llvm)
>         if [ "$SRCARCH" = s390 ]; then
>                 echo 15.0.0
> +       elif [ "$SRCARCH" = loongarch ]; then
> +               echo 18.0.0
>         else
>                 echo 11.0.0
>         fi
> --
> 2.43.0
>
>


-- 
Thanks,
~Nick Desaulniers