dt-bindings: usb: Add Marvell ac5

[PATCH] dt-bindings: usb: Add Marvell ac5

Posted by Elad Nachman 2 years, 1 month ago

From: Elad Nachman <enachman@marvell.com>

Add Marvell ac5 device tree bindings to generic EHCI.
This compatible enables the Marvell Orion platform code
to properly configure the DMA mask for the Marvell AC5 SOC.

Signed-off-by: Elad Nachman <enachman@marvell.com>
---
 Documentation/devicetree/bindings/usb/generic-ehci.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
index 87986c45be88..2ed178f16a78 100644
--- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
+++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
@@ -77,6 +77,7 @@ properties:
           - const: usb-ehci
       - enum:
           - generic-ehci
+          - marvell,ac5-ehci
           - marvell,armada-3700-ehci
           - marvell,orion-ehci
           - nuvoton,npcm750-ehci
-- 
2.25.1

Re: [PATCH] dt-bindings: usb: Add Marvell ac5

Posted by Conor Dooley 2 years, 1 month ago

On Sun, Jan 07, 2024 at 05:25:57PM +0200, Elad Nachman wrote:
> From: Elad Nachman <enachman@marvell.com>
> 
> Add Marvell ac5 device tree bindings to generic EHCI.
> This compatible enables the Marvell Orion platform code
> to properly configure the DMA mask for the Marvell AC5 SOC.
> 
> Signed-off-by: Elad Nachman <enachman@marvell.com>

Maybe I am dumb, but I don't understand how this does what the commit
message says. There's no fallback to generic-ehci or any other
compatible that is already understood by the driver.

What am I missing?

> ---
>  Documentation/devicetree/bindings/usb/generic-ehci.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> index 87986c45be88..2ed178f16a78 100644
> --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
> @@ -77,6 +77,7 @@ properties:
>            - const: usb-ehci
>        - enum:
>            - generic-ehci
> +          - marvell,ac5-ehci
>            - marvell,armada-3700-ehci
>            - marvell,orion-ehci
>            - nuvoton,npcm750-ehci
> -- 
> 2.25.1
>