1. Patchew
  2. linux
  3. [PATCH 0/8] Add display support for stm32f769-disco board
  4. View patch

[PATCH 5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK

Dario Binacchi posted 8 patches 1 year, 12 months ago
There is a newer version of this series
[PATCH 5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK
Posted by Dario Binacchi 1 year, 12 months ago 
The patch adds the FRIDA FRD400B25025-A-CTK panel, which belongs to the
Novatek NT35510-based panel family.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

 .../display/panel/novatek,nt35510.yaml        | 20 +++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
index bc92928c805b..511b93a376b7 100644
--- a/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
+++ b/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
@@ -14,14 +14,18 @@ allOf:
 
 properties:
   compatible:
-    items:
-      - const: hydis,hva40wv1
-      - const: novatek,nt35510
-    description: This indicates the panel manufacturer of the panel
-      that is in turn using the NT35510 panel driver. The compatible
-      string determines how the NT35510 panel driver shall be configured
-      to work with the indicated panel. The novatek,nt35510 compatible shall
-      always be provided as a fallback.
+    oneOf:
+      items:
+        - const: hydis,hva40wv1
+        - const: novatek,nt35510
+      items:
+        - const: frida,frd400b25025
+        - const: novatek,nt35510
+      description: This indicates the panel manufacturer of the panel
+        that is in turn using the NT35510 panel driver. The compatible
+        string determines how the NT35510 panel driver shall be configured
+        to work with the indicated panel. The novatek,nt35510 compatible shall
+        always be provided as a fallback.
   reg: true
   reset-gpios: true
   vdd-supply:
-- 
2.43.0
Re: [PATCH 5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK
Posted by kernel test robot 1 year, 12 months ago 
Hi Dario,

kernel test robot noticed the following build warnings:

[auto build test WARNING on atorgue-stm32/stm32-next]
[also build test WARNING on drm-misc/drm-misc-next lee-mfd/for-mfd-next robh/for-next linus/master v6.7-rc7 next-20231222]
[cannot apply to lee-mfd/for-mfd-fixes]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Dario-Binacchi/dt-bindings-mfd-stm32f7-Add-binding-definition-for-DSI/20231229-215601
base:   https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
patch link:    https://lore.kernel.org/r/20231229135154.675946-6-dario.binacchi%40amarulasolutions.com
patch subject: [PATCH 5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK
:::::: branch date: 20 hours ago
:::::: commit date: 20 hours ago
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231230/202312301748.2BRGs7Xs-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202312301748.2BRGs7Xs-lkp@intel.com/

dtcheck warnings: (new ones prefixed by >>)
>> Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml:21:7: [error] duplication of key "items" in mapping (key-duplicates)
--
>> Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml:21:7: found duplicate key "items" with value "[]" (original value: "[]")
   Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml: properties:honeywell,pmin-pascal: '$ref' should not be valid under {'const': '$ref'}
   	hint: Standard unit suffix properties don't need a type $ref
   	from schema $id: http://devicetree.org/meta-schemas/core.yaml#
   Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml: properties:honeywell,pmax-pascal: '$ref' should not be valid under {'const': '$ref'}
   	hint: Standard unit suffix properties don't need a type $ref
   	from schema $id: http://devicetree.org/meta-schemas/core.yaml#
--
>> Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml: ignoring, error parsing file
   Documentation/devicetree/bindings/net/snps,dwmac.yaml: mac-mode: missing type definition

vim +/items +21 Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml

5ce96fe032f43e Linus Walleij  2020-02-23   8  
5ce96fe032f43e Linus Walleij  2020-02-23   9  maintainers:
5ce96fe032f43e Linus Walleij  2020-02-23  10    - Linus Walleij <linus.walleij@linaro.org>
5ce96fe032f43e Linus Walleij  2020-02-23  11  
5ce96fe032f43e Linus Walleij  2020-02-23  12  allOf:
5ce96fe032f43e Linus Walleij  2020-02-23  13    - $ref: panel-common.yaml#
5ce96fe032f43e Linus Walleij  2020-02-23  14  
5ce96fe032f43e Linus Walleij  2020-02-23  15  properties:
5ce96fe032f43e Linus Walleij  2020-02-23  16    compatible:
859f1d9e26606c Dario Binacchi 2023-12-29  17      oneOf:
5ce96fe032f43e Linus Walleij  2020-02-23  18        items:
5ce96fe032f43e Linus Walleij  2020-02-23  19          - const: hydis,hva40wv1
5ce96fe032f43e Linus Walleij  2020-02-23  20          - const: novatek,nt35510
859f1d9e26606c Dario Binacchi 2023-12-29 @21        items:
859f1d9e26606c Dario Binacchi 2023-12-29  22          - const: frida,frd400b25025
859f1d9e26606c Dario Binacchi 2023-12-29  23          - const: novatek,nt35510
5ce96fe032f43e Linus Walleij  2020-02-23  24        description: This indicates the panel manufacturer of the panel
5ce96fe032f43e Linus Walleij  2020-02-23  25          that is in turn using the NT35510 panel driver. The compatible
5ce96fe032f43e Linus Walleij  2020-02-23  26          string determines how the NT35510 panel driver shall be configured
5ce96fe032f43e Linus Walleij  2020-02-23  27          to work with the indicated panel. The novatek,nt35510 compatible shall
5ce96fe032f43e Linus Walleij  2020-02-23  28          always be provided as a fallback.
5ce96fe032f43e Linus Walleij  2020-02-23  29    reg: true
5ce96fe032f43e Linus Walleij  2020-02-23  30    reset-gpios: true
5ce96fe032f43e Linus Walleij  2020-02-23  31    vdd-supply:
5ce96fe032f43e Linus Walleij  2020-02-23  32      description: regulator that supplies the vdd voltage
5ce96fe032f43e Linus Walleij  2020-02-23  33    vddi-supply:
5ce96fe032f43e Linus Walleij  2020-02-23  34      description: regulator that supplies the vddi voltage
5ce96fe032f43e Linus Walleij  2020-02-23  35    backlight: true
5ce96fe032f43e Linus Walleij  2020-02-23  36  
5ce96fe032f43e Linus Walleij  2020-02-23  37  required:
5ce96fe032f43e Linus Walleij  2020-02-23  38    - compatible
5ce96fe032f43e Linus Walleij  2020-02-23  39    - reg
5ce96fe032f43e Linus Walleij  2020-02-23  40  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Re: [PATCH 5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK
Posted by Linus Walleij 1 year, 12 months ago 
Hi Dario,

thanks for your patch!

On Fri, Dec 29, 2023 at 2:52 PM Dario Binacchi
<dario.binacchi@amarulasolutions.com> wrote:

> The patch adds the FRIDA FRD400B25025-A-CTK panel, which belongs to the
> Novatek NT35510-based panel family.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
(...)


> +    oneOf:
> +      items:
> +        - const: hydis,hva40wv1
> +        - const: novatek,nt35510
> +      items:
> +        - const: frida,frd400b25025
> +        - const: novatek,nt35510

You need a dash in from of each "items:" for that to work.

Yours,
Linus Walleij
Re: [PATCH 5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK
Posted by Dario Binacchi 1 year, 12 months ago 
Hi Linus,

On Fri, Dec 29, 2023 at 6:34 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> Hi Dario,
>
> thanks for your patch!
>
> On Fri, Dec 29, 2023 at 2:52 PM Dario Binacchi
> <dario.binacchi@amarulasolutions.com> wrote:
>
> > The patch adds the FRIDA FRD400B25025-A-CTK panel, which belongs to the
> > Novatek NT35510-based panel family.
> >
> > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> (...)
>
>
> > +    oneOf:
> > +      items:
> > +        - const: hydis,hva40wv1
> > +        - const: novatek,nt35510
> > +      items:
> > +        - const: frida,frd400b25025
> > +        - const: novatek,nt35510
>
> You need a dash in from of each "items:" for that to work.

Thanks for your help.

Regards
Dario

>
> Yours,
> Linus Walleij



-- 

Dario Binacchi

Senior Embedded Linux Developer

dario.binacchi@amarulasolutions.com

__________________________________


Amarula Solutions SRL

Via Le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 042 243 5310
info@amarulasolutions.com

www.amarulasolutions.com
Re: [PATCH 5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK
Posted by Rob Herring 1 year, 12 months ago 
On Fri, 29 Dec 2023 14:51:20 +0100, Dario Binacchi wrote:
> The patch adds the FRIDA FRD400B25025-A-CTK panel, which belongs to the
> Novatek NT35510-based panel family.
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
> 
>  .../display/panel/novatek,nt35510.yaml        | 20 +++++++++++--------
>  1 file changed, 12 insertions(+), 8 deletions(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml:21:7: [error] duplication of key "items" in mapping (key-duplicates)

dtschema/dtc warnings/errors:
make[2]: *** Deleting file 'Documentation/devicetree/bindings/display/panel/novatek,nt35510.example.dts'
Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml:21:7: found duplicate key "items" with value "[]" (original value: "[]")
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/display/panel/novatek,nt35510.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
./Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml:21:7: found duplicate key "items" with value "[]" (original value: "[]")
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml: ignoring, error parsing file
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1424: dt_binding_check] Error 2
make: *** [Makefile:234: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231229135154.675946-6-dario.binacchi@amarulasolutions.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.