1. Patchew
  2. linux
  3. View series

[PATCH RESEND v2] arm64: dts: mt8195-cherry-tomato: change watchdog reset boot flow

Hsin-Te Yuan posted 1 patch 8 months, 3 weeks ago
There is a newer version of this series
arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts | 4 ++++
arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts | 4 ++++
arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts | 4 ++++
3 files changed, 12 insertions(+)
[PATCH RESEND v2] arm64: dts: mt8195-cherry-tomato: change watchdog reset boot flow
Posted by Hsin-Te Yuan 8 months, 3 weeks ago 
The external output reset signal was originally disabled and sent from
firmware. However, an unfixed bug in the firmware on tomato prevents
the signal from being sent, causing the device to fail to boot. To fix
this, enable external output reset signal to allow the device to reboot
normally.

Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>

---

Changes in v2:
- Limit the effect only on tomato.

---
 arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts | 4 ++++
 arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts | 4 ++++
 arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts | 4 ++++
 3 files changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts
index 2d5e8f371b6d..a82d716f10d4 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts
@@ -23,3 +23,7 @@ &sound {
 &ts_10 {
 	status = "okay";
 };
+
+&watchdog {
+	/delete-property/ mediatek,disable-extrst;
+};
diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts
index 2586c32ce6e6..2fe20e0dad83 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts
@@ -43,3 +43,7 @@ &sound {
 &ts_10 {
 	status = "okay";
 };
+
+&watchdog {
+	/delete-property/ mediatek,disable-extrst;
+};
diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts
index f54f9477b99d..dd294ca98194 100644
--- a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts
@@ -44,3 +44,7 @@ &sound {
 &ts_10 {
 	status = "okay";
 };
+
+&watchdog {
+	/delete-property/ mediatek,disable-extrst;
+};
-- 
2.43.0.472.g3155946c3a-goog
Re: [PATCH RESEND v2] arm64: dts: mt8195-cherry-tomato: change watchdog reset boot flow
Posted by Chen-Yu Tsai 8 months ago 
+CC Nicolas

On Thu, Dec 28, 2023 at 6:57 PM Hsin-Te Yuan <yuanhsinte@chromium.org> wrote:
>
> The external output reset signal was originally disabled and sent from
> firmware. However, an unfixed bug in the firmware on tomato prevents
> the signal from being sent, causing the device to fail to boot. To fix
> this, enable external output reset signal to allow the device to reboot
> normally.
>
> Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>

Friendly ping?

Also wondering if you folks hit this, or if you haven't triggered the
watchdog at all.

ChenYu

> ---
>
> Changes in v2:
> - Limit the effect only on tomato.
>
> ---
>  arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts | 4 ++++
>  arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts | 4 ++++
>  arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts | 4 ++++
>  3 files changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts
> index 2d5e8f371b6d..a82d716f10d4 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts
> @@ -23,3 +23,7 @@ &sound {
>  &ts_10 {
>         status = "okay";
>  };
> +
> +&watchdog {
> +       /delete-property/ mediatek,disable-extrst;
> +};
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts
> index 2586c32ce6e6..2fe20e0dad83 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts
> @@ -43,3 +43,7 @@ &sound {
>  &ts_10 {
>         status = "okay";
>  };
> +
> +&watchdog {
> +       /delete-property/ mediatek,disable-extrst;
> +};
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts
> index f54f9477b99d..dd294ca98194 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts
> @@ -44,3 +44,7 @@ &sound {
>  &ts_10 {
>         status = "okay";
>  };
> +
> +&watchdog {
> +       /delete-property/ mediatek,disable-extrst;
> +};
> --
> 2.43.0.472.g3155946c3a-goog
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH RESEND v2] arm64: dts: mt8195-cherry-tomato: change watchdog reset boot flow
Posted by AngeloGioacchino Del Regno 8 months ago 
Il 23/01/24 05:03, Chen-Yu Tsai ha scritto:
> +CC Nicolas
> 
> On Thu, Dec 28, 2023 at 6:57 PM Hsin-Te Yuan <yuanhsinte@chromium.org> wrote:
>>
>> The external output reset signal was originally disabled and sent from
>> firmware. However, an unfixed bug in the firmware on tomato prevents
>> the signal from being sent, causing the device to fail to boot. To fix
>> this, enable external output reset signal to allow the device to reboot
>> normally.
>>
>> Signed-off-by: Hsin-Te Yuan <yuanhsinte@chromium.org>
> 
> Friendly ping?
> 
> Also wondering if you folks hit this, or if you haven't triggered the
> watchdog at all.
> 

I have never seen any watchdog timeout on Tomato R2.

In any case - this commit misses a Fixes tag...

Cheers,
Angelo

> ChenYu
> 
>> ---
>>
>> Changes in v2:
>> - Limit the effect only on tomato.
>>
>> ---
>>   arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts | 4 ++++
>>   arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts | 4 ++++
>>   arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts | 4 ++++
>>   3 files changed, 12 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts
>> index 2d5e8f371b6d..a82d716f10d4 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts
>> @@ -23,3 +23,7 @@ &sound {
>>   &ts_10 {
>>          status = "okay";
>>   };
>> +
>> +&watchdog {
>> +       /delete-property/ mediatek,disable-extrst;
>> +};
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts
>> index 2586c32ce6e6..2fe20e0dad83 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts
>> @@ -43,3 +43,7 @@ &sound {
>>   &ts_10 {
>>          status = "okay";
>>   };
>> +
>> +&watchdog {
>> +       /delete-property/ mediatek,disable-extrst;
>> +};
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts
>> index f54f9477b99d..dd294ca98194 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts
>> @@ -44,3 +44,7 @@ &sound {
>>   &ts_10 {
>>          status = "okay";
>>   };
>> +
>> +&watchdog {
>> +       /delete-property/ mediatek,disable-extrst;
>> +};
>> --
>> 2.43.0.472.g3155946c3a-goog
>>

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.