1. Patchew
  2. linux
  3. View series

[PATCH] android: removed asm-generic/errno-base.h

Tanzir Hasan posted 1 patch 2 years ago 
drivers/android/binderfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] android: removed asm-generic/errno-base.h
Posted by Tanzir Hasan 2 years ago 
asm-generic/errno-base.h can be replaced by linux/errno.h and the file
will still build correctly. It is an asm-generic file which should be
avoided if possible.

Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Tanzir Hasan <tanzirh@google.com>
---
 drivers/android/binderfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
index 1224ab7aa070..d04ff6029480 100644
--- a/drivers/android/binderfs.c
+++ b/drivers/android/binderfs.c
@@ -29,7 +29,7 @@
 #include <linux/uaccess.h>
 #include <linux/user_namespace.h>
 #include <linux/xarray.h>
-#include <uapi/asm-generic/errno-base.h>
+#include <linux/errno.h>
 #include <uapi/linux/android/binder.h>
 #include <uapi/linux/android/binderfs.h>
 

---
base-commit: 606d9c29e71fbf52fcfd3fcc3ad92e444c8e1d47
change-id: 20231218-binderfs-a758e162e0ba

Best regards,
-- 
Tanzir Hasan <tanzirh@google.com>
Re: [PATCH] android: removed asm-generic/errno-base.h
Posted by Christophe JAILLET 1 year, 11 months ago 
Le 26/12/2023 à 18:09, Tanzir Hasan a écrit :
> asm-generic/errno-base.h can be replaced by linux/errno.h and the file
> will still build correctly. It is an asm-generic file which should be
> avoided if possible.
> 
> Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Tanzir Hasan <tanzirh@google.com>
> ---
>   drivers/android/binderfs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
> index 1224ab7aa070..d04ff6029480 100644
> --- a/drivers/android/binderfs.c
> +++ b/drivers/android/binderfs.c
> @@ -29,7 +29,7 @@
>   #include <linux/uaccess.h>
>   #include <linux/user_namespace.h>
>   #include <linux/xarray.h>
> -#include <uapi/asm-generic/errno-base.h>
> +#include <linux/errno.h>

linux/errno.h is already included a few lines above.

CJ

>   #include <uapi/linux/android/binder.h>
>   #include <uapi/linux/android/binderfs.h>
>   
> 
> ---
> base-commit: 606d9c29e71fbf52fcfd3fcc3ad92e444c8e1d47
> change-id: 20231218-binderfs-a758e162e0ba
> 
> Best regards,
Re: [PATCH] android: removed asm-generic/errno-base.h
Posted by Carlos Llamas 1 year, 11 months ago 
On Thu, Jan 04, 2024 at 04:36:00PM +0100, Christophe JAILLET wrote:
> Le 26/12/2023 à 18:09, Tanzir Hasan a écrit :
> > asm-generic/errno-base.h can be replaced by linux/errno.h and the file
> > will still build correctly. It is an asm-generic file which should be
> > avoided if possible.
> > 
> > Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> > Signed-off-by: Tanzir Hasan <tanzirh@google.com>
> > ---
> >   drivers/android/binderfs.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
> > index 1224ab7aa070..d04ff6029480 100644
> > --- a/drivers/android/binderfs.c
> > +++ b/drivers/android/binderfs.c
> > @@ -29,7 +29,7 @@
> >   #include <linux/uaccess.h>
> >   #include <linux/user_namespace.h>
> >   #include <linux/xarray.h>
> > -#include <uapi/asm-generic/errno-base.h>
> > +#include <linux/errno.h>
> 
> linux/errno.h is already included a few lines above.
> 
> CJ
> 

Good catch! Then we should just drop the errno-base.h include.

--
Carlos Llamas
Re: [PATCH] android: removed asm-generic/errno-base.h
Posted by Tanzir Hasan 1 year, 11 months ago 
On Thu, Jan 4, 2024 at 9:18 AM Carlos Llamas <cmllamas@google.com> wrote:
>
> On Thu, Jan 04, 2024 at 04:36:00PM +0100, Christophe JAILLET wrote:
> > Le 26/12/2023 à 18:09, Tanzir Hasan a écrit :
> > > asm-generic/errno-base.h can be replaced by linux/errno.h and the file
> > > will still build correctly. It is an asm-generic file which should be
> > > avoided if possible.
> > >
> > > Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> > > Signed-off-by: Tanzir Hasan <tanzirh@google.com>
> > > ---
> > >   drivers/android/binderfs.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
> > > index 1224ab7aa070..d04ff6029480 100644
> > > --- a/drivers/android/binderfs.c
> > > +++ b/drivers/android/binderfs.c
> > > @@ -29,7 +29,7 @@
> > >   #include <linux/uaccess.h>
> > >   #include <linux/user_namespace.h>
> > >   #include <linux/xarray.h>
> > > -#include <uapi/asm-generic/errno-base.h>
> > > +#include <linux/errno.h>
> >
> > linux/errno.h is already included a few lines above.
> >
> > CJ
> >
>
> Good catch! Then we should just drop the errno-base.h include.
>
> --
> Carlos Llamas

Thanks for bringing that up. I will correct it and just remove the
asm-generic header instead.

Best,
Tanzir
Re: [PATCH] android: removed asm-generic/errno-base.h
Posted by Greg Kroah-Hartman 1 year, 11 months ago 
On Thu, Jan 04, 2024 at 09:32:37AM -0800, Tanzir Hasan wrote:
> On Thu, Jan 4, 2024 at 9:18 AM Carlos Llamas <cmllamas@google.com> wrote:
> >
> > On Thu, Jan 04, 2024 at 04:36:00PM +0100, Christophe JAILLET wrote:
> > > Le 26/12/2023 à 18:09, Tanzir Hasan a écrit :
> > > > asm-generic/errno-base.h can be replaced by linux/errno.h and the file
> > > > will still build correctly. It is an asm-generic file which should be
> > > > avoided if possible.
> > > >
> > > > Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> > > > Signed-off-by: Tanzir Hasan <tanzirh@google.com>
> > > > ---
> > > >   drivers/android/binderfs.c | 2 +-
> > > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
> > > > index 1224ab7aa070..d04ff6029480 100644
> > > > --- a/drivers/android/binderfs.c
> > > > +++ b/drivers/android/binderfs.c
> > > > @@ -29,7 +29,7 @@
> > > >   #include <linux/uaccess.h>
> > > >   #include <linux/user_namespace.h>
> > > >   #include <linux/xarray.h>
> > > > -#include <uapi/asm-generic/errno-base.h>
> > > > +#include <linux/errno.h>
> > >
> > > linux/errno.h is already included a few lines above.
> > >
> > > CJ
> > >
> >
> > Good catch! Then we should just drop the errno-base.h include.
> >
> > --
> > Carlos Llamas
> 
> Thanks for bringing that up. I will correct it and just remove the
> asm-generic header instead.

Please just send a patch removing the duplicate as I have already
applied this one.

thanks,

gre gk-h
Re: [PATCH] android: removed asm-generic/errno-base.h
Posted by Joel Fernandes 1 year, 11 months ago 

On 1/4/2024 10:36 AM, Christophe JAILLET wrote:
> Le 26/12/2023 à 18:09, Tanzir Hasan a écrit :
>> asm-generic/errno-base.h can be replaced by linux/errno.h and the file
>> will still build correctly. It is an asm-generic file which should be
>> avoided if possible.
>>
>> Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
>> Signed-off-by: Tanzir Hasan <tanzirh@google.com>
>> ---
>>   drivers/android/binderfs.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
>> index 1224ab7aa070..d04ff6029480 100644
>> --- a/drivers/android/binderfs.c
>> +++ b/drivers/android/binderfs.c
>> @@ -29,7 +29,7 @@
>>   #include <linux/uaccess.h>
>>   #include <linux/user_namespace.h>
>>   #include <linux/xarray.h>
>> -#include <uapi/asm-generic/errno-base.h>
>> +#include <linux/errno.h>
> 
> linux/errno.h is already included a few lines above.
> 

Good point! With that nit addressed:
Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>

Thanks.
Re: [PATCH] android: removed asm-generic/errno-base.h
Posted by Carlos Llamas 1 year, 11 months ago 
On Tue, Dec 26, 2023 at 05:09:23PM +0000, Tanzir Hasan wrote:
> asm-generic/errno-base.h can be replaced by linux/errno.h and the file
> will still build correctly. It is an asm-generic file which should be
> avoided if possible.
> 
> Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Tanzir Hasan <tanzirh@google.com>
> ---
>  drivers/android/binderfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
> index 1224ab7aa070..d04ff6029480 100644
> --- a/drivers/android/binderfs.c
> +++ b/drivers/android/binderfs.c
> @@ -29,7 +29,7 @@
>  #include <linux/uaccess.h>
>  #include <linux/user_namespace.h>
>  #include <linux/xarray.h>
> -#include <uapi/asm-generic/errno-base.h>
> +#include <linux/errno.h>
>  #include <uapi/linux/android/binder.h>
>  #include <uapi/linux/android/binderfs.h>
>  
> 
> ---
> base-commit: 606d9c29e71fbf52fcfd3fcc3ad92e444c8e1d47
> change-id: 20231218-binderfs-a758e162e0ba
> 
> Best regards,
> -- 
> Tanzir Hasan <tanzirh@google.com>


Acked-by: Carlos Llamas <cmllamas@google.com>

Thanks,
--
Carlos Llamas

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.