[RFC PATCH v2 04/10] igc: remove convert_art_to_tsc()

lakshmi.sowjanya.d@intel.com posted 10 patches 2 years ago
There is a newer version of this series
[RFC PATCH v2 04/10] igc: remove convert_art_to_tsc()
Posted by lakshmi.sowjanya.d@intel.com 2 years ago
From: Thomas Gleixner <tglx@linutronix.de>

Remove convert_art_to_tsc() function call, Pass system clock cycles and
clocksource ID as input to get_device_system_crosststamp().

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com>
---
 drivers/net/ethernet/intel/igc/igc_ptp.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/igc/igc_ptp.c b/drivers/net/ethernet/intel/igc/igc_ptp.c
index 928f38792203..11108eb075bc 100644
--- a/drivers/net/ethernet/intel/igc/igc_ptp.c
+++ b/drivers/net/ethernet/intel/igc/igc_ptp.c
@@ -911,7 +911,11 @@ static bool igc_is_crosststamp_supported(struct igc_adapter *adapter)
 static struct system_counterval_t igc_device_tstamp_to_system(u64 tstamp)
 {
 #if IS_ENABLED(CONFIG_X86_TSC) && !defined(CONFIG_UML)
-	return convert_art_ns_to_tsc(tstamp);
+	return (struct system_counterval_t) {
+		.cs_id    = CSID_X86_ART,
+		.cycles    = tstamp,
+		.nsecs    = true,
+	};
 #else
 	return (struct system_counterval_t) { };
 #endif
-- 
2.35.3
Re: [RFC PATCH v2 04/10] igc: remove convert_art_to_tsc()
Posted by Andy Shevchenko 2 years ago
On Thu, Dec 21, 2023 at 03:02:48PM +0530, lakshmi.sowjanya.d@intel.com wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> Remove convert_art_to_tsc() function call, Pass system clock cycles and
> clocksource ID as input to get_device_system_crosststamp().

...

> +	return (struct system_counterval_t) {
> +		.cs_id    = CSID_X86_ART,
> +		.cycles    = tstamp,
> +		.nsecs    = true,

Either you should remove the extra spaces before '=' or replace them by TAB(s).

> +	};

-- 
With Best Regards,
Andy Shevchenko