Retrieval of soc info is needed. This patch includes the following:
1. Register socinfo device in mtk-efuse.c
Signed-off-by: William-tw Lin <william-tw.lin@mediatek.com>
---
drivers/nvmem/mtk-efuse.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c
index 84f05b40a411..3914e039e288 100644
--- a/drivers/nvmem/mtk-efuse.c
+++ b/drivers/nvmem/mtk-efuse.c
@@ -68,6 +68,7 @@ static int mtk_efuse_probe(struct platform_device *pdev)
struct nvmem_config econfig = {};
struct mtk_efuse_priv *priv;
const struct mtk_efuse_pdata *pdata;
+ struct platform_device *socinfo;
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
if (!priv)
@@ -85,11 +86,19 @@ static int mtk_efuse_probe(struct platform_device *pdev)
econfig.size = resource_size(res);
econfig.priv = priv;
econfig.dev = dev;
+ econfig.name = "mtk-efuse";
if (pdata->uses_post_processing)
econfig.fixup_dt_cell_info = &mtk_efuse_fixup_dt_cell_info;
nvmem = devm_nvmem_register(dev, &econfig);
+ if (IS_ERR(nvmem))
+ return PTR_ERR(nvmem);
- return PTR_ERR_OR_ZERO(nvmem);
+ socinfo = platform_device_register_data(&pdev->dev, "mtk-socinfo",
+ PLATFORM_DEVID_AUTO, NULL, 0);
+ if (IS_ERR(socinfo))
+ dev_info(dev, "MediaTek SoC Information will be unavailable\n");
+
+ return 0;
}
static const struct mtk_efuse_pdata mtk_mt8186_efuse_pdata = {
--
2.18.0
Il 20/12/23 11:39, William-tw Lin ha scritto: > Retrieval of soc info is needed. This patch includes the following: > 1. Register socinfo device in mtk-efuse.c > nvmem: mtk-efuse: Register MediaTek socinfo driver from efuse The socinfo driver reads chip information from eFuses and does not need any devicetree node. Register it from mtk-efuse. While at it, also add the name for this driver's nvmem_config. ^^^ that's a proper commit title and description :-) > Signed-off-by: William-tw Lin <william-tw.lin@mediatek.com> > --- > drivers/nvmem/mtk-efuse.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/nvmem/mtk-efuse.c b/drivers/nvmem/mtk-efuse.c > index 84f05b40a411..3914e039e288 100644 > --- a/drivers/nvmem/mtk-efuse.c > +++ b/drivers/nvmem/mtk-efuse.c > @@ -68,6 +68,7 @@ static int mtk_efuse_probe(struct platform_device *pdev) > struct nvmem_config econfig = {}; > struct mtk_efuse_priv *priv; > const struct mtk_efuse_pdata *pdata; > + struct platform_device *socinfo; > > priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > if (!priv) > @@ -85,11 +86,19 @@ static int mtk_efuse_probe(struct platform_device *pdev) > econfig.size = resource_size(res); > econfig.priv = priv; > econfig.dev = dev; > + econfig.name = "mtk-efuse"; > if (pdata->uses_post_processing) > econfig.fixup_dt_cell_info = &mtk_efuse_fixup_dt_cell_info; > nvmem = devm_nvmem_register(dev, &econfig); > + if (IS_ERR(nvmem)) > + return PTR_ERR(nvmem); > > - return PTR_ERR_OR_ZERO(nvmem); > + socinfo = platform_device_register_data(&pdev->dev, "mtk-socinfo", > + PLATFORM_DEVID_AUTO, NULL, 0); > + if (IS_ERR(socinfo)) > + dev_info(dev, "MediaTek SoC Information will be unavailable\n"); > + if (IS_ERR(socinfo)) dev_info(dev, "MediaTek SoC Information will be unavailable\n"); platform_set_drvdata(pdev, socinfo); return 0; > + return 0; > } > > static const struct mtk_efuse_pdata mtk_mt8186_efuse_pdata = { static void mtk_efuse_remove(struct platform_device *pdev) { struct platform_device *socinfo = platform_get_drvdata(pdev); if (!IS_ERR_OR_NULL(socinfo)) platform_device_unregister(socinfo); } static struct platform_driver mtk_efuse_driver = { .probe = mtk_efuse_probe, .remove_new = mtk_efuse_remove, <---- add this .driver = { .name = "mediatek,efuse", .of_match_table = mtk_efuse_of_match, } }; After those additions, it's good for me. Thanks, Angelo
© 2016 - 2024 Red Hat, Inc.