[v3] mm: fix arithmetic for bdi min_ratio and max_ratio

[PATCH v3 0/2] mm: fix arithmetic for bdi min_ratio and max_ratio

Posted by Jingbo Xu 1 year, 12 months ago

changes since v2:
- patch 2: drop div64_u64(), instead write it out mathematically
  (Matthew Wilcox)

changes since v1:
- split the previous v1 patch into two separate patches with
  corresponding "Fixes" tag (Andrew Morton)
- patch 2: remove "UL" suffix for the "100" constant

v1: https://lore.kernel.org/all/20231218031640.77983-1-jefflexu@linux.alibaba.com/
v2: https://lore.kernel.org/all/20231219024246.65654-1-jefflexu@linux.alibaba.com/

Jingbo Xu (2):
  mm: fix arithmetic for bdi min_ratio
  mm: fix arithmetic for max_prop_frac when setting max_ratio

 mm/page-writeback.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.19.1.6.gb485710b

Re: [PATCH v3 0/2] mm: fix arithmetic for bdi min_ratio and max_ratio

Posted by Stefan Roesch 1 year, 12 months ago

It would be good if the cover letter describes what this fixes.

On Tue, Dec 19, 2023, at 6:25 AM, Jingbo Xu wrote:
> changes since v2:
> - patch 2: drop div64_u64(), instead write it out mathematically
>   (Matthew Wilcox)
>
> changes since v1:
> - split the previous v1 patch into two separate patches with
>   corresponding "Fixes" tag (Andrew Morton)
> - patch 2: remove "UL" suffix for the "100" constant
>
> v1: 
> https://lore.kernel.org/all/20231218031640.77983-1-jefflexu@linux.alibaba.com/
> v2: 
> https://lore.kernel.org/all/20231219024246.65654-1-jefflexu@linux.alibaba.com/
>
> Jingbo Xu (2):
>   mm: fix arithmetic for bdi min_ratio
>   mm: fix arithmetic for max_prop_frac when setting max_ratio
>
>  mm/page-writeback.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> -- 
> 2.19.1.6.gb485710b

Re: [PATCH v3 0/2] mm: fix arithmetic for bdi min_ratio and max_ratio

Posted by Jingbo Xu 1 year, 12 months ago


On 12/20/23 1:56 AM, Stefan Roesch wrote:
> It would be good if the cover letter describes what this fixes.

Thanks. Would notice that next time :)

> 
> On Tue, Dec 19, 2023, at 6:25 AM, Jingbo Xu wrote:
>> changes since v2:
>> - patch 2: drop div64_u64(), instead write it out mathematically
>>   (Matthew Wilcox)
>>
>> changes since v1:
>> - split the previous v1 patch into two separate patches with
>>   corresponding "Fixes" tag (Andrew Morton)
>> - patch 2: remove "UL" suffix for the "100" constant
>>
>> v1: 
>> https://lore.kernel.org/all/20231218031640.77983-1-jefflexu@linux.alibaba.com/
>> v2: 
>> https://lore.kernel.org/all/20231219024246.65654-1-jefflexu@linux.alibaba.com/
>>
>> Jingbo Xu (2):
>>   mm: fix arithmetic for bdi min_ratio
>>   mm: fix arithmetic for max_prop_frac when setting max_ratio
>>
>>  mm/page-writeback.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> -- 
>> 2.19.1.6.gb485710b

-- 
Thanks,
Jingbo