[PATCH] Docs/zh_CN: Fix the meaning of DEBUG to pr_debug()

JiaLong.Yang posted 1 patch 2 years ago
There is a newer version of this series
Documentation/translations/zh_CN/core-api/printk-basics.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] Docs/zh_CN: Fix the meaning of DEBUG to pr_debug()
Posted by JiaLong.Yang 2 years ago
Signed-off-by: JiaLong.Yang <jialong.yang@shingroup.cn>
---
 Documentation/translations/zh_CN/core-api/printk-basics.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/translations/zh_CN/core-api/printk-basics.rst b/Documentation/translations/zh_CN/core-api/printk-basics.rst
index 59c6efb3fc41..cafa01bccff2 100644
--- a/Documentation/translations/zh_CN/core-api/printk-basics.rst
+++ b/Documentation/translations/zh_CN/core-api/printk-basics.rst
@@ -100,7 +100,7 @@ printk()的用法通常是这样的::
 
 为了调试,还有两个有条件编译的宏:
 pr_debug()和pr_devel(),除非定义了 ``DEBUG`` (或者在pr_debug()的情况下定义了
-``CONFIG_DYNAMIC_DEBUG`` ),否则它们会被编译。
+``CONFIG_DYNAMIC_DEBUG`` ),否则它们不会被编译。
 
 
 函数接口
-- 
2.25.1

Re: [PATCH] Docs/zh_CN: Fix the meaning of DEBUG to pr_debug()
Posted by Jonathan Corbet 2 years ago
"JiaLong.Yang" <jialong.yang@shingroup.cn> writes:

> Signed-off-by: JiaLong.Yang <jialong.yang@shingroup.cn>
> ---
>  Documentation/translations/zh_CN/core-api/printk-basics.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/translations/zh_CN/core-api/printk-basics.rst b/Documentation/translations/zh_CN/core-api/printk-basics.rst
> index 59c6efb3fc41..cafa01bccff2 100644
> --- a/Documentation/translations/zh_CN/core-api/printk-basics.rst
> +++ b/Documentation/translations/zh_CN/core-api/printk-basics.rst
> @@ -100,7 +100,7 @@ printk()的用法通常是这样的::
>  
>  为了调试,还有两个有条件编译的宏:
>  pr_debug()和pr_devel(),除非定义了 ``DEBUG`` (或者在pr_debug()的情况下定义了
> -``CONFIG_DYNAMIC_DEBUG`` ),否则它们会被编译。
> +``CONFIG_DYNAMIC_DEBUG`` ),否则它们不会被编译。
>  

This patch needs an actual changelog.  Being illiterate in Chinese, I
can't make any connection between the subject line and what has actually
been done here.

Thanks,

jon
Re: [PATCH] Docs/zh_CN: Fix the meaning of DEBUG to pr_debug()
Posted by Yanteng Si 2 years ago
Hi JiaLong,

在 2023/12/19 22:43, Jonathan Corbet 写道:
> "JiaLong.Yang" <jialong.yang@shingroup.cn> writes:
>
>> Signed-off-by: JiaLong.Yang <jialong.yang@shingroup.cn>
>> ---
>>   Documentation/translations/zh_CN/core-api/printk-basics.rst | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/translations/zh_CN/core-api/printk-basics.rst b/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> index 59c6efb3fc41..cafa01bccff2 100644
>> --- a/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> +++ b/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> @@ -100,7 +100,7 @@ printk()的用法通常是这样的::
>>   
>>   为了调试,还有两个有条件编译的宏:
>>   pr_debug()和pr_devel(),除非定义了 ``DEBUG`` (或者在pr_debug()的情况下定义了
>> -``CONFIG_DYNAMIC_DEBUG`` ),否则它们会被编译。
>> +``CONFIG_DYNAMIC_DEBUG`` ),否则它们不会被编译。
>>   
> This patch needs an actual changelog.  Being illiterate in Chinese, I
> can't make any connection between the subject line and what has actually
> been done here.

As jon said, could you please write a commit message?

For details see: .../Documentation/translations/zh_CN/process/5.Posting.rst


Thanks,

Yanteng

>
> Thanks,
>
> jon

Re: [PATCH] Docs/zh_CN: Fix the meaning of DEBUG to pr_debug()
Posted by Zenghui Yu 2 years ago
On 2023/12/19 22:43, Jonathan Corbet wrote:
> "JiaLong.Yang" <jialong.yang@shingroup.cn> writes:
> 
>> Signed-off-by: JiaLong.Yang <jialong.yang@shingroup.cn>
>> ---
>>  Documentation/translations/zh_CN/core-api/printk-basics.rst | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/translations/zh_CN/core-api/printk-basics.rst b/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> index 59c6efb3fc41..cafa01bccff2 100644
>> --- a/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> +++ b/Documentation/translations/zh_CN/core-api/printk-basics.rst
>> @@ -100,7 +100,7 @@ printk()的用法通常是这样的::
>>  
>>  为了调试,还有两个有条件编译的宏:
>>  pr_debug()和pr_devel(),除非定义了 ``DEBUG`` (或者在pr_debug()的情况下定义了
>> -``CONFIG_DYNAMIC_DEBUG`` ),否则它们会被编译。
>> +``CONFIG_DYNAMIC_DEBUG`` ),否则它们不会被编译。
>>  
> 
> This patch needs an actual changelog.  Being illiterate in Chinese, I
> can't make any connection between the subject line and what has actually
> been done here.

Agreed. The change itself looks correct though, feel free to add my

Reviewed-by: Zenghui Yu <zenghui.yu@linux.dev>

in your next revision (with Jon's suggestion addressed).

Thanks,
Zenghui