arm64: dts: qcom: sm8550: remove

[PATCH v3 0/1] arm64: dts: qcom: sm8550: remove

Posted by Tengfei Fan 2 years ago

The address/size-cells in mdss_dsi1 node have not ranges and child also
have not reg, then this leads to dtc W=1 warnings:

  sm8550.dtsi:2937.27-2992.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae96000:
    unnecessary #address-cells/#size-cells without "ranges" or child "reg" property

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---

v2 -> v3:
  - separate this patch from other patch series
v1 -> v2:
  - add reviewed-by tage due to patch review done

previous discussion here:
[1] v2: https://lore.kernel.org/linux-arm-msm/20231207092801.7506-4-quic_tengfan@quicinc.com
[2] v1: https://lore.kernel.org/linux-arm-msm/20231117101817.4401-6-quic_tengfan@quicinc.com

Tengfei Fan (1):
  arm64: dts: qcom: sm8550: remove address/size-cells from mdss_dsi1

 arch/arm64/boot/dts/qcom/sm8550.dtsi | 3 ---
 1 file changed, 3 deletions(-)


base-commit: ceb2fe0d438644e1de06b9a6468a1fb8e2199c70
-- 
2.17.1

Re: (subset) [PATCH v3 0/1] arm64: dts: qcom: sm8550: remove

Posted by Bjorn Andersson 1 year, 12 months ago

On Tue, 19 Dec 2023 08:31:05 +0800, Tengfei Fan wrote:
> The address/size-cells in mdss_dsi1 node have not ranges and child also
> have not reg, then this leads to dtc W=1 warnings:
> 
>   sm8550.dtsi:2937.27-2992.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae96000:
>     unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
> 
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: sm8550: remove address/size-cells from mdss_dsi1
      commit: 53081095936cdb1501d6bcf6cb703fdd3ac71b85

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: (subset) [PATCH v3 0/1] arm64: dts: qcom: sm8550: remove

Posted by Bjorn Andersson 1 year, 12 months ago

On Tue, Dec 19, 2023 at 01:33:37PM -0600, Bjorn Andersson wrote:
> 
> On Tue, 19 Dec 2023 08:31:05 +0800, Tengfei Fan wrote:
> > The address/size-cells in mdss_dsi1 node have not ranges and child also
> > have not reg, then this leads to dtc W=1 warnings:
> > 
> >   sm8550.dtsi:2937.27-2992.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae96000:
> >     unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
> > 
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/1] arm64: dts: qcom: sm8550: remove address/size-cells from mdss_dsi1
>       commit: 53081095936cdb1501d6bcf6cb703fdd3ac71b85
> 

Sorry, I thought this was removed from my queue again. I've dropped the
patch again. Please address Krzysztof's concerns.

Regards,
Bjorn

> Best regards,
> -- 
> Bjorn Andersson <andersson@kernel.org>
>

Re: (subset) [PATCH v3 0/1] arm64: dts: qcom: sm8550: remove

Posted by Dmitry Baryshkov 1 year, 12 months ago

On Tue, 19 Dec 2023 at 21:36, Bjorn Andersson <andersson@kernel.org> wrote:
>
>
> On Tue, 19 Dec 2023 08:31:05 +0800, Tengfei Fan wrote:
> > The address/size-cells in mdss_dsi1 node have not ranges and child also
> > have not reg, then this leads to dtc W=1 warnings:
> >
> >   sm8550.dtsi:2937.27-2992.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae96000:
> >     unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
> >
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] arm64: dts: qcom: sm8550: remove address/size-cells from mdss_dsi1
>       commit: 53081095936cdb1501d6bcf6cb703fdd3ac71b85

Bjorn, but there was a NAK If I remember correctly.


--
With best wishes
Dmitry

Re: (subset) [PATCH v3 0/1] arm64: dts: qcom: sm8550: remove

Posted by Krzysztof Kozlowski 1 year, 12 months ago

On 19/12/2023 20:33, Bjorn Andersson wrote:
> 
> On Tue, 19 Dec 2023 08:31:05 +0800, Tengfei Fan wrote:
>> The address/size-cells in mdss_dsi1 node have not ranges and child also
>> have not reg, then this leads to dtc W=1 warnings:
>>
>>   sm8550.dtsi:2937.27-2992.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae96000:
>>     unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>>
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/1] arm64: dts: qcom: sm8550: remove address/size-cells from mdss_dsi1
>       commit: 53081095936cdb1501d6bcf6cb703fdd3ac71b85

?!? I explicitly disagreed with this patch here and in the previous thread!

Best regards,
Krzysztof

Re: (subset) [PATCH v3 0/1] arm64: dts: qcom: sm8550: remove

Posted by Aiqun Yu (Maria) 1 year, 12 months ago


On 12/20/2023 3:33 AM, Bjorn Andersson wrote:
> 
> On Tue, 19 Dec 2023 08:31:05 +0800, Tengfei Fan wrote:
>> The address/size-cells in mdss_dsi1 node have not ranges and child also
>> have not reg, then this leads to dtc W=1 warnings:
>>
>>    sm8550.dtsi:2937.27-2992.6: Warning (avoid_unnecessary_addr_size): /soc@0/display-subsystem@ae00000/dsi@ae96000:
>>      unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>>
>>
>> [...]
> 
> Applied, thanks!
Hi Bjorn,

Discussion is still on going.
Dmitry dropped the previous review-by.
> 
> [1/1] arm64: dts: qcom: sm8550: remove address/size-cells from mdss_dsi1
>        commit: 53081095936cdb1501d6bcf6cb703fdd3ac71b85
> 
> Best regards,

-- 
Thx and BRs,
Aiqun(Maria) Yu