[v2] gpiolib: cleanup for duplicated including

[PATCH v2] gpiolib: cleanup for duplicated including

Posted by Wang Jinchao 2 years ago

Remove second `#include <linux/err.h>`.
Remove `#include <asm/errno.h>`.
As they are guaranteed by the global `err.h`.

Signed-off-by: Wang Jinchao <wangjinchao@xfusion.com>
---
V2:
    Revise the comment per Andy's suggestion.
V1: https://lore.kernel.org/all/202312151645+0800-wangjinchao@xfusion.com/

 include/linux/gpio/driver.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index 0aed62f0c633..df6857e579a1 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -701,7 +701,6 @@ int gpiochip_irqchip_add_domain(struct gpio_chip *gc,
 #else
 
 #include <asm/bug.h>
-#include <asm/errno.h>
 
 static inline int gpiochip_irqchip_add_domain(struct gpio_chip *gc,
 					      struct irq_domain *domain)
@@ -789,8 +788,6 @@ int gpio_device_get_base(struct gpio_device *gdev);
 
 #else /* CONFIG_GPIOLIB */
 
-#include <linux/err.h>
-
 #include <asm/bug.h>
 
 static inline struct gpio_chip *gpiod_to_chip(const struct gpio_desc *desc)
-- 
2.40.0

Re: [PATCH v2] gpiolib: cleanup for duplicated including

Posted by Bartosz Golaszewski 2 years ago

On Mon, Dec 18, 2023 at 8:16 AM Wang Jinchao <wangjinchao@xfusion.com> wrote:
>
> Remove second `#include <linux/err.h>`.
> Remove `#include <asm/errno.h>`.
> As they are guaranteed by the global `err.h`.
>
> Signed-off-by: Wang Jinchao <wangjinchao@xfusion.com>
> ---
> V2:
>     Revise the comment per Andy's suggestion.
> V1: https://lore.kernel.org/all/202312151645+0800-wangjinchao@xfusion.com/
>
>  include/linux/gpio/driver.h | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
> index 0aed62f0c633..df6857e579a1 100644
> --- a/include/linux/gpio/driver.h
> +++ b/include/linux/gpio/driver.h
> @@ -701,7 +701,6 @@ int gpiochip_irqchip_add_domain(struct gpio_chip *gc,
>  #else
>
>  #include <asm/bug.h>
> -#include <asm/errno.h>
>
>  static inline int gpiochip_irqchip_add_domain(struct gpio_chip *gc,
>                                               struct irq_domain *domain)
> @@ -789,8 +788,6 @@ int gpio_device_get_base(struct gpio_device *gdev);
>
>  #else /* CONFIG_GPIOLIB */
>
> -#include <linux/err.h>
> -
>  #include <asm/bug.h>
>
>  static inline struct gpio_chip *gpiod_to_chip(const struct gpio_desc *desc)
> --
> 2.40.0
>

Applied, thanks!

Bart