[PATCH v5 RESEND 5/5] dm-crypt: Fix lost ioprio when queuing write bios

Hongyu Jin posted 5 patches 2 years ago
There is a newer version of this series
[PATCH v5 RESEND 5/5] dm-crypt: Fix lost ioprio when queuing write bios
Posted by Hongyu Jin 2 years ago
From: Hongyu Jin <hongyu.jin@unisoc.com>

The original submitting bio->bi_ioprio setting can be retained by
struct dm_crypt_io::base_bio, we set the original bio's ioprio to
the cloned bio for write.

Link: https://lore.kernel.org/dm-devel/alpine.LRH.2.11.1612141049250.13402@mail.ewheeler.net

Signed-off-by: Hongyu Jin <hongyu.jin@unisoc.com>
---
 drivers/md/dm-crypt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c
index 6de107aff331..7149da6555b8 100644
--- a/drivers/md/dm-crypt.c
+++ b/drivers/md/dm-crypt.c
@@ -1683,6 +1683,7 @@ static struct bio *crypt_alloc_buffer(struct dm_crypt_io *io, unsigned int size)
 				 GFP_NOIO, &cc->bs);
 	clone->bi_private = io;
 	clone->bi_end_io = crypt_endio;
+	clone->bi_ioprio = io->base_bio->bi_ioprio;
 
 	remaining_size = size;
 
-- 
2.34.1
Re: [PATCH v5 RESEND 5/5] dm-crypt: Fix lost ioprio when queuing write bios
Posted by Eric Biggers 1 year, 12 months ago
On Mon, Dec 18, 2023 at 09:27:46AM +0800, Hongyu Jin wrote:
> From: Hongyu Jin <hongyu.jin@unisoc.com>
> 
> The original submitting bio->bi_ioprio setting can be retained by
> struct dm_crypt_io::base_bio, we set the original bio's ioprio to
> the cloned bio for write.

This commit message does not make sense.  Can you make the commit message
properly describe the problem and how the patch fixes it?

- Eric