[PATCH v1 0/2] bitmap-str: A couple of fixes

Andy Shevchenko posted 2 patches 2 years ago
include/linux/bitmap-str.h | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
[PATCH v1 0/2] bitmap-str: A couple of fixes
Posted by Andy Shevchenko 2 years ago
Imtended to be folded into original code, hence no proper commit messages.

Andy Shevchenko (2):
  bitmap-str: Get rid of extern
  bitmap-str: Add missing header(s)

 include/linux/bitmap-str.h | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

-- 
2.43.0.rc1.1.gbec44491f096
Re: [PATCH v1 0/2] bitmap-str: A couple of fixes
Posted by Yury Norov 2 years ago
On Fri, Dec 15, 2023 at 08:41:07PM +0200, Andy Shevchenko wrote:
> Imtended to be folded into original code, hence no proper commit messages.

s/Imtended/Intended

Didn't understand why you didn't write commit messages. It breaks the
very basic rule. Can you elaborate?

> Andy Shevchenko (2):
>   bitmap-str: Get rid of extern
>   bitmap-str: Add missing header(s)
> 
>  include/linux/bitmap-str.h | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> -- 
> 2.43.0.rc1.1.gbec44491f096
Re: [PATCH v1 0/2] bitmap-str: A couple of fixes
Posted by Andy Shevchenko 2 years ago
On Fri, Dec 15, 2023 at 11:01:12AM -0800, Yury Norov wrote:
> On Fri, Dec 15, 2023 at 08:41:07PM +0200, Andy Shevchenko wrote:
> > Imtended to be folded into original code, hence no proper commit messages.
> 
> s/Imtended/Intended
> 
> Didn't understand why you didn't write commit messages. It breaks the
> very basic rule. Can you elaborate?

I expected you to rebase your original commit.
Or based on my understanding of your comments I can submit a revert, if you wish.

-- 
With Best Regards,
Andy Shevchenko
Re: [PATCH v1 0/2] bitmap-str: A couple of fixes
Posted by Yury Norov 2 years ago
On Fri, Dec 15, 2023 at 09:14:19PM +0200, Andy Shevchenko wrote:
> On Fri, Dec 15, 2023 at 11:01:12AM -0800, Yury Norov wrote:
> > On Fri, Dec 15, 2023 at 08:41:07PM +0200, Andy Shevchenko wrote:
> > > Imtended to be folded into original code, hence no proper commit messages.
> > 
> > s/Imtended/Intended
> > 
> > Didn't understand why you didn't write commit messages. It breaks the
> > very basic rule. Can you elaborate?
> 
> I expected you to rebase your original commit.
> Or based on my understanding of your comments I can submit a revert, if you wish.
 
It's merged in v6.7-rc1. Can you send #1 as a proper patch? Regarding #2,
it's not needed because bitmap-str.h is a local header for bitmap.h.

Thanks,
        Yury