[PATCH] gpio: xilinx: remove excess kernel doc

Bartosz Golaszewski posted 1 patch 2 years ago
drivers/gpio/gpio-xilinx.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] gpio: xilinx: remove excess kernel doc
Posted by Bartosz Golaszewski 2 years ago
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

The irqchip field has been removed from struct xgpio_instance so remove
the doc as well.

Fixes: b4510f8fd5d0 ("gpio: xilinx: Convert to immutable irq_chip")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202312150239.IyuTVvrL-lkp@intel.com/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/gpio/gpio-xilinx.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
index 823198368250..7348df385198 100644
--- a/drivers/gpio/gpio-xilinx.c
+++ b/drivers/gpio/gpio-xilinx.c
@@ -52,7 +52,6 @@
  * @dir: GPIO direction shadow register
  * @gpio_lock: Lock used for synchronization
  * @irq: IRQ used by GPIO device
- * @irqchip: IRQ chip
  * @enable: GPIO IRQ enable/disable bitfield
  * @rising_edge: GPIO IRQ rising edge enable/disable bitfield
  * @falling_edge: GPIO IRQ falling edge enable/disable bitfield
-- 
2.40.1
Re: [PATCH] gpio: xilinx: remove excess kernel doc
Posted by Bartosz Golaszewski 2 years ago
On Fri, Dec 15, 2023 at 10:09 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The irqchip field has been removed from struct xgpio_instance so remove
> the doc as well.
>
> Fixes: b4510f8fd5d0 ("gpio: xilinx: Convert to immutable irq_chip")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202312150239.IyuTVvrL-lkp@intel.com/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
>  drivers/gpio/gpio-xilinx.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index 823198368250..7348df385198 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -52,7 +52,6 @@
>   * @dir: GPIO direction shadow register
>   * @gpio_lock: Lock used for synchronization
>   * @irq: IRQ used by GPIO device
> - * @irqchip: IRQ chip
>   * @enable: GPIO IRQ enable/disable bitfield
>   * @rising_edge: GPIO IRQ rising edge enable/disable bitfield
>   * @falling_edge: GPIO IRQ falling edge enable/disable bitfield
> --
> 2.40.1
>

Patch applied.

Bart
Re: [PATCH] gpio: xilinx: remove excess kernel doc
Posted by Randy Dunlap 2 years ago

On 12/15/23 01:09, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> The irqchip field has been removed from struct xgpio_instance so remove
> the doc as well.
> 
> Fixes: b4510f8fd5d0 ("gpio: xilinx: Convert to immutable irq_chip")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202312150239.IyuTVvrL-lkp@intel.com/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  drivers/gpio/gpio-xilinx.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index 823198368250..7348df385198 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -52,7 +52,6 @@
>   * @dir: GPIO direction shadow register
>   * @gpio_lock: Lock used for synchronization
>   * @irq: IRQ used by GPIO device
> - * @irqchip: IRQ chip
>   * @enable: GPIO IRQ enable/disable bitfield
>   * @rising_edge: GPIO IRQ rising edge enable/disable bitfield
>   * @falling_edge: GPIO IRQ falling edge enable/disable bitfield

-- 
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html
Re: [PATCH] gpio: xilinx: remove excess kernel doc
Posted by Michal Simek 2 years ago

On 12/15/23 10:09, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> The irqchip field has been removed from struct xgpio_instance so remove
> the doc as well.
> 
> Fixes: b4510f8fd5d0 ("gpio: xilinx: Convert to immutable irq_chip")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202312150239.IyuTVvrL-lkp@intel.com/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
>   drivers/gpio/gpio-xilinx.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index 823198368250..7348df385198 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -52,7 +52,6 @@
>    * @dir: GPIO direction shadow register
>    * @gpio_lock: Lock used for synchronization
>    * @irq: IRQ used by GPIO device
> - * @irqchip: IRQ chip
>    * @enable: GPIO IRQ enable/disable bitfield
>    * @rising_edge: GPIO IRQ rising edge enable/disable bitfield
>    * @falling_edge: GPIO IRQ falling edge enable/disable bitfield

Interesting because kernel-doc is not reporting any issue but issue is there.

Reviewed-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal