[PATCH V2 2/4] dt-bindings: imx6q-pcie: Add wake-gpios property

Sherry Sun posted 4 patches 2 years ago
[PATCH V2 2/4] dt-bindings: imx6q-pcie: Add wake-gpios property
Posted by Sherry Sun 2 years ago
Add wake-gpios property that can be used to wakeup the host
processor.

Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>
---
 Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
index 81bbb8728f0f..fba757d937e1 100644
--- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
@@ -72,6 +72,12 @@ properties:
       L=operation state) (optional required).
     type: boolean
 
+  wake-gpios:
+    description: If present this property specifies WAKE# sideband signaling
+      to implement wakeup functionality. This is an input GPIO pin for the Root
+      Port mode here. Host drivers will wakeup the host using the IRQ
+      corresponding to the passed GPIO.
+
 required:
   - compatible
   - reg
-- 
2.34.1
Re: [PATCH V2 2/4] dt-bindings: imx6q-pcie: Add wake-gpios property
Posted by Francesco Dolcini 8 months, 2 weeks ago
Hello

On Wed, Dec 13, 2023 at 05:28:48PM +0800, Sherry Sun wrote:
> Add wake-gpios property that can be used to wakeup the host
> processor.
> 
> Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
> Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>
> ---
>  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> index 81bbb8728f0f..fba757d937e1 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> @@ -72,6 +72,12 @@ properties:
>        L=operation state) (optional required).
>      type: boolean
>  
> +  wake-gpios:
> +    description: If present this property specifies WAKE# sideband signaling
> +      to implement wakeup functionality. This is an input GPIO pin for the Root
> +      Port mode here. Host drivers will wakeup the host using the IRQ
> +      corresponding to the passed GPIO.
> +

From what I know it is possible to share the same WAKE# signal for
multiple root ports. Is this going to work fine with this binding? Same
question on the driver.

We do have design exactly like that, so it's not a theoretical question.

Francesco