[PATCH v4 00/17] Support IGT in display driver

Hsiao Chien Sung posted 17 patches 11 months ago
There is a newer version of this series
.../display/mediatek/mediatek,ovl.yaml        |  12 +-
drivers/gpu/drm/mediatek/mtk_disp_drv.h       |   7 +
drivers/gpu/drm/mediatek/mtk_disp_ovl.c       | 326 +++++++++++++++---
.../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c   |  32 +-
drivers/gpu/drm/mediatek/mtk_drm_crtc.c       | 261 +++++++++++++-
drivers/gpu/drm/mediatek/mtk_drm_crtc.h       |  39 +++
drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c   |   7 +
drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h   |  35 ++
drivers/gpu/drm/mediatek/mtk_drm_drv.c        |  30 +-
drivers/gpu/drm/mediatek/mtk_drm_drv.h        |  16 +
drivers/gpu/drm/mediatek/mtk_drm_plane.c      |  15 +-
drivers/gpu/drm/mediatek/mtk_ethdr.c          | 106 +++++-
drivers/gpu/drm/mediatek/mtk_ethdr.h          |   5 +
drivers/soc/mediatek/mtk-mmsys.c              |   1 +
include/linux/soc/mediatek/mtk-cmdq.h         |  10 +
15 files changed, 834 insertions(+), 68 deletions(-)
[PATCH v4 00/17] Support IGT in display driver
Posted by Hsiao Chien Sung 11 months ago
This series is based on mediatek-drm-next.

This series adds support for running IGT (Intel GPU Tool) tests
with MediaTek display driver. The following changes will be
applied:

1. Add a new API for creating GCE thread loop to retrieve CRCs
   from the hardware component
2. Support hardware CRC calculation in both VDOSYS0 and VDOSYS1
3. Support alpha blending in both VDOSYS0 and VDOSYS1

Changes in v4:
- Seperate the patch into smaller ones
- Change the title of some patches
- Revert the changes that are not related to the series

Changes in v3:
- Modify the dt-binding document of Mediatek OVL
- Set DRM mode configs accroding to the hardware capabilities
- Replace cmdq_pkt_jump_absolute() with cmdq_pkt_jump()

Changes in v2:
- Simplify CMDQ by adding commands that are currently used only
- Integrate CRC related codes into new APIs for Mixer and OVL to reuse
- Add CPU version CRC retrieval when CMDQ is disabled

Hsiao Chien Sung (17):
  soc: mediatek: Add register definitions for GCE
  soc: mediatek: Disable 9-bit alpha in ETHDR
  dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188
  drm/mediatek: Add OVL compatible name for MT8195
  drm/mediatek: Set DRM mode configs accordingly
  drm/mediatek: Support alpha blending in OVL
  drm/mediatek: Support alpha blending in Mixer
  drm/mediatek: Support alpha blending in display driver
  drm/mediatek: Support CSC in OVL
  drm/mediatek: Support more color formats in OVL
  drm/mediatek: Turn off the layers with zero width or height
  drm/mediatek: Support CRC in display driver
  drm/mediatek: Support CRC in OVL
  drm/mediatek: Support CRC in OVL adaptor
  drm/mediatek: Add missing plane settings when async update
  drm/mediatek: Fix errors when reporting rotation capability
  drm/mediatek: Add comments for the structures

 .../display/mediatek/mediatek,ovl.yaml        |  12 +-
 drivers/gpu/drm/mediatek/mtk_disp_drv.h       |   7 +
 drivers/gpu/drm/mediatek/mtk_disp_ovl.c       | 326 +++++++++++++++---
 .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c   |  32 +-
 drivers/gpu/drm/mediatek/mtk_drm_crtc.c       | 261 +++++++++++++-
 drivers/gpu/drm/mediatek/mtk_drm_crtc.h       |  39 +++
 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c   |   7 +
 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h   |  35 ++
 drivers/gpu/drm/mediatek/mtk_drm_drv.c        |  30 +-
 drivers/gpu/drm/mediatek/mtk_drm_drv.h        |  16 +
 drivers/gpu/drm/mediatek/mtk_drm_plane.c      |  15 +-
 drivers/gpu/drm/mediatek/mtk_ethdr.c          | 106 +++++-
 drivers/gpu/drm/mediatek/mtk_ethdr.h          |   5 +
 drivers/soc/mediatek/mtk-mmsys.c              |   1 +
 include/linux/soc/mediatek/mtk-cmdq.h         |  10 +
 15 files changed, 834 insertions(+), 68 deletions(-)

--
2.18.0
Re: [PATCH v4 00/17] Support IGT in display driver
Posted by AngeloGioacchino Del Regno 9 months, 2 weeks ago
Il 12/12/23 13:19, Hsiao Chien Sung ha scritto:
> This series is based on mediatek-drm-next.
> 
> This series adds support for running IGT (Intel GPU Tool) tests
> with MediaTek display driver. The following changes will be
> applied:
> 
> 1. Add a new API for creating GCE thread loop to retrieve CRCs
>     from the hardware component
> 2. Support hardware CRC calculation in both VDOSYS0 and VDOSYS1
> 3. Support alpha blending in both VDOSYS0 and VDOSYS1
> 

Hello,
is there still interest in upstreaming this?

We're interested in enabling more comprehensive IGT tests on MediaTek SoCs
and this series is definitely useful.

Regards,
Angelo

> Changes in v4:
> - Seperate the patch into smaller ones
> - Change the title of some patches
> - Revert the changes that are not related to the series
> 
> Changes in v3:
> - Modify the dt-binding document of Mediatek OVL
> - Set DRM mode configs accroding to the hardware capabilities
> - Replace cmdq_pkt_jump_absolute() with cmdq_pkt_jump()
> 
> Changes in v2:
> - Simplify CMDQ by adding commands that are currently used only
> - Integrate CRC related codes into new APIs for Mixer and OVL to reuse
> - Add CPU version CRC retrieval when CMDQ is disabled
> 
> Hsiao Chien Sung (17):
>    soc: mediatek: Add register definitions for GCE
>    soc: mediatek: Disable 9-bit alpha in ETHDR
>    dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188
>    drm/mediatek: Add OVL compatible name for MT8195
>    drm/mediatek: Set DRM mode configs accordingly
>    drm/mediatek: Support alpha blending in OVL
>    drm/mediatek: Support alpha blending in Mixer
>    drm/mediatek: Support alpha blending in display driver
>    drm/mediatek: Support CSC in OVL
>    drm/mediatek: Support more color formats in OVL
>    drm/mediatek: Turn off the layers with zero width or height
>    drm/mediatek: Support CRC in display driver
>    drm/mediatek: Support CRC in OVL
>    drm/mediatek: Support CRC in OVL adaptor
>    drm/mediatek: Add missing plane settings when async update
>    drm/mediatek: Fix errors when reporting rotation capability
>    drm/mediatek: Add comments for the structures
> 
>   .../display/mediatek/mediatek,ovl.yaml        |  12 +-
>   drivers/gpu/drm/mediatek/mtk_disp_drv.h       |   7 +
>   drivers/gpu/drm/mediatek/mtk_disp_ovl.c       | 326 +++++++++++++++---
>   .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c   |  32 +-
>   drivers/gpu/drm/mediatek/mtk_drm_crtc.c       | 261 +++++++++++++-
>   drivers/gpu/drm/mediatek/mtk_drm_crtc.h       |  39 +++
>   drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c   |   7 +
>   drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h   |  35 ++
>   drivers/gpu/drm/mediatek/mtk_drm_drv.c        |  30 +-
>   drivers/gpu/drm/mediatek/mtk_drm_drv.h        |  16 +
>   drivers/gpu/drm/mediatek/mtk_drm_plane.c      |  15 +-
>   drivers/gpu/drm/mediatek/mtk_ethdr.c          | 106 +++++-
>   drivers/gpu/drm/mediatek/mtk_ethdr.h          |   5 +
>   drivers/soc/mediatek/mtk-mmsys.c              |   1 +
>   include/linux/soc/mediatek/mtk-cmdq.h         |  10 +
>   15 files changed, 834 insertions(+), 68 deletions(-)
> 
> --
> 2.18.0
>
Re: [PATCH v4 00/17] Support IGT in display driver
Posted by Shawn Sung (宋孝謙) 9 months, 2 weeks ago
Hi Angelo,

Thanks for the reminder.
The next version is expected to be released next week.

Regards,
Shawn

The next version will 
On Thu, 2024-02-01 at 11:16 +0100, AngeloGioacchino Del Regno wrote:
> Il 12/12/23 13:19, Hsiao Chien Sung ha scritto:
> > This series is based on mediatek-drm-next.
> > 
> > This series adds support for running IGT (Intel GPU Tool) tests
> > with MediaTek display driver. The following changes will be
> > applied:
> > 
> > 1. Add a new API for creating GCE thread loop to retrieve CRCs
> >     from the hardware component
> > 2. Support hardware CRC calculation in both VDOSYS0 and VDOSYS1
> > 3. Support alpha blending in both VDOSYS0 and VDOSYS1
> > 
> 
> Hello,
> is there still interest in upstreaming this?
> 
> We're interested in enabling more comprehensive IGT tests on MediaTek
> SoCs
> and this series is definitely useful.
> 
> Regards,
> Angelo
> 
> > Changes in v4:
> > - Seperate the patch into smaller ones
> > - Change the title of some patches
> > - Revert the changes that are not related to the series
> > 
> > Changes in v3:
> > - Modify the dt-binding document of Mediatek OVL
> > - Set DRM mode configs accroding to the hardware capabilities
> > - Replace cmdq_pkt_jump_absolute() with cmdq_pkt_jump()
> > 
> > Changes in v2:
> > - Simplify CMDQ by adding commands that are currently used only
> > - Integrate CRC related codes into new APIs for Mixer and OVL to
> > reuse
> > - Add CPU version CRC retrieval when CMDQ is disabled
> > 
> > Hsiao Chien Sung (17):
> >    soc: mediatek: Add register definitions for GCE
> >    soc: mediatek: Disable 9-bit alpha in ETHDR
> >    dt-bindings: display: mediatek: ovl: Modify rules for
> > MT8195/MT8188
> >    drm/mediatek: Add OVL compatible name for MT8195
> >    drm/mediatek: Set DRM mode configs accordingly
> >    drm/mediatek: Support alpha blending in OVL
> >    drm/mediatek: Support alpha blending in Mixer
> >    drm/mediatek: Support alpha blending in display driver
> >    drm/mediatek: Support CSC in OVL
> >    drm/mediatek: Support more color formats in OVL
> >    drm/mediatek: Turn off the layers with zero width or height
> >    drm/mediatek: Support CRC in display driver
> >    drm/mediatek: Support CRC in OVL
> >    drm/mediatek: Support CRC in OVL adaptor
> >    drm/mediatek: Add missing plane settings when async update
> >    drm/mediatek: Fix errors when reporting rotation capability
> >    drm/mediatek: Add comments for the structures
> > 
> >   .../display/mediatek/mediatek,ovl.yaml        |  12 +-
> >   drivers/gpu/drm/mediatek/mtk_disp_drv.h       |   7 +
> >   drivers/gpu/drm/mediatek/mtk_disp_ovl.c       | 326
> > +++++++++++++++---
> >   .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c   |  32 +-
> >   drivers/gpu/drm/mediatek/mtk_drm_crtc.c       | 261
> > +++++++++++++-
> >   drivers/gpu/drm/mediatek/mtk_drm_crtc.h       |  39 +++
> >   drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c   |   7 +
> >   drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h   |  35 ++
> >   drivers/gpu/drm/mediatek/mtk_drm_drv.c        |  30 +-
> >   drivers/gpu/drm/mediatek/mtk_drm_drv.h        |  16 +
> >   drivers/gpu/drm/mediatek/mtk_drm_plane.c      |  15 +-
> >   drivers/gpu/drm/mediatek/mtk_ethdr.c          | 106 +++++-
> >   drivers/gpu/drm/mediatek/mtk_ethdr.h          |   5 +
> >   drivers/soc/mediatek/mtk-mmsys.c              |   1 +
> >   include/linux/soc/mediatek/mtk-cmdq.h         |  10 +
> >   15 files changed, 834 insertions(+), 68 deletions(-)
> > 
> > --
> > 2.18.0
> > 
> 
>