[PATCH 4.14 00/25] 4.14.333-rc1 review

Greg Kroah-Hartman posted 25 patches 2 years ago
Only 0 patches received!
Makefile                                          |   4 +-
arch/s390/mm/pgtable.c                            |   2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c            |   2 +-
drivers/hwmon/acpi_power_meter.c                  |   4 +
drivers/infiniband/hw/bnxt_re/main.c              |   2 +-
drivers/net/ethernet/broadcom/tg3.c               |  42 ++++++--
drivers/net/ethernet/broadcom/tg3.h               |   4 +-
drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c |  29 ++++++
drivers/parport/parport_pc.c                      |  21 ++++
drivers/scsi/be2iscsi/be_main.c                   |   1 +
drivers/tty/serial/8250/8250_early.c              |   1 +
drivers/tty/serial/amba-pl011.c                   | 112 +++++++++++-----------
drivers/tty/serial/sc16is7xx.c                    |  12 +++
fs/nilfs2/sufile.c                                |  44 +++++++--
fs/nilfs2/the_nilfs.c                             |   6 +-
include/net/genetlink.h                           |   3 +
kernel/trace/trace.c                              |  42 ++++----
net/core/drop_monitor.c                           |   4 +-
net/ipv4/tcp_input.c                              |   6 +-
net/netlink/af_netlink.c                          |   4 +-
net/netlink/genetlink.c                           |  35 +++++++
net/packet/af_packet.c                            |  16 ++--
net/packet/internal.h                             |   2 +-
net/psample/psample.c                             |   3 +-
sound/core/pcm.c                                  |   1 +
25 files changed, 286 insertions(+), 116 deletions(-)
[PATCH 4.14 00/25] 4.14.333-rc1 review
Posted by Greg Kroah-Hartman 2 years ago
This is the start of the stable review cycle for the 4.14.333 release.
There are 25 patches in this series, all will be posted as a response
to this one.  If anyone has any issues with these being applied, please
let me know.

Responses should be made by Wed, 13 Dec 2023 18:19:59 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.333-rc1.gz
or in the git tree and branch at:
	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Linux 4.14.333-rc1

Ido Schimmel <idosch@nvidia.com>
    drop_monitor: Require 'CAP_SYS_ADMIN' when joining "events" group

Ido Schimmel <idosch@nvidia.com>
    psample: Require 'CAP_NET_ADMIN' when joining "packets" group

Ido Schimmel <idosch@nvidia.com>
    genetlink: add CAP_NET_ADMIN test for multicast bind

Ido Schimmel <idosch@nvidia.com>
    netlink: don't call ->netlink_bind with table lock held

Ryusuke Konishi <konishi.ryusuke@gmail.com>
    nilfs2: fix missing error check for sb_set_blocksize call

Claudio Imbrenda <imbrenda@linux.ibm.com>
    KVM: s390/mm: Properly reset no-dat

Ronald Wahl <ronald.wahl@raritan.com>
    serial: 8250_omap: Add earlycon support for the AM654 UART controller

Daniel Mack <daniel@zonque.org>
    serial: sc16is7xx: address RX timeout interrupt errata

Arnd Bergmann <arnd@arndb.de>
    ARM: PL011: Fix DMA support

Cameron Williams <cang1@live.co.uk>
    parport: Add support for Brainboxes IX/UC/PX parallel cards

Daniel Borkmann <daniel@iogearbox.net>
    packet: Move reference count in packet_sock to atomic_long_t

Petr Pavlu <petr.pavlu@suse.com>
    tracing: Fix a possible race when disabling buffered events

Petr Pavlu <petr.pavlu@suse.com>
    tracing: Fix incomplete locking when disabling buffered events

Steven Rostedt (Google) <rostedt@goodmis.org>
    tracing: Always update snapshot buffer size

Ryusuke Konishi <konishi.ryusuke@gmail.com>
    nilfs2: prevent WARNING in nilfs_sufile_set_segment_usage()

Jason Zhang <jason.zhang@rock-chips.com>
    ALSA: pcm: fix out-of-bounds in snd_pcm_state_names

Dinghao Liu <dinghao.liu@zju.edu.cn>
    scsi: be2iscsi: Fix a memleak in beiscsi_init_wrb_handle()

Petr Pavlu <petr.pavlu@suse.com>
    tracing: Fix a warning when allocating buffered events fails

Armin Wolf <W_Armin@gmx.de>
    hwmon: (acpi_power_meter) Fix 4.29 MW bug

Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
    RDMA/bnxt_re: Correct module description string

Eric Dumazet <edumazet@google.com>
    tcp: do not accept ACK of bytes we never sent

Yonglong Liu <liuyonglong@huawei.com>
    net: hns: fix fake link up on xge port

YuanShang <YuanShang.Mao@amd.com>
    drm/amdgpu: correct chunk_ptr to a pointer to chunk.

Alex Pakhunov <alexey.pakhunov@spacex.com>
    tg3: Increment tx_dropped in tg3_tso_bug()

Alex Pakhunov <alexey.pakhunov@spacex.com>
    tg3: Move the [rt]x_dropped counters to tg3_napi


-------------

Diffstat:

 Makefile                                          |   4 +-
 arch/s390/mm/pgtable.c                            |   2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c            |   2 +-
 drivers/hwmon/acpi_power_meter.c                  |   4 +
 drivers/infiniband/hw/bnxt_re/main.c              |   2 +-
 drivers/net/ethernet/broadcom/tg3.c               |  42 ++++++--
 drivers/net/ethernet/broadcom/tg3.h               |   4 +-
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c |  29 ++++++
 drivers/parport/parport_pc.c                      |  21 ++++
 drivers/scsi/be2iscsi/be_main.c                   |   1 +
 drivers/tty/serial/8250/8250_early.c              |   1 +
 drivers/tty/serial/amba-pl011.c                   | 112 +++++++++++-----------
 drivers/tty/serial/sc16is7xx.c                    |  12 +++
 fs/nilfs2/sufile.c                                |  44 +++++++--
 fs/nilfs2/the_nilfs.c                             |   6 +-
 include/net/genetlink.h                           |   3 +
 kernel/trace/trace.c                              |  42 ++++----
 net/core/drop_monitor.c                           |   4 +-
 net/ipv4/tcp_input.c                              |   6 +-
 net/netlink/af_netlink.c                          |   4 +-
 net/netlink/genetlink.c                           |  35 +++++++
 net/packet/af_packet.c                            |  16 ++--
 net/packet/internal.h                             |   2 +-
 net/psample/psample.c                             |   3 +-
 sound/core/pcm.c                                  |   1 +
 25 files changed, 286 insertions(+), 116 deletions(-)
Re: [PATCH 4.14 00/25] 4.14.333-rc1 review
Posted by Pavel Machek 2 years ago
Hi!

> This is the start of the stable review cycle for the 4.14.333 release.
> There are 25 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.

CIP testing did not find any problems here:

https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.14.y

Tested-by: Pavel Machek (CIP) <pavel@denx.de>

Best regards,
                                                                Pavel
-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Re: [PATCH 4.14 00/25] 4.14.333-rc1 review
Posted by Daniel Díaz 2 years ago
Hello!

On 11/12/23 12:20 p. m., Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.14.333 release.
> There are 25 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
> 
> Responses should be made by Wed, 13 Dec 2023 18:19:59 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.333-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
> and the diffstat can be found below.
> 
> thanks,
> 
> greg k-h
> 
> -------------
> Pseudo-Shortlog of commits:
> 
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>      Linux 4.14.333-rc1
> 
[...]
> 
> Arnd Bergmann <arnd@arndb.de>
>      ARM: PL011: Fix DMA support
[...]

We see a build problem with this commit (at least) on 4.14:
-----8<-----
   /builds/linux/kernel/sched/core.c: In function 'sched_init':
   /builds/linux/kernel/sched/core.c:5962:30: warning: the comparison will always evaluate as 'false' for the address of 'cpu_isolated_map' will never be NULL [-Waddress]
    5962 |         if (cpu_isolated_map == NULL)
         |                              ^~
   /builds/linux/kernel/sched/core.c:87:15: note: 'cpu_isolated_map' declared here
      87 | cpumask_var_t cpu_isolated_map;
         |               ^~~~~~~~~~~~~~~~
   /builds/linux/drivers/tty/serial/amba-pl011.c: In function 'pl011_dma_tx_refill':
   /builds/linux/drivers/tty/serial/amba-pl011.c:657:27: error: 'DMA_MAPPING_ERROR' undeclared (first use in this function)
     657 |         if (dmatx->dma == DMA_MAPPING_ERROR) {
         |                           ^~~~~~~~~~~~~~~~~
   /builds/linux/drivers/tty/serial/amba-pl011.c:657:27: note: each undeclared identifier is reported only once for each function it appears in
   make[4]: *** [/builds/linux/scripts/Makefile.build:329: drivers/tty/serial/amba-pl011.o] Error 1
   make[4]: Target '__build' not remade because of errors.
----->8-----

Reverting that patch makes the build for arm/u8500_defconfig. We'll continue looking for other things.

Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

Greetings!

Daniel Díaz
daniel.diaz@linaro.org

Re: [PATCH 4.14 00/25] 4.14.333-rc1 review
Posted by Greg Kroah-Hartman 2 years ago
On Mon, Dec 11, 2023 at 01:46:03PM -0600, Daniel Díaz wrote:
> Hello!
> 
> On 11/12/23 12:20 p. m., Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 4.14.333 release.
> > There are 25 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Wed, 13 Dec 2023 18:19:59 +0000.
> > Anything received after that time might be too late.
> > 
> > The whole patch series can be found in one patch at:
> > 	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.333-rc1.gz
> > or in the git tree and branch at:
> > 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
> > and the diffstat can be found below.
> > 
> > thanks,
> > 
> > greg k-h
> > 
> > -------------
> > Pseudo-Shortlog of commits:
> > 
> > Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >      Linux 4.14.333-rc1
> > 
> [...]
> > 
> > Arnd Bergmann <arnd@arndb.de>
> >      ARM: PL011: Fix DMA support
> [...]
> 
> We see a build problem with this commit (at least) on 4.14:
> -----8<-----
>   /builds/linux/kernel/sched/core.c: In function 'sched_init':
>   /builds/linux/kernel/sched/core.c:5962:30: warning: the comparison will always evaluate as 'false' for the address of 'cpu_isolated_map' will never be NULL [-Waddress]
>    5962 |         if (cpu_isolated_map == NULL)
>         |                              ^~
>   /builds/linux/kernel/sched/core.c:87:15: note: 'cpu_isolated_map' declared here
>      87 | cpumask_var_t cpu_isolated_map;
>         |               ^~~~~~~~~~~~~~~~
>   /builds/linux/drivers/tty/serial/amba-pl011.c: In function 'pl011_dma_tx_refill':
>   /builds/linux/drivers/tty/serial/amba-pl011.c:657:27: error: 'DMA_MAPPING_ERROR' undeclared (first use in this function)
>     657 |         if (dmatx->dma == DMA_MAPPING_ERROR) {
>         |                           ^~~~~~~~~~~~~~~~~
>   /builds/linux/drivers/tty/serial/amba-pl011.c:657:27: note: each undeclared identifier is reported only once for each function it appears in
>   make[4]: *** [/builds/linux/scripts/Makefile.build:329: drivers/tty/serial/amba-pl011.o] Error 1
>   make[4]: Target '__build' not remade because of errors.
> ----->8-----
> 
> Reverting that patch makes the build for arm/u8500_defconfig. We'll continue looking for other things.
> 
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

Thanks, now dropped, I'll push out a -rc2 with this fix.

greg k-h