[v1] Improve SOF support for Steam Deck OLED

[PATCH 06/11] ASoC: SOF: amd: Optimize quirk for Valve Galileo

Posted by Cristian Ciocaltea 2 years ago

Valve's Steam Deck OLED is uniquely identified by vendor and product
name (Galileo) DMI fields.

Simplify the quirk by removing the unnecessary match on product family.

Additionally, fix the related comment as it points to the old product
variant.

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
 sound/soc/sof/amd/acp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/soc/sof/amd/acp.c b/sound/soc/sof/amd/acp.c
index c6f637f29847..1e9840ae8938 100644
--- a/sound/soc/sof/amd/acp.c
+++ b/sound/soc/sof/amd/acp.c
@@ -28,11 +28,10 @@ MODULE_PARM_DESC(enable_fw_debug, "Enable Firmware debug");
 
 const struct dmi_system_id acp_sof_quirk_table[] = {
 	{
-		/* Valve Jupiter device */
+		/* Steam Deck OLED device */
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "Valve"),
 			DMI_MATCH(DMI_PRODUCT_NAME, "Galileo"),
-			DMI_MATCH(DMI_PRODUCT_FAMILY, "Sephiroth"),
 		},
 		.driver_data = (void *)SECURED_FIRMWARE,
 	},
-- 
2.43.0

Re: [PATCH 06/11] ASoC: SOF: amd: Optimize quirk for Valve Galileo

Posted by Venkata Prasad Potturu 2 years ago

On 12/10/23 02:23, Cristian Ciocaltea wrote:
> Valve's Steam Deck OLED is uniquely identified by vendor and product
> name (Galileo) DMI fields.
>
> Simplify the quirk by removing the unnecessary match on product family.
>
> Additionally, fix the related comment as it points to the old product
> variant.
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
>   sound/soc/sof/amd/acp.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sound/soc/sof/amd/acp.c b/sound/soc/sof/amd/acp.c
> index c6f637f29847..1e9840ae8938 100644
> --- a/sound/soc/sof/amd/acp.c
> +++ b/sound/soc/sof/amd/acp.c
> @@ -28,11 +28,10 @@ MODULE_PARM_DESC(enable_fw_debug, "Enable Firmware debug");
>   
>   const struct dmi_system_id acp_sof_quirk_table[] = {
>   	{
> -		/* Valve Jupiter device */
> +		/* Steam Deck OLED device */
If any changes in SOF drivers, first need to create a PR in SOF github.
>   		.matches = {
>   			DMI_MATCH(DMI_SYS_VENDOR, "Valve"),
>   			DMI_MATCH(DMI_PRODUCT_NAME, "Galileo"),
> -			DMI_MATCH(DMI_PRODUCT_FAMILY, "Sephiroth"),
>   		},
>   		.driver_data = (void *)SECURED_FIRMWARE,
>   	},

Re: [PATCH 06/11] ASoC: SOF: amd: Optimize quirk for Valve Galileo

Posted by Cristian Ciocaltea 2 years ago

On 12/10/23 05:33, Venkata Prasad Potturu wrote:
> 
> On 12/10/23 02:23, Cristian Ciocaltea wrote:
>> Valve's Steam Deck OLED is uniquely identified by vendor and product
>> name (Galileo) DMI fields.
>>
>> Simplify the quirk by removing the unnecessary match on product family.
>>
>> Additionally, fix the related comment as it points to the old product
>> variant.
>>
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>> ---
>>   sound/soc/sof/amd/acp.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/sound/soc/sof/amd/acp.c b/sound/soc/sof/amd/acp.c
>> index c6f637f29847..1e9840ae8938 100644
>> --- a/sound/soc/sof/amd/acp.c
>> +++ b/sound/soc/sof/amd/acp.c
>> @@ -28,11 +28,10 @@ MODULE_PARM_DESC(enable_fw_debug, "Enable Firmware
>> debug");
>>     const struct dmi_system_id acp_sof_quirk_table[] = {
>>       {
>> -        /* Valve Jupiter device */
>> +        /* Steam Deck OLED device */
> If any changes in SOF drivers, first need to create a PR in SOF github.

This is just an optimization for the driver, no need to change anything
on the firmware side.  The product family remains as is, but it's not
really required to match the board, i.e. the previous board was
"Jupiter", the next one will have a different product name.

>>           .matches = {
>>               DMI_MATCH(DMI_SYS_VENDOR, "Valve"),
>>               DMI_MATCH(DMI_PRODUCT_NAME, "Galileo"),
>> -            DMI_MATCH(DMI_PRODUCT_FAMILY, "Sephiroth"),
>>           },
>>           .driver_data = (void *)SECURED_FIRMWARE,
>>       },