On 12/8/2023 12:28 PM, Manivannan Sadhasivam wrote:
> devm_kzalloc() will itself print the error message on failure. So let's get
> rid of the redundant error message in ufs_qcom_init().
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> drivers/ufs/host/ufs-qcom.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index b141dd2a9346..05a9a25bc34c 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -1109,10 +1109,8 @@ static int ufs_qcom_init(struct ufs_hba *hba)
> struct ufs_clk_info *clki;
>
> host = devm_kzalloc(dev, sizeof(*host), GFP_KERNEL);
> - if (!host) {
> - dev_err(dev, "%s: no memory for qcom ufs host\n", __func__);
> + if (!host)
> return -ENOMEM;
> - }
>
> /* Make a two way bind between the qcom host and the hba */
> host->hba = hba;
Reviewed-by: Nitin Rawat <quic_nitirawa@quicinc.com>