1. Patchew
  2. linux
  3. View series

[PATCH] usb: typec: qcom-pmic: add CONFIG_OF dependency

Randy Dunlap posted 1 patch 2 years ago 
drivers/usb/typec/tcpm/Kconfig |    1 +
1 file changed, 1 insertion(+)
[PATCH] usb: typec: qcom-pmic: add CONFIG_OF dependency
Posted by Randy Dunlap 2 years ago 
DRM_AUX_BRIDGE depends on CONFIG_OF, so that is also needed here
to fix a kconfig warning:

WARNING: unmet direct dependencies detected for DRM_AUX_HPD_BRIDGE
  Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n]
  Selected by [y]:
  - TYPEC_QCOM_PMIC [=y] && USB_SUPPORT [=y] && TYPEC [=y] && TYPEC_TCPM [=y] && (ARCH_QCOM || COMPILE_TEST [=y]) && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y]

Fixes: 7d9f1b72b296 ("usb: typec: qcom-pmic-typec: switch to DRM_AUX_HPD_BRIDGE")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-usb@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>
---
 drivers/usb/typec/tcpm/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff -- a/drivers/usb/typec/tcpm/Kconfig b/drivers/usb/typec/tcpm/Kconfig
--- a/drivers/usb/typec/tcpm/Kconfig
+++ b/drivers/usb/typec/tcpm/Kconfig
@@ -80,6 +80,7 @@ config TYPEC_QCOM_PMIC
 	tristate "Qualcomm PMIC USB Type-C Port Controller Manager driver"
 	depends on ARCH_QCOM || COMPILE_TEST
 	depends on DRM || DRM=n
+	depends on OF
 	select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE
 	help
 	  A Type-C port and Power Delivery driver which aggregates two
Re: [PATCH] usb: typec: qcom-pmic: add CONFIG_OF dependency
Posted by Guenter Roeck 2 years ago 
On Wed, Dec 06, 2023 at 09:20:37AM -0800, Randy Dunlap wrote:
> DRM_AUX_BRIDGE depends on CONFIG_OF, so that is also needed here
> to fix a kconfig warning:
> 
> WARNING: unmet direct dependencies detected for DRM_AUX_HPD_BRIDGE
>   Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n]
>   Selected by [y]:
>   - TYPEC_QCOM_PMIC [=y] && USB_SUPPORT [=y] && TYPEC [=y] && TYPEC_TCPM [=y] && (ARCH_QCOM || COMPILE_TEST [=y]) && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y]
> 

All but impossible for me to determine if this patch or
https://lore.kernel.org/all/20231205-drm_aux_bridge-fixes-v1-2-d242a0ae9df4@kernel.org/
is more appropriate.

Guenter

> Fixes: 7d9f1b72b296 ("usb: typec: qcom-pmic-typec: switch to DRM_AUX_HPD_BRIDGE")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: linux-usb@vger.kernel.org
> Cc: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/usb/typec/tcpm/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff -- a/drivers/usb/typec/tcpm/Kconfig b/drivers/usb/typec/tcpm/Kconfig
> --- a/drivers/usb/typec/tcpm/Kconfig
> +++ b/drivers/usb/typec/tcpm/Kconfig
> @@ -80,6 +80,7 @@ config TYPEC_QCOM_PMIC
>  	tristate "Qualcomm PMIC USB Type-C Port Controller Manager driver"
>  	depends on ARCH_QCOM || COMPILE_TEST
>  	depends on DRM || DRM=n
> +	depends on OF
>  	select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE
>  	help
>  	  A Type-C port and Power Delivery driver which aggregates two
Re: [PATCH] usb: typec: qcom-pmic: add CONFIG_OF dependency
Posted by Randy Dunlap 2 years ago 

On 12/6/23 10:49, Guenter Roeck wrote:
> On Wed, Dec 06, 2023 at 09:20:37AM -0800, Randy Dunlap wrote:
>> DRM_AUX_BRIDGE depends on CONFIG_OF, so that is also needed here
>> to fix a kconfig warning:
>>
>> WARNING: unmet direct dependencies detected for DRM_AUX_HPD_BRIDGE
>>   Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n]
>>   Selected by [y]:
>>   - TYPEC_QCOM_PMIC [=y] && USB_SUPPORT [=y] && TYPEC [=y] && TYPEC_TCPM [=y] && (ARCH_QCOM || COMPILE_TEST [=y]) && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y]
>>
> 
> All but impossible for me to determine if this patch or
> https://lore.kernel.org/all/20231205-drm_aux_bridge-fixes-v1-2-d242a0ae9df4@kernel.org/
> is more appropriate.
> 
> Guenter

I guess that Bryan is the person to ask about that.

I don't see anything wrong with Nathan's patch. It should clear up the kconfig warning,
so as long as it builds cleanly, it seems OK.

> 
>> Fixes: 7d9f1b72b296 ("usb: typec: qcom-pmic-typec: switch to DRM_AUX_HPD_BRIDGE")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>> Cc: Guenter Roeck <linux@roeck-us.net>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: linux-arm-msm@vger.kernel.org
>> Cc: linux-usb@vger.kernel.org
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> ---
>>  drivers/usb/typec/tcpm/Kconfig |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff -- a/drivers/usb/typec/tcpm/Kconfig b/drivers/usb/typec/tcpm/Kconfig
>> --- a/drivers/usb/typec/tcpm/Kconfig
>> +++ b/drivers/usb/typec/tcpm/Kconfig
>> @@ -80,6 +80,7 @@ config TYPEC_QCOM_PMIC
>>  	tristate "Qualcomm PMIC USB Type-C Port Controller Manager driver"
>>  	depends on ARCH_QCOM || COMPILE_TEST
>>  	depends on DRM || DRM=n
>> +	depends on OF
>>  	select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE
>>  	help
>>  	  A Type-C port and Power Delivery driver which aggregates two

-- 
~Randy
Re: [PATCH] usb: typec: qcom-pmic: add CONFIG_OF dependency
Posted by Bryan O'Donoghue 2 years ago 
On 06/12/2023 20:46, Randy Dunlap wrote:
> 
> 
> On 12/6/23 10:49, Guenter Roeck wrote:
>> On Wed, Dec 06, 2023 at 09:20:37AM -0800, Randy Dunlap wrote:
>>> DRM_AUX_BRIDGE depends on CONFIG_OF, so that is also needed here
>>> to fix a kconfig warning:
>>>
>>> WARNING: unmet direct dependencies detected for DRM_AUX_HPD_BRIDGE
>>>    Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n]
>>>    Selected by [y]:
>>>    - TYPEC_QCOM_PMIC [=y] && USB_SUPPORT [=y] && TYPEC [=y] && TYPEC_TCPM [=y] && (ARCH_QCOM || COMPILE_TEST [=y]) && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y]
>>>
>>
>> All but impossible for me to determine if this patch or
>> https://lore.kernel.org/all/20231205-drm_aux_bridge-fixes-v1-2-d242a0ae9df4@kernel.org/
>> is more appropriate.
>>
>> Guenter
> 
> I guess that Bryan is the person to ask about that.
> 
> I don't see anything wrong with Nathan's patch. It should clear up the kconfig warning,
> so as long as it builds cleanly, it seems OK.
> 

So, I see both versions of this fix

Nathan's
drivers/gpu/drm/renesas/rcar-du/Kconfig

Yours
drivers/gpu/drm/tve200/Kconfig

and virtually equivalent commit text. I think we agree its 1:1

So, maybe stick with Nathan's since he posted first.

---
bod
Re: [PATCH] usb: typec: qcom-pmic: add CONFIG_OF dependency
Posted by Randy Dunlap 2 years ago 

On 12/6/23 13:21, Bryan O'Donoghue wrote:
> On 06/12/2023 20:46, Randy Dunlap wrote:
>>
>>
>> On 12/6/23 10:49, Guenter Roeck wrote:
>>> On Wed, Dec 06, 2023 at 09:20:37AM -0800, Randy Dunlap wrote:
>>>> DRM_AUX_BRIDGE depends on CONFIG_OF, so that is also needed here
>>>> to fix a kconfig warning:
>>>>
>>>> WARNING: unmet direct dependencies detected for DRM_AUX_HPD_BRIDGE
>>>>    Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n]
>>>>    Selected by [y]:
>>>>    - TYPEC_QCOM_PMIC [=y] && USB_SUPPORT [=y] && TYPEC [=y] && TYPEC_TCPM [=y] && (ARCH_QCOM || COMPILE_TEST [=y]) && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y]
>>>>
>>>
>>> All but impossible for me to determine if this patch or
>>> https://lore.kernel.org/all/20231205-drm_aux_bridge-fixes-v1-2-d242a0ae9df4@kernel.org/
>>> is more appropriate.
>>>
>>> Guenter
>>
>> I guess that Bryan is the person to ask about that.
>>
>> I don't see anything wrong with Nathan's patch. It should clear up the kconfig warning,
>> so as long as it builds cleanly, it seems OK.
>>
> 
> So, I see both versions of this fix
> 
> Nathan's
> drivers/gpu/drm/renesas/rcar-du/Kconfig

No, please see https://lore.kernel.org/all/20231205-drm_aux_bridge-fixes-v1-2-d242a0ae9df4@kernel.org/

> 
> Yours
> drivers/gpu/drm/tve200/Kconfig

No, please see https://lore.kernel.org/linux-usb/a058827a-b025-4ee5-b2a4-d6c8963a6b73@linaro.org/T/#m034fb56a750522f18813642259b18bb4867ceb46

> 
> and virtually equivalent commit text. I think we agree its 1:1
> 
> So, maybe stick with Nathan's since he posted first.

Sure, I'm OK with that.

-- 
~Randy

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.