[Patch v5 11/11] arm64: dts: fsd: Add MFC related DT enteries

Aakarsh Jain posted 11 patches 2 years ago
[Patch v5 11/11] arm64: dts: fsd: Add MFC related DT enteries
Posted by Aakarsh Jain 2 years ago
Add MFC DT node and reserve memory node for MFC usage.

Cc: linux-fsd@tesla.com
Signed-off-by: Smitha T Murthy <smithatmurthy@gmail.com>
Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
---
 arch/arm64/boot/dts/tesla/fsd.dtsi | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi
index bb50a9f7db4a..f421012b0a4a 100644
--- a/arch/arm64/boot/dts/tesla/fsd.dtsi
+++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
@@ -342,6 +342,18 @@
 		#clock-cells = <0>;
 	};
 
+	reserved-memory {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		mfc_left: region@84000000 {
+			compatible = "shared-dma-pool";
+			no-map;
+			reg = <0 0x84000000 0 0x8000000>;
+		};
+	};
+
 	soc: soc@0 {
 		compatible = "simple-bus";
 		#address-cells = <2>;
@@ -956,6 +968,15 @@
 			clock-names = "fin_pll", "mct";
 		};
 
+		mfc: mfc@12880000 {
+			compatible = "tesla,fsd-mfc";
+			reg = <0x0 0x12880000 0x0 0x10000>;
+			interrupts = <GIC_SPI 137 IRQ_TYPE_LEVEL_HIGH>;
+			clock-names = "mfc";
+			clocks = <&clock_mfc MFC_MFC_IPCLKPORT_ACLK>;
+			memory-region = <&mfc_left>;
+		};
+
 		ufs: ufs@15120000 {
 			compatible = "tesla,fsd-ufs";
 			reg = <0x0 0x15120000 0x0 0x200>,  /* 0: HCI standard */
-- 
2.17.1
Re: [Patch v5 11/11] arm64: dts: fsd: Add MFC related DT enteries
Posted by Krzysztof Kozlowski 2 years ago
On 06/12/2023 07:30, Aakarsh Jain wrote:
> Add MFC DT node and reserve memory node for MFC usage.
> 
> Cc: linux-fsd@tesla.com
> Signed-off-by: Smitha T Murthy <smithatmurthy@gmail.com>
> Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
> ---

Always run checkpatch on your patches:

[Checkpatch]
WARNING: Use a single space after Cc:
#8:
Cc:  <linux-fsd@tesla.com>


Best regards,
Krzysztof
Re: [Patch v5 11/11] arm64: dts: fsd: Add MFC related DT enteries
Posted by Krzysztof Kozlowski 2 years ago
On 06/12/2023 07:30, Aakarsh Jain wrote:
> Add MFC DT node and reserve memory node for MFC usage.
> 
> Cc: linux-fsd@tesla.com
> Signed-off-by: Smitha T Murthy <smithatmurthy@gmail.com>
> Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
> ---
>  arch/arm64/boot/dts/tesla/fsd.dtsi | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)

This should be merged via Samsung SoC, so I will take it once bindings
get accepted.

If there is going to be resend of entire patchset, please don't include
this patch in new resend. If this patch needs resending, send it
separately and provide lore link to the bindings.

Best regards,
Krzysztof
Re: (subset) [Patch v5 11/11] arm64: dts: fsd: Add MFC related DT enteries
Posted by Krzysztof Kozlowski 2 years ago
On Wed, 06 Dec 2023 12:00:45 +0530, Aakarsh Jain wrote:
> Add MFC DT node and reserve memory node for MFC usage.
> 
> 

Applied, thanks!

[11/11] arm64: dts: fsd: Add MFC related DT enteries
        https://git.kernel.org/krzk/linux/c/a41d9b3287b1d2d737984465e6efbf09a4fb51d2

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>