[v6] pinctl: qcom: sm4450: Add SM4450 pinctrl driver

[PATCH v6 0/2] pinctl: qcom: sm4450: Add SM4450 pinctrl driver

Posted by Tengfei Fan 2 years ago

Add SM4450 pinctrl driver for support enable uart console.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
v5 -> v6:
  - squash the fixups into the newly added driver
  - drop reviewed-by due to update patch as new comments

v4 -> v5:
  - Convert to platform remove callback returning void
  - correct incorrect address offset

v3 -> v4:
  - update gpio pins pattern

v2 -> v3:
  - update example pieces
  - update gpio pins pattern

v1 -> v2:
  - update right platform name
  - update gpio-reserved-ranges have right maxItems
  - update gpio-line-names have right maxItems
  - add min/maxItems for pins properties
  - redo dt_binding_check check
  - delete reserved gpios setting
  - combine separate pinctrl functions

previous discussion here:
[1] v5: https://lore.kernel.org/linux-arm-msm/20231130024046.25938-1-quic_tengfan@quicinc.com
[2] v4: https://lore.kernel.org/linux-arm-msm/20230920082102.5744-1-quic_tengfan@quicinc.com
[3] v3: https://lore.kernel.org/linux-arm-msm/20230920064739.12562-1-quic_tengfan@quicinc.com
[4] v2: https://lore.kernel.org/linux-arm-msm/20230915015808.18296-1-quic_tengfan@quicinc.com
[5] v1: https://lore.kernel.org/linux-arm-msm/20230908063843.26835-1-quic_tengfan@quicinc.com

Tengfei Fan (2):
  dt-bindings: pinctrl: qcom: Add SM4450 pinctrl
  pinctrl: qcom: sm4450: dd SM4450 pinctrl driver

 .../bindings/pinctrl/qcom,sm4450-tlmm.yaml    |  151 +++
 drivers/pinctrl/qcom/Kconfig.msm              |    8 +
 drivers/pinctrl/qcom/Makefile                 |    1 +
 drivers/pinctrl/qcom/pinctrl-sm4450.c         | 1014 +++++++++++++++++
 4 files changed, 1174 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
 create mode 100644 drivers/pinctrl/qcom/pinctrl-sm4450.c


base-commit: 0f5f12ac05f36f117e793656c3f560625e927f1b
-- 
2.17.1

Re: [PATCH v6 0/2] pinctl: qcom: sm4450: Add SM4450 pinctrl driver

Posted by Krzysztof Kozlowski 2 years ago

On 06/12/2023 03:08, Tengfei Fan wrote:
> Add SM4450 pinctrl driver for support enable uart console.
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
> v5 -> v6:
>   - squash the fixups into the newly added driver
>   - drop reviewed-by due to update patch as new comments

Really? Why? What exactly changed in the patch you dropped my review?

Best regards,
Krzysztof

Re: [PATCH v6 0/2] pinctl: qcom: sm4450: Add SM4450 pinctrl driver

Posted by Tengfei Fan 2 years ago


在 12/6/2023 4:59 PM, Krzysztof Kozlowski 写道:
> On 06/12/2023 03:08, Tengfei Fan wrote:
>> Add SM4450 pinctrl driver for support enable uart console.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>> v5 -> v6:
>>    - squash the fixups into the newly added driver
>>    - drop reviewed-by due to update patch as new comments
> 
> Really? Why? What exactly changed in the patch you dropped my review?
> 
> Best regards,
> Krzysztof
> 
There was a wrong understanging of reviewed-by tag before. reviewed-by 
tag will be added again in the next version patch series.


-- 
Thx and BRs,
Tengfei Fan