arm64: dts: ti: k3-am62-main: Add GPU device node

[PATCH] arm64: dts: ti: k3-am62-main: Add GPU device node

Posted by Donald Robson 2 years ago

From: Sarah Walker <sarah.walker@imgtec.com>

Add the Series AXE GPU node to the AM62 device tree.

Signed-off-by: Sarah Walker <sarah.walker@imgtec.com>
Signed-off-by: Donald Robson <donald.robson@imgtec.com>
---
 arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
index e5c64c86d1d5..4338fd8ab2d7 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
@@ -965,4 +965,13 @@ mcasp2: audio-controller@2b20000 {
 		power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
 		status = "disabled";
 	};
+
+	gpu: gpu@fd00000 {
+		compatible = "ti,am62-gpu", "img,img-axe";
+		reg = <0x00 0x0fd00000 0x00 0x20000>;
+		clocks = <&k3_clks 187 0>;
+		clock-names = "core";
+		interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
+		power-domains = <&k3_pds 187 TI_SCI_PD_EXCLUSIVE>;
+	};
 };
-- 
2.25.1

Re: [PATCH] arm64: dts: ti: k3-am62-main: Add GPU device node

Posted by Sverdlin, Alexander 2 years ago

Hi Donald, Sarah et al,

thanks for the patch!

On Mon, 2023-12-04 at 12:15 +0000, Donald Robson wrote:
> From: Sarah Walker <sarah.walker@imgtec.com>
> 
> Add the Series AXE GPU node to the AM62 device tree.
> 
> Signed-off-by: Sarah Walker <sarah.walker@imgtec.com>
> Signed-off-by: Donald Robson <donald.robson@imgtec.com>

powervr fd00000.gpu: [drm] loaded firmware powervr/rogue_33.15.11.3_v1.fw
powervr fd00000.gpu: [drm] FW version v1.0 (build 6503725 OS)
[drm] Initialized powervr 1.0.0 20230904 for fd00000.gpu on minor 0

In general it allows the driver to be probed on TI AM625 EK, so
Tested-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>

But I'm not sure if you maybe want to disable it by default like
other HW blocks for the (potential) boards which don't have video at all.

> ---
>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index e5c64c86d1d5..4338fd8ab2d7 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -965,4 +965,13 @@ mcasp2: audio-controller@2b20000 {
>                 power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
>                 status = "disabled";
>         };
> +
> +       gpu: gpu@fd00000 {
> +               compatible = "ti,am62-gpu", "img,img-axe";
> +               reg = <0x00 0x0fd00000 0x00 0x20000>;
> +               clocks = <&k3_clks 187 0>;
> +               clock-names = "core";
> +               interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
> +               power-domains = <&k3_pds 187 TI_SCI_PD_EXCLUSIVE>;
> +       };
>  };

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com

Re: [PATCH] arm64: dts: ti: k3-am62-main: Add GPU device node

Posted by Nishanth Menon 2 years ago

On 11:15-20231205, Sverdlin, Alexander wrote:
> Hi Donald, Sarah et al,
> 
> thanks for the patch!
> 
> On Mon, 2023-12-04 at 12:15 +0000, Donald Robson wrote:
> > From: Sarah Walker <sarah.walker@imgtec.com>
> > 
> > Add the Series AXE GPU node to the AM62 device tree.
> > 
> > Signed-off-by: Sarah Walker <sarah.walker@imgtec.com>
> > Signed-off-by: Donald Robson <donald.robson@imgtec.com>
> 
> powervr fd00000.gpu: [drm] loaded firmware powervr/rogue_33.15.11.3_v1.fw
> powervr fd00000.gpu: [drm] FW version v1.0 (build 6503725 OS)
> [drm] Initialized powervr 1.0.0 20230904 for fd00000.gpu on minor 0
> 
> In general it allows the driver to be probed on TI AM625 EK, so
> Tested-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
> 
> But I'm not sure if you maybe want to disable it by default like
> other HW blocks for the (potential) boards which don't have video at all.

There is no board level dependency for GPU, so only place we have
permitted status = "disabled" is when the node has specific board
interface level (pinmux...) to  be operational completely.

So, no, default shouldn't have a status = "disabled".

> 
> > ---
> >  arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > index e5c64c86d1d5..4338fd8ab2d7 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > @@ -965,4 +965,13 @@ mcasp2: audio-controller@2b20000 {
> >                 power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
> >                 status = "disabled";
> >         };
> > +
> > +       gpu: gpu@fd00000 {
> > +               compatible = "ti,am62-gpu", "img,img-axe";
> > +               reg = <0x00 0x0fd00000 0x00 0x20000>;
> > +               clocks = <&k3_clks 187 0>;
> > +               clock-names = "core";
> > +               interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
> > +               power-domains = <&k3_pds 187 TI_SCI_PD_EXCLUSIVE>;
> > +       };
> >  };
> 
> -- 
> Alexander Sverdlin
> Siemens AG
> www.siemens.com

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH] arm64: dts: ti: k3-am62-main: Add GPU device node

Posted by Donald Robson 2 years ago

Hello Alexander,

On Tue, 2023-12-05 at 11:15 +0000, Sverdlin, Alexander wrote:
> Hi Donald, Sarah et al,
> 
> thanks for the patch!
> 
> On Mon, 2023-12-04 at 12:15 +0000, Donald Robson wrote:
> > From: Sarah Walker <sarah.walker@imgtec.com>
> > 
> > Add the Series AXE GPU node to the AM62 device tree.
> > 
> > Signed-off-by: Sarah Walker <sarah.walker@imgtec.com>
> > Signed-off-by: Donald Robson <donald.robson@imgtec.com>
> 
> powervr fd00000.gpu: [drm] loaded firmware powervr/rogue_33.15.11.3_v1.fw
> powervr fd00000.gpu: [drm] FW version v1.0 (build 6503725 OS)
> [drm] Initialized powervr 1.0.0 20230904 for fd00000.gpu on minor 0
> 
> In general it allows the driver to be probed on TI AM625 EK, so
> Tested-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>

Thanks!

> 
> But I'm not sure if you maybe want to disable it by default like
> other HW blocks for the (potential) boards which don't have video at all.

Nor I. I guess it should still be enabled so it can be used for compute?

Thanks,
Donald

> 
> > ---
> >  arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > index e5c64c86d1d5..4338fd8ab2d7 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > @@ -965,4 +965,13 @@ mcasp2: audio-controller@2b20000 {
> >                 power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
> >                 status = "disabled";
> >         };
> > +
> > +       gpu: gpu@fd00000 {
> > +               compatible = "ti,am62-gpu", "img,img-axe";
> > +               reg = <0x00 0x0fd00000 0x00 0x20000>;
> > +               clocks = <&k3_clks 187 0>;
> > +               clock-names = "core";
> > +               interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
> > +               power-domains = <&k3_pds 187 TI_SCI_PD_EXCLUSIVE>;
> > +       };
> >  };

Re: [PATCH] arm64: dts: ti: k3-am62-main: Add GPU device node

Posted by mripard@kernel.org 2 years ago

On Tue, Dec 05, 2023 at 11:26:04AM +0000, Donald Robson wrote:
> Hello Alexander,
> 
> On Tue, 2023-12-05 at 11:15 +0000, Sverdlin, Alexander wrote:
> > Hi Donald, Sarah et al,
> > 
> > thanks for the patch!
> > 
> > On Mon, 2023-12-04 at 12:15 +0000, Donald Robson wrote:
> > > From: Sarah Walker <sarah.walker@imgtec.com>
> > > 
> > > Add the Series AXE GPU node to the AM62 device tree.
> > > 
> > > Signed-off-by: Sarah Walker <sarah.walker@imgtec.com>
> > > Signed-off-by: Donald Robson <donald.robson@imgtec.com>
> > 
> > powervr fd00000.gpu: [drm] loaded firmware powervr/rogue_33.15.11.3_v1.fw
> > powervr fd00000.gpu: [drm] FW version v1.0 (build 6503725 OS)
> > [drm] Initialized powervr 1.0.0 20230904 for fd00000.gpu on minor 0
> > 
> > In general it allows the driver to be probed on TI AM625 EK, so
> > Tested-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
> 
> Thanks!
> 
> > 
> > But I'm not sure if you maybe want to disable it by default like
> > other HW blocks for the (potential) boards which don't have video at all.
> 
> Nor I. I guess it should still be enabled so it can be used for compute?

It's standalone and doesn't require any additional (or external)
resources that boards could just ignore.

So there's no real reason to disable it, ever.

Maxime

Re: [PATCH] arm64: dts: ti: k3-am62-main: Add GPU device node

Posted by Nishanth Menon 2 years ago

On 12:15-20231204, Donald Robson wrote:
> From: Sarah Walker <sarah.walker@imgtec.com>
> 
> Add the Series AXE GPU node to the AM62 device tree.
> 
> Signed-off-by: Sarah Walker <sarah.walker@imgtec.com>
> Signed-off-by: Donald Robson <donald.robson@imgtec.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index e5c64c86d1d5..4338fd8ab2d7 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -965,4 +965,13 @@ mcasp2: audio-controller@2b20000 {
>  		power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
>  		status = "disabled";
>  	};
> +
> +	gpu: gpu@fd00000 {
> +		compatible = "ti,am62-gpu", "img,img-axe";
> +		reg = <0x00 0x0fd00000 0x00 0x20000>;
> +		clocks = <&k3_clks 187 0>;
> +		clock-names = "core";
> +		interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
> +		power-domains = <&k3_pds 187 TI_SCI_PD_EXCLUSIVE>;
> +	};
>  };
> -- 
> 2.25.1
> 

Please also add a patch to enable GPU in the default armv8 defconfig as a
kernel module.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D