[PATCH v3 2/5] w1: ds2433: remove unused definition

marc.ferland@gmail.com posted 5 patches 2 years ago
There is a newer version of this series
[PATCH v3 2/5] w1: ds2433: remove unused definition
Posted by marc.ferland@gmail.com 2 years ago
From: Marc Ferland <marc.ferland@sonatest.com>

W1_F23_TIME isn't used anywhere, get rid of it.

Signed-off-by: Marc Ferland <marc.ferland@sonatest.com>
---
 drivers/w1/slaves/w1_ds2433.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/w1/slaves/w1_ds2433.c b/drivers/w1/slaves/w1_ds2433.c
index 9f21fd98f799..e18523ef8c45 100644
--- a/drivers/w1/slaves/w1_ds2433.c
+++ b/drivers/w1/slaves/w1_ds2433.c
@@ -30,8 +30,6 @@
 #define W1_PAGE_BITS		5
 #define W1_PAGE_MASK		0x1F
 
-#define W1_F23_TIME		300
-
 #define W1_F23_READ_EEPROM	0xF0
 #define W1_F23_WRITE_SCRATCH	0x0F
 #define W1_F23_READ_SCRATCH	0xAA
-- 
2.34.1
Re: [PATCH v3 2/5] w1: ds2433: remove unused definition
Posted by Krzysztof Kozlowski 2 years ago
On 30/11/2023 14:52, marc.ferland@gmail.com wrote:
> From: Marc Ferland <marc.ferland@sonatest.com>
> 
> W1_F23_TIME isn't used anywhere, get rid of it.
> 
> Signed-off-by: Marc Ferland <marc.ferland@sonatest.com>
> ---
>  drivers/w1/slaves/w1_ds2433.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/w1/slaves/w1_ds2433.c b/drivers/w1/slaves/w1_ds2433.c
> index 9f21fd98f799..e18523ef8c45 100644
> --- a/drivers/w1/slaves/w1_ds2433.c
> +++ b/drivers/w1/slaves/w1_ds2433.c
> @@ -30,8 +30,6 @@
>  #define W1_PAGE_BITS		5
>  #define W1_PAGE_MASK		0x1F
>  
> -#define W1_F23_TIME		300

Same for W1_PAGE_COUNT and, so is there a point to keep it?

Best regards,
Krzysztof