bpf/tests: Remove duplicate JSGT tests

[PATCH] bpf/tests: Remove duplicate JSGT tests

Posted by Yujie Liu 2 years ago

It seems unnecessary that JSGT is tested twice (one before JSGE and one
after JSGE) since others are tested only once. Remove the duplicate JSGT
tests.

Fixes: 0bbaa02b4816 ("bpf/tests: Add tests to check source register zero-extension")
Signed-off-by: Yujie Liu <yujie.liu@intel.com>
---
 lib/test_bpf.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/test_bpf.c b/lib/test_bpf.c
index 7916503e6a6a..87a4ebcc65be 100644
--- a/lib/test_bpf.c
+++ b/lib/test_bpf.c
@@ -12215,7 +12215,6 @@ static struct bpf_test tests[] = {
 	BPF_JMP32_IMM_ZEXT(JLE),
 	BPF_JMP32_IMM_ZEXT(JSGT),
 	BPF_JMP32_IMM_ZEXT(JSGE),
-	BPF_JMP32_IMM_ZEXT(JSGT),
 	BPF_JMP32_IMM_ZEXT(JSLT),
 	BPF_JMP32_IMM_ZEXT(JSLE),
 #undef BPF_JMP2_IMM_ZEXT
@@ -12251,7 +12250,6 @@ static struct bpf_test tests[] = {
 	BPF_JMP32_REG_ZEXT(JLE),
 	BPF_JMP32_REG_ZEXT(JSGT),
 	BPF_JMP32_REG_ZEXT(JSGE),
-	BPF_JMP32_REG_ZEXT(JSGT),
 	BPF_JMP32_REG_ZEXT(JSLT),
 	BPF_JMP32_REG_ZEXT(JSLE),
 #undef BPF_JMP2_REG_ZEXT
-- 
2.34.1

Re: [PATCH] bpf/tests: Remove duplicate JSGT tests

Posted by patchwork-bot+netdevbpf@kernel.org 2 years ago

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Thu, 30 Nov 2023 11:40:18 +0800 you wrote:
> It seems unnecessary that JSGT is tested twice (one before JSGE and one
> after JSGE) since others are tested only once. Remove the duplicate JSGT
> tests.
> 
> Fixes: 0bbaa02b4816 ("bpf/tests: Add tests to check source register zero-extension")
> Signed-off-by: Yujie Liu <yujie.liu@intel.com>
> 
> [...]

Here is the summary with links:
  - bpf/tests: Remove duplicate JSGT tests
    https://git.kernel.org/bpf/bpf-next/c/f690ff9122d2

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH] bpf/tests: Remove duplicate JSGT tests

Posted by Johan Almbladh 2 years ago

On Thu, Nov 30, 2023 at 4:44 AM Yujie Liu <yujie.liu@intel.com> wrote:
>
> It seems unnecessary that JSGT is tested twice (one before JSGE and one
> after JSGE) since others are tested only once. Remove the duplicate JSGT
> tests.

Looks like a copy-paste typo on my side. Thanks!

Acked-by: Johan Almbladh <johan.almbladh@anyfinetworks.com>

>
> Fixes: 0bbaa02b4816 ("bpf/tests: Add tests to check source register zero-extension")
> Signed-off-by: Yujie Liu <yujie.liu@intel.com>
> ---
>  lib/test_bpf.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/lib/test_bpf.c b/lib/test_bpf.c
> index 7916503e6a6a..87a4ebcc65be 100644
> --- a/lib/test_bpf.c
> +++ b/lib/test_bpf.c
> @@ -12215,7 +12215,6 @@ static struct bpf_test tests[] = {
>         BPF_JMP32_IMM_ZEXT(JLE),
>         BPF_JMP32_IMM_ZEXT(JSGT),
>         BPF_JMP32_IMM_ZEXT(JSGE),
> -       BPF_JMP32_IMM_ZEXT(JSGT),
>         BPF_JMP32_IMM_ZEXT(JSLT),
>         BPF_JMP32_IMM_ZEXT(JSLE),
>  #undef BPF_JMP2_IMM_ZEXT
> @@ -12251,7 +12250,6 @@ static struct bpf_test tests[] = {
>         BPF_JMP32_REG_ZEXT(JLE),
>         BPF_JMP32_REG_ZEXT(JSGT),
>         BPF_JMP32_REG_ZEXT(JSGE),
> -       BPF_JMP32_REG_ZEXT(JSGT),
>         BPF_JMP32_REG_ZEXT(JSLT),
>         BPF_JMP32_REG_ZEXT(JSLE),
>  #undef BPF_JMP2_REG_ZEXT
> --
> 2.34.1
>