Copy-paste error led to help message for metric-no-threshold repeating
that of metric-no-merge.

Reported-by: Stephane Eranian <eranian@google.com>
Fixes: 1fd09e299bdd ("perf metric: Add --metric-no-threshold option")
Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/builtin-stat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index a3af805a1d57..c77a3308d3fb 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -1255,7 +1255,7 @@ static struct option stat_options[] = {
 	OPT_BOOLEAN(0, "metric-no-merge", &stat_config.metric_no_merge,
 		       "don't try to share events between metrics in a group"),
 	OPT_BOOLEAN(0, "metric-no-threshold", &stat_config.metric_no_threshold,
-		       "don't try to share events between metrics in a group  "),
+		       "disable adding events for the metric threshold calculation"),
 	OPT_BOOLEAN(0, "topdown", &topdown_run,
 			"measure top-down statistics"),
 	OPT_UINTEGER(0, "td-level", &stat_config.topdown_level,
-- 
2.43.0.rc1.413.gea7ed67945-goog

On Wed, Nov 29, 2023 at 2:36 PM Ian Rogers <irogers@google.com> wrote:
>
> Copy-paste error led to help message for metric-no-threshold repeating
> that of metric-no-merge.
>
> Reported-by: Stephane Eranian <eranian@google.com>
> Fixes: 1fd09e299bdd ("perf metric: Add --metric-no-threshold option")
> Signed-off-by: Ian Rogers <irogers@google.com>

Ping. Thanks,
Ian

> ---
>  tools/perf/builtin-stat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index a3af805a1d57..c77a3308d3fb 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -1255,7 +1255,7 @@ static struct option stat_options[] = {
>         OPT_BOOLEAN(0, "metric-no-merge", &stat_config.metric_no_merge,
>                        "don't try to share events between metrics in a group"),
>         OPT_BOOLEAN(0, "metric-no-threshold", &stat_config.metric_no_threshold,
> -                      "don't try to share events between metrics in a group  "),
> +                      "disable adding events for the metric threshold calculation"),
>         OPT_BOOLEAN(0, "topdown", &topdown_run,
>                         "measure top-down statistics"),
>         OPT_UINTEGER(0, "td-level", &stat_config.topdown_level,
> --
> 2.43.0.rc1.413.gea7ed67945-goog
>

Em Mon, Dec 11, 2023 at 11:39:02AM -0800, Ian Rogers escreveu:
> On Wed, Nov 29, 2023 at 2:36 PM Ian Rogers <irogers@google.com> wrote:
> >
> > Copy-paste error led to help message for metric-no-threshold repeating
> > that of metric-no-merge.
> >
> > Reported-by: Stephane Eranian <eranian@google.com>
> > Fixes: 1fd09e299bdd ("perf metric: Add --metric-no-threshold option")
> > Signed-off-by: Ian Rogers <irogers@google.com>
> 
> Ping. Thanks,
> Ian

This is in perf-tools-next now.

- Arnaldo
 
> > ---
> >  tools/perf/builtin-stat.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> > index a3af805a1d57..c77a3308d3fb 100644
> > --- a/tools/perf/builtin-stat.c
> > +++ b/tools/perf/builtin-stat.c
> > @@ -1255,7 +1255,7 @@ static struct option stat_options[] = {
> >         OPT_BOOLEAN(0, "metric-no-merge", &stat_config.metric_no_merge,
> >                        "don't try to share events between metrics in a group"),
> >         OPT_BOOLEAN(0, "metric-no-threshold", &stat_config.metric_no_threshold,
> > -                      "don't try to share events between metrics in a group  "),
> > +                      "disable adding events for the metric threshold calculation"),
> >         OPT_BOOLEAN(0, "topdown", &topdown_run,
> >                         "measure top-down statistics"),
> >         OPT_UINTEGER(0, "td-level", &stat_config.topdown_level,
> > --
> > 2.43.0.rc1.413.gea7ed67945-goog
> >

-- 

- Arnaldo

Em Mon, Dec 11, 2023 at 11:39:02AM -0800, Ian Rogers escreveu:
> On Wed, Nov 29, 2023 at 2:36 PM Ian Rogers <irogers@google.com> wrote:
> >
> > Copy-paste error led to help message for metric-no-threshold repeating
> > that of metric-no-merge.
> >
> > Reported-by: Stephane Eranian <eranian@google.com>
> > Fixes: 1fd09e299bdd ("perf metric: Add --metric-no-threshold option")
> > Signed-off-by: Ian Rogers <irogers@google.com>
> 
> Ping. Thanks,

Thanks, applied to perf-tools-next.

- Arnaldo