[PATCH 0/2] Minor grammatical fixup for livepatch docs

Bagas Sanjaya posted 2 patches 2 years ago
Documentation/livepatch/livepatch.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH 0/2] Minor grammatical fixup for livepatch docs
Posted by Bagas Sanjaya 2 years ago
I was prompted to write this little grammar fix series when reading
the fix from Attreyee [1], with review comments requesting changes
to that fix. So here's my version of the fix, with reviews from [1]
addressed (and distinct grammar fixes splitted).

[1]: https://lore.kernel.org/lkml/20231127155758.33070-1-tintinm2017@gmail.com/

Bagas Sanjaya (2):
  Documentation: livepatch: Correct "step on each other's toes" idiom
  Documentation: livepatch: Correct opposite of releasing locks

 Documentation/livepatch/livepatch.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


base-commit: 98b1cc82c4affc16f5598d4fa14b1858671b2263
-- 
An old man doll... just what I always wanted! - Clara
Re: [PATCH 0/2] Minor grammatical fixup for livepatch docs
Posted by Jonathan Corbet 2 years ago
Bagas Sanjaya <bagasdotme@gmail.com> writes:

> I was prompted to write this little grammar fix series when reading
> the fix from Attreyee [1], with review comments requesting changes
> to that fix. So here's my version of the fix, with reviews from [1]
> addressed (and distinct grammar fixes splitted).

How is this helpful?  Why are you trying to push aside somebody who is
working toward a first contribution to the kernel?  This is not the way
to help somebody learn to work with the kernel community.

Attreyee, I would like to encourage you to redo your patch set based on
the feedback you have received so that we can apply it.

Thanks,

jon
Re: [PATCH 0/2] Minor grammatical fixup for livepatch docs
Posted by Matthew Wilcox 2 years ago
On Wed, Nov 29, 2023 at 07:29:35AM -0700, Jonathan Corbet wrote:
> Bagas Sanjaya <bagasdotme@gmail.com> writes:
> 
> > I was prompted to write this little grammar fix series when reading
> > the fix from Attreyee [1], with review comments requesting changes
> > to that fix. So here's my version of the fix, with reviews from [1]
> > addressed (and distinct grammar fixes splitted).
> 
> How is this helpful?  Why are you trying to push aside somebody who is
> working toward a first contribution to the kernel?  This is not the way
> to help somebody learn to work with the kernel community.

This is not the first such "contribution" from Bagas recently.

https://lore.kernel.org/linux-doc/20231121095658.28254-1-bagasdotme@gmail.com/

was as a result of
https://lore.kernel.org/linux-xfs/87r0klg8wl.fsf@debian-BULLSEYE-live-builder-AMD64/

I didn't say anything at the time, but clearly I should have squelched
this bad behaviour by Bagas before he did it to a newbie.

Bagas, find your own project to work on.  Don't steal glory from others.
Re: [PATCH 0/2] Minor grammatical fixup for livepatch docs
Posted by Bagas Sanjaya 2 years ago
On Wed, Nov 29, 2023 at 03:26:18PM +0000, Matthew Wilcox wrote:
> On Wed, Nov 29, 2023 at 07:29:35AM -0700, Jonathan Corbet wrote:
> > Bagas Sanjaya <bagasdotme@gmail.com> writes:
> > 
> > > I was prompted to write this little grammar fix series when reading
> > > the fix from Attreyee [1], with review comments requesting changes
> > > to that fix. So here's my version of the fix, with reviews from [1]
> > > addressed (and distinct grammar fixes splitted).
> > 
> > How is this helpful?  Why are you trying to push aside somebody who is
> > working toward a first contribution to the kernel?  This is not the way
> > to help somebody learn to work with the kernel community.
> 
> This is not the first such "contribution" from Bagas recently.
> 
> https://lore.kernel.org/linux-doc/20231121095658.28254-1-bagasdotme@gmail.com/
> 
> was as a result of
> https://lore.kernel.org/linux-xfs/87r0klg8wl.fsf@debian-BULLSEYE-live-builder-AMD64/
> 
> I didn't say anything at the time, but clearly I should have squelched
> this bad behaviour by Bagas before he did it to a newbie.
> 
> Bagas, find your own project to work on.  Don't steal glory from others.

OK, thanks! I was in 'gabut mode' then...

-- 
An old man doll... just what I always wanted! - Clara
Re: [PATCH 0/2] Minor grammatical fixup for livepatch docs
Posted by Joe Lawrence 2 years ago
On 11/29/23 08:25, Bagas Sanjaya wrote:
> I was prompted to write this little grammar fix series when reading
> the fix from Attreyee [1], with review comments requesting changes
> to that fix. So here's my version of the fix, with reviews from [1]
> addressed (and distinct grammar fixes splitted).
> 

Typical kernel workflow would be for Attreyee to incorporate feedback
and post their v2 after a day or two.  From the format they posted, it
appears to be a first(ish) kernel contribution post.  Let's be kind and
patient so they we all may benefit from the practice of iterating on
their patch.

-- 
Joe
Re: [PATCH 0/2] Minor grammatical fixup for livepatch docs
Posted by Bagas Sanjaya 2 years ago
On 11/29/23 20:53, Joe Lawrence wrote:
> On 11/29/23 08:25, Bagas Sanjaya wrote:
>> I was prompted to write this little grammar fix series when reading
>> the fix from Attreyee [1], with review comments requesting changes
>> to that fix. So here's my version of the fix, with reviews from [1]
>> addressed (and distinct grammar fixes splitted).
>>
> 
> Typical kernel workflow would be for Attreyee to incorporate feedback
> and post their v2 after a day or two.  From the format they posted, it
> appears to be a first(ish) kernel contribution post.  Let's be kind and
> patient so they we all may benefit from the practice of iterating on
> their patch.
> 

I do this posting because I thought the OP (Attreyee) didn't respond in
timely manner (just like random Chinese contributors like @cdjrlc.com
and @208suo.com people).

Thanks.

-- 
An old man doll... just what I always wanted! - Clara
Re: [PATCH 0/2] Minor grammatical fixup for livepatch docs
Posted by Matthew Wilcox 2 years ago
On Thu, Nov 30, 2023 at 06:58:16AM +0700, Bagas Sanjaya wrote:
> I do this posting because I thought the OP (Attreyee) didn't respond in
> timely manner (just like random Chinese contributors like @cdjrlc.com
> and @208suo.com people).

That's a ridiculous excuse.  The original posting was two days ago!
If it had been a week since we last heard from Attreyee, I'd understand.
Re: [PATCH 0/2] Minor grammatical fixup for livepatch docs
Posted by Bagas Sanjaya 2 years ago
On Thu, Nov 30, 2023 at 12:08:33AM +0000, Matthew Wilcox wrote:
> On Thu, Nov 30, 2023 at 06:58:16AM +0700, Bagas Sanjaya wrote:
> > I do this posting because I thought the OP (Attreyee) didn't respond in
> > timely manner (just like random Chinese contributors like @cdjrlc.com
> > and @208suo.com people).
> 
> That's a ridiculous excuse.  The original posting was two days ago!
> If it had been a week since we last heard from Attreyee, I'd understand.

OK, thanks!

-- 
An old man doll... just what I always wanted! - Clara
Re: [PATCH 0/2] Minor grammatical fixup for livepatch docs
Posted by Jonathan Corbet 2 years ago
Bagas Sanjaya <bagasdotme@gmail.com> writes:

> On 11/29/23 20:53, Joe Lawrence wrote:
>> On 11/29/23 08:25, Bagas Sanjaya wrote:
>>> I was prompted to write this little grammar fix series when reading
>>> the fix from Attreyee [1], with review comments requesting changes
>>> to that fix. So here's my version of the fix, with reviews from [1]
>>> addressed (and distinct grammar fixes splitted).
>>>
>> 
>> Typical kernel workflow would be for Attreyee to incorporate feedback
>> and post their v2 after a day or two.  From the format they posted, it
>> appears to be a first(ish) kernel contribution post.  Let's be kind and
>> patient so they we all may benefit from the practice of iterating on
>> their patch.
>> 
>
> I do this posting because I thought the OP (Attreyee) didn't respond in
> timely manner (just like random Chinese contributors like @cdjrlc.com
> and @208suo.com people).

Seriously?  The original post was on Monday, yours came less than 48
hours later.  Not only can we not expect that kind of rapid turnaround
from anybody, but we actively discourage rapid resending of patches.
Rather than dig yourself in deeper, I suggest you simply apologize to
the original poster and find something more useful to do.

Thanks,

jon
Re: [PATCH 0/2] Minor grammatical fixup for livepatch docs
Posted by Bagas Sanjaya 2 years ago
On Wed, Nov 29, 2023 at 05:10:25PM -0700, Jonathan Corbet wrote:
> Bagas Sanjaya <bagasdotme@gmail.com> writes:
> 
> > On 11/29/23 20:53, Joe Lawrence wrote:
> >> On 11/29/23 08:25, Bagas Sanjaya wrote:
> >>> I was prompted to write this little grammar fix series when reading
> >>> the fix from Attreyee [1], with review comments requesting changes
> >>> to that fix. So here's my version of the fix, with reviews from [1]
> >>> addressed (and distinct grammar fixes splitted).
> >>>
> >> 
> >> Typical kernel workflow would be for Attreyee to incorporate feedback
> >> and post their v2 after a day or two.  From the format they posted, it
> >> appears to be a first(ish) kernel contribution post.  Let's be kind and
> >> patient so they we all may benefit from the practice of iterating on
> >> their patch.
> >> 
> >
> > I do this posting because I thought the OP (Attreyee) didn't respond in
> > timely manner (just like random Chinese contributors like @cdjrlc.com
> > and @208suo.com people).
> 
> Seriously?  The original post was on Monday, yours came less than 48
> hours later.  Not only can we not expect that kind of rapid turnaround
> from anybody, but we actively discourage rapid resending of patches.
> Rather than dig yourself in deeper, I suggest you simply apologize to
> the original poster and find something more useful to do.

Done, thanks!

And yes, I'm also focusing on regression tracking and Bugzilla
triaging.

Ciao, Bagas.

-- 
An old man doll... just what I always wanted! - Clara