[PATCH net-next v7 3/3] net: dsa: microchip: make phylink_mac_link_up() not optional

Oleksij Rempel posted 3 patches 2 years ago
[PATCH net-next v7 3/3] net: dsa: microchip: make phylink_mac_link_up() not optional
Posted by Oleksij Rempel 2 years ago
Last part of the driver do now support phylink_mac_link_up(). So, make it
not optional.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 drivers/net/dsa/microchip/ksz_common.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
index 3b1fe9aff6a8..9545aed905f5 100644
--- a/drivers/net/dsa/microchip/ksz_common.c
+++ b/drivers/net/dsa/microchip/ksz_common.c
@@ -3113,10 +3113,8 @@ static void ksz_phylink_mac_link_up(struct dsa_switch *ds, int port,
 {
 	struct ksz_device *dev = ds->priv;
 
-	if (dev->dev_ops->phylink_mac_link_up)
-		dev->dev_ops->phylink_mac_link_up(dev, port, mode, interface,
-						  phydev, speed, duplex,
-						  tx_pause, rx_pause);
+	dev->dev_ops->phylink_mac_link_up(dev, port, mode, interface, phydev,
+					  speed, duplex, tx_pause, rx_pause);
 }
 
 static int ksz_switch_detect(struct ksz_device *dev)
-- 
2.39.2
Re: [PATCH net-next v7 3/3] net: dsa: microchip: make phylink_mac_link_up() not optional
Posted by Florian Fainelli 2 years ago
On 11/27/23 06:51, Oleksij Rempel wrote:
> Last part of the driver do now support phylink_mac_link_up(). So, make it
> not optional.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian