[PATCH] tools cpupower bench: Override CFLAGS assignments

Stanley Chan posted 1 patch 2 years, 1 month ago
There is a newer version of this series
tools/power/cpupower/bench/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] tools cpupower bench: Override CFLAGS assignments
Posted by Stanley Chan 2 years, 1 month ago
Allow user to specify outside CFLAGS values as make argument

Corrects an issue where CFLAGS is passed as a make argument for
cpupower, but bench's makefile does not inherit and append to them.

see also:
commit dbc4ca339c8d ("tools cpupower: Override CFLAGS assignments")

Signed-off-by: Stanley Chan <schan@cloudflare.com>
---
 tools/power/cpupower/bench/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/power/cpupower/bench/Makefile b/tools/power/cpupower/bench/Makefile
index d9d9923af85c..a4b902f9e1c4 100644
--- a/tools/power/cpupower/bench/Makefile
+++ b/tools/power/cpupower/bench/Makefile
@@ -15,7 +15,7 @@ LIBS = -L../ -L$(OUTPUT) -lm -lcpupower
 OBJS = $(OUTPUT)main.o $(OUTPUT)parse.o $(OUTPUT)system.o $(OUTPUT)benchmark.o
 endif
 
-CFLAGS += -D_GNU_SOURCE -I../lib -DDEFAULT_CONFIG_FILE=\"$(confdir)/cpufreq-bench.conf\"
+override CFLAGS += -D_GNU_SOURCE -I../lib -DDEFAULT_CONFIG_FILE=\"$(confdir)/cpufreq-bench.conf\"
 
 $(OUTPUT)%.o : %.c
 	$(ECHO) "  CC      " $@
-- 
2.34.1
Re: [PATCH] tools cpupower bench: Override CFLAGS assignments
Posted by Stanley Chan 2 years, 1 month ago
Apologies, this is my first patch so I'm still learning.
Meant to add

Fixes: dbc4ca339c8d ("tools cpupower: Override CFLAGS assignments")

---
Stan
Re: [PATCH] tools cpupower bench: Override CFLAGS assignments
Posted by Shuah Khan 2 years, 1 month ago
On 11/24/23 11:59, Stanley Chan wrote:
> Apologies, this is my first patch so I'm still learning.
> Meant to add
> 
> Fixes: dbc4ca339c8d ("tools cpupower: Override CFLAGS assignments")
> 


Thank you for the fix. Please send me v2 with this fixes tag.

thanks,
-- Shuah