[PATCH v6 1/8] tpm: Remove unused tpm_buf_tag()

Jarkko Sakkinen posted 8 patches 2 years ago
[PATCH v6 1/8] tpm: Remove unused tpm_buf_tag()
Posted by Jarkko Sakkinen 2 years ago
The helper function has no call sites. Thus, remove it.

Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
---
v1 [2023-11-21]: A new patch.
---
 include/linux/tpm.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/include/linux/tpm.h b/include/linux/tpm.h
index 4ee9d13749ad..6588ca87cf93 100644
--- a/include/linux/tpm.h
+++ b/include/linux/tpm.h
@@ -358,13 +358,6 @@ static inline u32 tpm_buf_length(struct tpm_buf *buf)
 	return be32_to_cpu(head->length);
 }
 
-static inline u16 tpm_buf_tag(struct tpm_buf *buf)
-{
-	struct tpm_header *head = (struct tpm_header *)buf->data;
-
-	return be16_to_cpu(head->tag);
-}
-
 static inline void tpm_buf_append(struct tpm_buf *buf,
 				  const unsigned char *new_data,
 				  unsigned int new_len)
-- 
2.43.0
Re: [PATCH v6 1/8] tpm: Remove unused tpm_buf_tag()
Posted by Stefan Berger 2 years ago

On 11/23/23 21:02, Jarkko Sakkinen wrote:
> The helper function has no call sites. Thus, remove it.
> 
> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>

> ---
> v1 [2023-11-21]: A new patch.
> ---
>   include/linux/tpm.h | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/include/linux/tpm.h b/include/linux/tpm.h
> index 4ee9d13749ad..6588ca87cf93 100644
> --- a/include/linux/tpm.h
> +++ b/include/linux/tpm.h
> @@ -358,13 +358,6 @@ static inline u32 tpm_buf_length(struct tpm_buf *buf)
>   	return be32_to_cpu(head->length);
>   }
>   
> -static inline u16 tpm_buf_tag(struct tpm_buf *buf)
> -{
> -	struct tpm_header *head = (struct tpm_header *)buf->data;
> -
> -	return be16_to_cpu(head->tag);
> -}
> -
>   static inline void tpm_buf_append(struct tpm_buf *buf,
>   				  const unsigned char *new_data,
>   				  unsigned int new_len)