Hi, This patch series renames 5 different variables from Pascal/CamelCase to snake case. Linux kernel coding style (cleanup), checkpatch Avoid CamelCase. Driver/module rtl8291e compiles. Patch 1/5) renamed variable from HTMcsToDataRate -> ht_mcs_to_data_rate Patch 2/5) renamed variable from TXCountToDAtaRate -> tx-count_to_data_rate Patch 3/5) renamed variable from IsHTHalfNmodeAPs -> is_ht_half_nmode_aps Patch 4/5) renamed variable from HTIOTPeerDetermine -> ht_iot_peer_determine Patch 5/5) renamed variable from HTIOTActIsMgntUseCCK6M -> ht_iot_act_is_mgnt_use_cck_6m Regards, Gary -- 2.41.0
On 11/21/23 19:14, Gary Rookard wrote: > Hi, > > This patch series renames 5 different variables from > Pascal/CamelCase to snake case. > > Linux kernel coding style (cleanup), checkpatch Avoid CamelCase. > Driver/module rtl8291e compiles. > > Patch 1/5) renamed variable from HTMcsToDataRate -> ht_mcs_to_data_rate > Patch 2/5) renamed variable from TXCountToDAtaRate -> tx-count_to_data_rate > Patch 3/5) renamed variable from IsHTHalfNmodeAPs -> is_ht_half_nmode_aps > Patch 4/5) renamed variable from HTIOTPeerDetermine -> ht_iot_peer_determine > Patch 5/5) renamed variable from HTIOTActIsMgntUseCCK6M -> ht_iot_act_is_mgnt_use_cck_6m > > Regards, > Gary > Hi Gary, this patch series needs to be a V2 with change history. The next patch series you are going to send is V3. The cover letter of your patch series seems to be hand made. You can use git to do this. I am using this command to do this: git format-patch -o ~/Documents/kernel/patches/ --cover-letter -n --thread=shallow --to="Greg Kroah-Hartman <gregkh@linuxfoundation.org>,linux-staging@lists.linux.dev,linux-kernel@vger.kernel.org" 7b88c62d3cc5c3fb670b5448c7381c7c099b3518^..HEAD There are now 31 patches pending for this driver. May be it is a good idea to wait until those are accepted or rejected. May be this is happening on Thursday morning. Or you apply the patches before you put yours on top: https://lore.kernel.org/linux-staging/c464f4a8-753b-417c-97bb-7aa29ab5bf59@gmail.com/T/#t https://lore.kernel.org/linux-staging/cover.1700296319.git.philipp.g.hortmann@gmail.com/T/#t https://lore.kernel.org/linux-staging/d911d509-8677-444c-ad7f-92dd141e8e1e@suswa.mountain/T/#t In case of question feel free to write to me. Bye Philipp
On Tue, Nov 21, 2023 at 01:14:30PM -0500, Gary Rookard wrote: > Hi, > > This patch series renames 5 different variables from > Pascal/CamelCase to snake case. > > Linux kernel coding style (cleanup), checkpatch Avoid CamelCase. > Driver/module rtl8291e compiles. > > Patch 1/5) renamed variable from HTMcsToDataRate -> ht_mcs_to_data_rate > Patch 2/5) renamed variable from TXCountToDAtaRate -> tx-count_to_data_rate > Patch 3/5) renamed variable from IsHTHalfNmodeAPs -> is_ht_half_nmode_aps > Patch 4/5) renamed variable from HTIOTPeerDetermine -> ht_iot_peer_determine > Patch 5/5) renamed variable from HTIOTActIsMgntUseCCK6M -> ht_iot_act_is_mgnt_use_cck_6m > > Regards, > Gary Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
© 2016 - 2025 Red Hat, Inc.