riscv: compat_vdso: align VDSOAS build log

[PATCH] riscv: compat_vdso: align VDSOAS build log

Posted by Masahiro Yamada 2 years, 1 month ago

Add one more space after "VDSOAS" for better alignment in the build log.

[Before]

  LDS     arch/riscv/kernel/compat_vdso/compat_vdso.lds
  VDSOAS arch/riscv/kernel/compat_vdso/rt_sigreturn.o
  VDSOAS arch/riscv/kernel/compat_vdso/getcpu.o
  VDSOAS arch/riscv/kernel/compat_vdso/flush_icache.o
  VDSOAS arch/riscv/kernel/compat_vdso/note.o
  VDSOLD  arch/riscv/kernel/compat_vdso/compat_vdso.so.dbg
  VDSOSYM include/generated/compat_vdso-offsets.h

[After]

  LDS     arch/riscv/kernel/compat_vdso/compat_vdso.lds
  VDSOAS  arch/riscv/kernel/compat_vdso/rt_sigreturn.o
  VDSOAS  arch/riscv/kernel/compat_vdso/getcpu.o
  VDSOAS  arch/riscv/kernel/compat_vdso/flush_icache.o
  VDSOAS  arch/riscv/kernel/compat_vdso/note.o
  VDSOLD  arch/riscv/kernel/compat_vdso/compat_vdso.so.dbg
  VDSOSYM include/generated/compat_vdso-offsets.h

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 arch/riscv/kernel/compat_vdso/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/kernel/compat_vdso/Makefile b/arch/riscv/kernel/compat_vdso/Makefile
index 62fa393b2eb2..3df4cb788c1f 100644
--- a/arch/riscv/kernel/compat_vdso/Makefile
+++ b/arch/riscv/kernel/compat_vdso/Makefile
@@ -74,5 +74,5 @@ quiet_cmd_compat_vdsold = VDSOLD  $@
                    rm $@.tmp
 
 # actual build commands
-quiet_cmd_compat_vdsoas = VDSOAS $@
+quiet_cmd_compat_vdsoas = VDSOAS  $@
       cmd_compat_vdsoas = $(COMPAT_CC) $(a_flags) $(COMPAT_CC_FLAGS) -c -o $@ $<
-- 
2.40.1

Re: [PATCH] riscv: compat_vdso: align VDSOAS build log

Posted by Alexandre Ghiti 1 year, 9 months ago

Hi Masahiro,

On 17/11/2023 13:58, Masahiro Yamada wrote:
> Add one more space after "VDSOAS" for better alignment in the build log.
>
> [Before]
>
>    LDS     arch/riscv/kernel/compat_vdso/compat_vdso.lds
>    VDSOAS arch/riscv/kernel/compat_vdso/rt_sigreturn.o
>    VDSOAS arch/riscv/kernel/compat_vdso/getcpu.o
>    VDSOAS arch/riscv/kernel/compat_vdso/flush_icache.o
>    VDSOAS arch/riscv/kernel/compat_vdso/note.o
>    VDSOLD  arch/riscv/kernel/compat_vdso/compat_vdso.so.dbg
>    VDSOSYM include/generated/compat_vdso-offsets.h
>
> [After]
>
>    LDS     arch/riscv/kernel/compat_vdso/compat_vdso.lds
>    VDSOAS  arch/riscv/kernel/compat_vdso/rt_sigreturn.o
>    VDSOAS  arch/riscv/kernel/compat_vdso/getcpu.o
>    VDSOAS  arch/riscv/kernel/compat_vdso/flush_icache.o
>    VDSOAS  arch/riscv/kernel/compat_vdso/note.o
>    VDSOLD  arch/riscv/kernel/compat_vdso/compat_vdso.so.dbg
>    VDSOSYM include/generated/compat_vdso-offsets.h
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
>   arch/riscv/kernel/compat_vdso/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/compat_vdso/Makefile b/arch/riscv/kernel/compat_vdso/Makefile
> index 62fa393b2eb2..3df4cb788c1f 100644
> --- a/arch/riscv/kernel/compat_vdso/Makefile
> +++ b/arch/riscv/kernel/compat_vdso/Makefile
> @@ -74,5 +74,5 @@ quiet_cmd_compat_vdsold = VDSOLD  $@
>                      rm $@.tmp
>   
>   # actual build commands
> -quiet_cmd_compat_vdsoas = VDSOAS $@
> +quiet_cmd_compat_vdsoas = VDSOAS  $@
>         cmd_compat_vdsoas = $(COMPAT_CC) $(a_flags) $(COMPAT_CC_FLAGS) -c -o $@ $<


Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>

Thanks,

Alex