fix null-ptr-deref in nbd_open()

[PATCH 0/3] fix null-ptr-deref in nbd_open()

Posted by linan666@huaweicloud.com 2 years, 1 month ago

From: Li Nan <linan122@huawei.com>

Li Nan (3):
  nbd: fold nbd config initialization into nbd_alloc_config()
  nbd: factor out a helper to get nbd_config without holding
    'config_lock'
  nbd: fix null-ptr-dereference while accessing 'nbd->config'

 drivers/block/nbd.c | 82 +++++++++++++++++++++++++++++----------------
 1 file changed, 53 insertions(+), 29 deletions(-)

-- 
2.39.2

Re: [PATCH 0/3] fix null-ptr-deref in nbd_open()

Posted by Jens Axboe 2 years, 1 month ago

On Fri, 17 Nov 2023 00:23:13 +0800, linan666@huaweicloud.com wrote:
> Li Nan (3):
>   nbd: fold nbd config initialization into nbd_alloc_config()
>   nbd: factor out a helper to get nbd_config without holding
>     'config_lock'
>   nbd: fix null-ptr-dereference while accessing 'nbd->config'
> 
> drivers/block/nbd.c | 82 +++++++++++++++++++++++++++++----------------
>  1 file changed, 53 insertions(+), 29 deletions(-)
> 
> [...]

Applied, thanks!

[1/3] nbd: fold nbd config initialization into nbd_alloc_config()
      commit: 1b59860540a4018e8071dc18d4893ec389506b7d
[2/3] nbd: factor out a helper to get nbd_config without holding 'config_lock'
      commit: 3123ac77923341774ca3ad1196ad20bb0732bf70
[3/3] nbd: fix null-ptr-dereference while accessing 'nbd->config'
      commit: c2da049f419417808466c529999170f5c3ef7d3d

Best regards,
-- 
Jens Axboe

Re: [PATCH 0/3] fix null-ptr-deref in nbd_open()

Posted by Josef Bacik 2 years, 1 month ago

On Fri, Nov 17, 2023 at 12:23:13AM +0800, linan666@huaweicloud.com wrote:
> From: Li Nan <linan122@huawei.com>
> 
> Li Nan (3):
>   nbd: fold nbd config initialization into nbd_alloc_config()
>   nbd: factor out a helper to get nbd_config without holding
>     'config_lock'
>   nbd: fix null-ptr-dereference while accessing 'nbd->config'
> 
>  drivers/block/nbd.c | 82 +++++++++++++++++++++++++++++----------------
>  1 file changed, 53 insertions(+), 29 deletions(-)
> 
> -- 
> 2.39.2
> 

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef