[PATCH v2 00/12] Introduce ExynosAutov920 SoC and SADK board

Jaewon Kim posted 12 patches 2 years, 1 month ago
There is a newer version of this series
.../bindings/arm/samsung/samsung-boards.yaml  |    6 +
.../hwinfo/samsung,exynos-chipid.yaml         |    1 +
.../samsung,pinctrl-wakeup-interrupt.yaml     |    2 +
.../bindings/pinctrl/samsung,pinctrl.yaml     |    1 +
.../devicetree/bindings/pwm/pwm-samsung.yaml  |    1 +
.../bindings/serial/samsung_uart.yaml         |    4 +-
.../bindings/soc/samsung/exynos-pmu.yaml      |    1 +
.../bindings/soc/samsung/exynos-usi.yaml      |    4 +-
.../soc/samsung/samsung,exynos-sysreg.yaml    |    5 +
arch/arm64/boot/dts/exynos/Makefile           |    3 +-
.../dts/exynos/exynosautov920-pinctrl.dtsi    | 1266 +++++++++++++++++
.../boot/dts/exynos/exynosautov920-sadk.dts   |   88 ++
.../arm64/boot/dts/exynos/exynosautov920.dtsi |  312 ++++
.../pinctrl/samsung/pinctrl-exynos-arm64.c    |  140 ++
drivers/pinctrl/samsung/pinctrl-exynos.c      |  102 +-
drivers/pinctrl/samsung/pinctrl-exynos.h      |   27 +
drivers/pinctrl/samsung/pinctrl-samsung.c     |    5 +
drivers/pinctrl/samsung/pinctrl-samsung.h     |   13 +
drivers/soc/samsung/exynos-chipid.c           |    1 +
19 files changed, 1972 insertions(+), 10 deletions(-)
create mode 100644 arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi
create mode 100644 arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
create mode 100644 arch/arm64/boot/dts/exynos/exynosautov920.dtsi
[PATCH v2 00/12] Introduce ExynosAutov920 SoC and SADK board
Posted by Jaewon Kim 2 years, 1 month ago
ExynosAutov920[1] is ARMv8-based automotive-oriented SoC.
This SoC is the next generation of exynosautov9 and AE(Automotive Enhanced)
IPs are used for safety.

This patchset is the minimal set for ExynosAutov920 SoC and SADK board.
Currently, ramdisk console is available and Clock, UFS, and USI will be
added after this patchset.

[1] : https://semiconductor.samsung.com/processor/automotive-processor/exynos-auto-v920

---
Changes in v2:
 - Rebase to git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git
             branch : for-v6.8/samsung-bindings-compatibles
 - Specific exynosautov920 compatible
 - Add dt-binding patch for pmu, chipid

Jaewon Kim (12):
  dt-bindings: soc: samsung: exynos-sysreg: add exynosautov920 sysreg
  dt-bindings: soc: samsung: exynos-pmu: add exynosautov920 compatible
  dt-bindings: soc: samsung: usi: add exynosautov920-usi compatible
  dt-bindings: serial: samsung: add exynosautov920-uart compatible
  dt-bindings: pwm: samsung: add exynosautov920 compatible
  dt-bindings: pinctrl: samsung: add exynosautov920 binding
  dt-bindings: arm: samsung: Document exynosautov920 SADK board binding
  dt-bindings: hwinfo: samsung,exynos-chipid: add exynosautov920
    compatible
  soc: samsung: exynos-chipid: add exynosautov920 SoC support
  pinctrl: samsung: add exynosautov920 pinctrl
  arm64: dts: exynos: add initial support for exynosautov920 SoC
  arm64: dts: exynos: add minimal support for exynosautov920 sadk board

 .../bindings/arm/samsung/samsung-boards.yaml  |    6 +
 .../hwinfo/samsung,exynos-chipid.yaml         |    1 +
 .../samsung,pinctrl-wakeup-interrupt.yaml     |    2 +
 .../bindings/pinctrl/samsung,pinctrl.yaml     |    1 +
 .../devicetree/bindings/pwm/pwm-samsung.yaml  |    1 +
 .../bindings/serial/samsung_uart.yaml         |    4 +-
 .../bindings/soc/samsung/exynos-pmu.yaml      |    1 +
 .../bindings/soc/samsung/exynos-usi.yaml      |    4 +-
 .../soc/samsung/samsung,exynos-sysreg.yaml    |    5 +
 arch/arm64/boot/dts/exynos/Makefile           |    3 +-
 .../dts/exynos/exynosautov920-pinctrl.dtsi    | 1266 +++++++++++++++++
 .../boot/dts/exynos/exynosautov920-sadk.dts   |   88 ++
 .../arm64/boot/dts/exynos/exynosautov920.dtsi |  312 ++++
 .../pinctrl/samsung/pinctrl-exynos-arm64.c    |  140 ++
 drivers/pinctrl/samsung/pinctrl-exynos.c      |  102 +-
 drivers/pinctrl/samsung/pinctrl-exynos.h      |   27 +
 drivers/pinctrl/samsung/pinctrl-samsung.c     |    5 +
 drivers/pinctrl/samsung/pinctrl-samsung.h     |   13 +
 drivers/soc/samsung/exynos-chipid.c           |    1 +
 19 files changed, 1972 insertions(+), 10 deletions(-)
 create mode 100644 arch/arm64/boot/dts/exynos/exynosautov920-pinctrl.dtsi
 create mode 100644 arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
 create mode 100644 arch/arm64/boot/dts/exynos/exynosautov920.dtsi

-- 
2.42.0
Re: [PATCH v2 00/12] Introduce ExynosAutov920 SoC and SADK board
Posted by Krzysztof Kozlowski 2 years, 1 month ago
On Wed, 15 Nov 2023 18:55:56 +0900, Jaewon Kim wrote:
> ExynosAutov920[1] is ARMv8-based automotive-oriented SoC.
> This SoC is the next generation of exynosautov9 and AE(Automotive Enhanced)
> IPs are used for safety.
> 
> This patchset is the minimal set for ExynosAutov920 SoC and SADK board.
> Currently, ramdisk console is available and Clock, UFS, and USI will be
> added after this patchset.
> 
> [...]

Applied, thanks!

[01/12] dt-bindings: soc: samsung: exynos-sysreg: add exynosautov920 sysreg
        https://git.kernel.org/krzk/linux/c/20862a23260a3ab76ea5b425f93967d0683b28a2
[02/12] dt-bindings: soc: samsung: exynos-pmu: add exynosautov920 compatible
        https://git.kernel.org/krzk/linux/c/705672285530cd513b5549f96f92b2a9fcd63017
[03/12] dt-bindings: soc: samsung: usi: add exynosautov920-usi compatible
        https://git.kernel.org/krzk/linux/c/7a5e832d05025a3679d0fcd60584e6e946a3e358
[04/12] dt-bindings: serial: samsung: add exynosautov920-uart compatible
        https://git.kernel.org/krzk/linux/c/9433b8d8d35bd0b17d6e0df76ec135dd2fe63e7c
[05/12] dt-bindings: pwm: samsung: add exynosautov920 compatible
        https://git.kernel.org/krzk/linux/c/d2d9e80a0ba6b1f507c14d6d8e2b833a474744d3
[06/12] <DIFFERENT TREE>
[07/12] dt-bindings: arm: samsung: Document exynosautov920 SADK board binding
        https://git.kernel.org/krzk/linux/c/8bd05d4a86d5e1cec35dc7b8d1a5c0d925ecde1e
[08/12] dt-bindings: hwinfo: samsung,exynos-chipid: add exynosautov920 compatible
        https://git.kernel.org/krzk/linux/c/92b022550ae55527b4ce8f8cae7863857c7b795a
[09/12] soc: samsung: exynos-chipid: add exynosautov920 SoC support
        https://git.kernel.org/krzk/linux/c/beea67c7c2ef161c6ee7ef4e39d842fc0be3995c
[10/12] <NOT APPLIED>
[11/12] arm64: dts: exynos: add initial support for exynosautov920 SoC
        https://git.kernel.org/krzk/linux/c/1a035f71803af961fa72264d22716b5b5b85fdc1
[12/12] arm64: dts: exynos: add minimal support for exynosautov920 sadk board
        https://git.kernel.org/krzk/linux/c/a0282075cf5e6abc6d8cae89c1d5fedeb8f32c49

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Re: [PATCH v2 00/12] Introduce ExynosAutov920 SoC and SADK board
Posted by Krzysztof Kozlowski 2 years, 1 month ago
On 15/11/2023 14:08, Krzysztof Kozlowski wrote:
> 
> On Wed, 15 Nov 2023 18:55:56 +0900, Jaewon Kim wrote:
>> ExynosAutov920[1] is ARMv8-based automotive-oriented SoC.
>> This SoC is the next generation of exynosautov9 and AE(Automotive Enhanced)
>> IPs are used for safety.
>>
>> This patchset is the minimal set for ExynosAutov920 SoC and SADK board.
>> Currently, ramdisk console is available and Clock, UFS, and USI will be
>> added after this patchset.
>>
>> [...]
> 
> Applied, thanks!
> 

And dropped. You did not test it. Please read Samsung SoC maintainer
profile:
https://www.kernel.org/doc/html/latest/process/maintainers.html#arm-samsung-s3c-s5p-and-exynos-arm-architectures

I also made announcements on the lists and on social.kernel.org. I don't
know where to announce it more...

Best regards,
Krzysztof
Re: [PATCH v2 00/12] Introduce ExynosAutov920 SoC and SADK board
Posted by Krzysztof Kozlowski 2 years, 1 month ago
On 15/11/2023 22:11, Krzysztof Kozlowski wrote:
> On 15/11/2023 14:08, Krzysztof Kozlowski wrote:
>>
>> On Wed, 15 Nov 2023 18:55:56 +0900, Jaewon Kim wrote:
>>> ExynosAutov920[1] is ARMv8-based automotive-oriented SoC.
>>> This SoC is the next generation of exynosautov9 and AE(Automotive Enhanced)
>>> IPs are used for safety.
>>>
>>> This patchset is the minimal set for ExynosAutov920 SoC and SADK board.
>>> Currently, ramdisk console is available and Clock, UFS, and USI will be
>>> added after this patchset.
>>>
>>> [...]
>>
>> Applied, thanks!
>>
> 
> And dropped. You did not test it. Please read Samsung SoC maintainer
> profile:
> https://www.kernel.org/doc/html/latest/process/maintainers.html#arm-samsung-s3c-s5p-and-exynos-arm-architectures
> 
> I also made announcements on the lists and on social.kernel.org. I don't
> know where to announce it more...
> 

To clarify, I dropped only DTS and kept bindings. Let me know if
bindings are problematic here...

I also repeated the announcement:
https://social.kernel.org/notice/AbqJkj9gOZJ3sG8eCu
Please share internally within Samsung, so there will be no surprises.

Best regards,
Krzysztof
Re: [PATCH v2 00/12] Introduce ExynosAutov920 SoC and SADK board
Posted by Jaewon Kim 2 years, 1 month ago
On 23. 11. 16. 06:17, Krzysztof Kozlowski wrote:
> On 15/11/2023 22:11, Krzysztof Kozlowski wrote:
>> On 15/11/2023 14:08, Krzysztof Kozlowski wrote:
>>> On Wed, 15 Nov 2023 18:55:56 +0900, Jaewon Kim wrote:
>>>> ExynosAutov920[1] is ARMv8-based automotive-oriented SoC.
>>>> This SoC is the next generation of exynosautov9 and AE(Automotive Enhanced)
>>>> IPs are used for safety.
>>>>
>>>> This patchset is the minimal set for ExynosAutov920 SoC and SADK board.
>>>> Currently, ramdisk console is available and Clock, UFS, and USI will be
>>>> added after this patchset.
>>>>
>>>> [...]
>>> Applied, thanks!
>>>
>> And dropped. You did not test it. Please read Samsung SoC maintainer
>> profile:
>> https://www.kernel.org/doc/html/latest/process/maintainers.html#arm-samsung-s3c-s5p-and-exynos-arm-architectures
>>
>> I also made announcements on the lists and on social.kernel.org. I don't
>> know where to announce it more...
>>
> To clarify, I dropped only DTS and kept bindings. Let me know if
> bindings are problematic here...
>
> I also repeated the announcement:
> https://social.kernel.org/notice/AbqJkj9gOZJ3sG8eCu
> Please share internally within Samsung, so there will be no surprises.
>
> Best regards,
> Krzysztof
>
>

I already checked and there were no warnings or errors as shown below.

Did I miss something??


$ make CHECK_DTBS=y ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- 
exynos/exynosautov920-sadk.dtb
   LINT    Documentation/devicetree/bindings
   CHKDT Documentation/devicetree/bindings/processed-schema.json
   SCHEMA Documentation/devicetree/bindings/processed-schema.json
   UPD     include/config/kernel.release
   DTC_CHK arch/arm64/boot/dts/exynos/exynosautov920-sadk.dtb


Thanks

Jaewon Kim

Re: [PATCH v2 00/12] Introduce ExynosAutov920 SoC and SADK board
Posted by Krzysztof Kozlowski 2 years, 1 month ago
On 16/11/2023 04:32, Jaewon Kim wrote:
> 
> On 23. 11. 16. 06:17, Krzysztof Kozlowski wrote:
>> On 15/11/2023 22:11, Krzysztof Kozlowski wrote:
>>> On 15/11/2023 14:08, Krzysztof Kozlowski wrote:
>>>> On Wed, 15 Nov 2023 18:55:56 +0900, Jaewon Kim wrote:
>>>>> ExynosAutov920[1] is ARMv8-based automotive-oriented SoC.
>>>>> This SoC is the next generation of exynosautov9 and AE(Automotive Enhanced)
>>>>> IPs are used for safety.
>>>>>
>>>>> This patchset is the minimal set for ExynosAutov920 SoC and SADK board.
>>>>> Currently, ramdisk console is available and Clock, UFS, and USI will be
>>>>> added after this patchset.
>>>>>
>>>>> [...]
>>>> Applied, thanks!
>>>>
>>> And dropped. You did not test it. Please read Samsung SoC maintainer
>>> profile:
>>> https://www.kernel.org/doc/html/latest/process/maintainers.html#arm-samsung-s3c-s5p-and-exynos-arm-architectures
>>>
>>> I also made announcements on the lists and on social.kernel.org. I don't
>>> know where to announce it more...
>>>
>> To clarify, I dropped only DTS and kept bindings. Let me know if
>> bindings are problematic here...
>>
>> I also repeated the announcement:
>> https://social.kernel.org/notice/AbqJkj9gOZJ3sG8eCu
>> Please share internally within Samsung, so there will be no surprises.
>>
>> Best regards,
>> Krzysztof
>>
>>
> 
> I already checked and there were no warnings or errors as shown below.
> 
> Did I miss something??

It's not what is written in maintainer profile. Where do you see the
result of dtc W=1?

Best regards,
Krzysztof
Re: [PATCH v2 00/12] Introduce ExynosAutov920 SoC and SADK board
Posted by Jaewon Kim 2 years, 1 month ago
On 23. 11. 16. 20:17, Krzysztof Kozlowski wrote:
> On 16/11/2023 04:32, Jaewon Kim wrote:
>> On 23. 11. 16. 06:17, Krzysztof Kozlowski wrote:
>>> On 15/11/2023 22:11, Krzysztof Kozlowski wrote:
>>>> On 15/11/2023 14:08, Krzysztof Kozlowski wrote:
>>>>> On Wed, 15 Nov 2023 18:55:56 +0900, Jaewon Kim wrote:
>>>>>> ExynosAutov920[1] is ARMv8-based automotive-oriented SoC.
>>>>>> This SoC is the next generation of exynosautov9 and AE(Automotive Enhanced)
>>>>>> IPs are used for safety.
>>>>>>
>>>>>> This patchset is the minimal set for ExynosAutov920 SoC and SADK board.
>>>>>> Currently, ramdisk console is available and Clock, UFS, and USI will be
>>>>>> added after this patchset.
>>>>>>
>>>>>> [...]
>>>>> Applied, thanks!
>>>>>
>>>> And dropped. You did not test it. Please read Samsung SoC maintainer
>>>> profile:
>>>> https://www.kernel.org/doc/html/latest/process/maintainers.html#arm-samsung-s3c-s5p-and-exynos-arm-architectures
>>>>
>>>> I also made announcements on the lists and on social.kernel.org. I don't
>>>> know where to announce it more...
>>>>
>>> To clarify, I dropped only DTS and kept bindings. Let me know if
>>> bindings are problematic here...
>>>
>>> I also repeated the announcement:
>>> https://social.kernel.org/notice/AbqJkj9gOZJ3sG8eCu
>>> Please share internally within Samsung, so there will be no surprises.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>>
>> I already checked and there were no warnings or errors as shown below.
>>
>> Did I miss something??
> It's not what is written in maintainer profile. Where do you see the
> result of dtc W=1?
>

Sorry, Krzysztof I miss W=1.

I haven`t been active in mainline for a long time, so I`m missing out on 
a lot of things.

Thanks you for letting us know one by one.

I will catch up quickly.


Thanks

Jaewon Kim
Re: [PATCH v2 00/12] Introduce ExynosAutov920 SoC and SADK board
Posted by Krzysztof Kozlowski 2 years, 1 month ago
On 17/11/2023 08:19, Jaewon Kim wrote:
> 
> On 23. 11. 16. 20:17, Krzysztof Kozlowski wrote:
>> On 16/11/2023 04:32, Jaewon Kim wrote:
>>> On 23. 11. 16. 06:17, Krzysztof Kozlowski wrote:
>>>> On 15/11/2023 22:11, Krzysztof Kozlowski wrote:
>>>>> On 15/11/2023 14:08, Krzysztof Kozlowski wrote:
>>>>>> On Wed, 15 Nov 2023 18:55:56 +0900, Jaewon Kim wrote:
>>>>>>> ExynosAutov920[1] is ARMv8-based automotive-oriented SoC.
>>>>>>> This SoC is the next generation of exynosautov9 and AE(Automotive Enhanced)
>>>>>>> IPs are used for safety.
>>>>>>>
>>>>>>> This patchset is the minimal set for ExynosAutov920 SoC and SADK board.
>>>>>>> Currently, ramdisk console is available and Clock, UFS, and USI will be
>>>>>>> added after this patchset.
>>>>>>>
>>>>>>> [...]
>>>>>> Applied, thanks!
>>>>>>
>>>>> And dropped. You did not test it. Please read Samsung SoC maintainer
>>>>> profile:
>>>>> https://www.kernel.org/doc/html/latest/process/maintainers.html#arm-samsung-s3c-s5p-and-exynos-arm-architectures
>>>>>
>>>>> I also made announcements on the lists and on social.kernel.org. I don't
>>>>> know where to announce it more...
>>>>>
>>>> To clarify, I dropped only DTS and kept bindings. Let me know if
>>>> bindings are problematic here...
>>>>
>>>> I also repeated the announcement:
>>>> https://social.kernel.org/notice/AbqJkj9gOZJ3sG8eCu
>>>> Please share internally within Samsung, so there will be no surprises.
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>>
>>>>
>>> I already checked and there were no warnings or errors as shown below.
>>>
>>> Did I miss something??
>> It's not what is written in maintainer profile. Where do you see the
>> result of dtc W=1?
>>
> 
> Sorry, Krzysztof I miss W=1.
> 
> I haven`t been active in mainline for a long time, so I`m missing out on 
> a lot of things.

If you (plural you, Samsung) ever gave me an email address where I can
send notifications I would gladly forward them to you.

Over the time I sent few of them, like the one about deprecation of
platforms or changing some rules, feedback for common solution for
minidump (to remind: Samsung decided to skip it so we go with Qualcomm
idea and you will not be able to come with your own later) etc. I was
even contacting some addresses in Samsung LSI, but there was never a
response, except the one about minidump.

There was like never a chance to really get to Samsung, so sorry, now it
is Samsung's fault it does not follow announcements.

Best regards,
Krzysztof
Re: [PATCH v2 00/12] Introduce ExynosAutov920 SoC and SADK board
Posted by Krzysztof Kozlowski 2 years, 1 month ago
On 17/11/2023 11:57, Krzysztof Kozlowski wrote:
>>>>>> And dropped. You did not test it. Please read Samsung SoC maintainer
>>>>>> profile:
>>>>>> https://www.kernel.org/doc/html/latest/process/maintainers.html#arm-samsung-s3c-s5p-and-exynos-arm-architectures
>>>>>>
>>>>>> I also made announcements on the lists and on social.kernel.org. I don't
>>>>>> know where to announce it more...
>>>>>>
>>>>> To clarify, I dropped only DTS and kept bindings. Let me know if
>>>>> bindings are problematic here...
>>>>>
>>>>> I also repeated the announcement:
>>>>> https://social.kernel.org/notice/AbqJkj9gOZJ3sG8eCu
>>>>> Please share internally within Samsung, so there will be no surprises.
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>>
>>>>>
>>>> I already checked and there were no warnings or errors as shown below.
>>>>
>>>> Did I miss something??
>>> It's not what is written in maintainer profile. Where do you see the
>>> result of dtc W=1?
>>>
>>
>> Sorry, Krzysztof I miss W=1.
>>
>> I haven`t been active in mainline for a long time, so I`m missing out on 
>> a lot of things.
> 
> If you (plural you, Samsung) ever gave me an email address where I can
> send notifications I would gladly forward them to you.
> 
> Over the time I sent few of them, like the one about deprecation of
> platforms or changing some rules, feedback for common solution for
> minidump (to remind: Samsung decided to skip it so we go with Qualcomm
> idea and you will not be able to come with your own later) etc. I was
> even contacting some addresses in Samsung LSI, but there was never a
> response, except the one about minidump.
> 
> There was like never a chance to really get to Samsung, so sorry, now it
> is Samsung's fault it does not follow announcements.

Heh, my post on social.kernel.org is pinned (pinned!) for four months!
Four months is still not enough...

Best regards,
Krzysztof
Re: [PATCH v2 00/12] Introduce ExynosAutov920 SoC and SADK board
Posted by Uwe Kleine-König 2 years, 1 month ago
Hello,

On Thu, Nov 16, 2023 at 12:32:30PM +0900, Jaewon Kim wrote:
> I already checked and there were no warnings or errors as shown below.
> 
> Did I miss something??
> 
> 
> $ make CHECK_DTBS=y ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- 
> exynos/exynosautov920-sadk.dtb
>    LINT    Documentation/devicetree/bindings
>    CHKDT Documentation/devicetree/bindings/processed-schema.json
>    SCHEMA Documentation/devicetree/bindings/processed-schema.json
>    UPD     include/config/kernel.release
>    DTC_CHK arch/arm64/boot/dts/exynos/exynosautov920-sadk.dtb

https://www.kernel.org/doc/html/latest/process/maintainer-soc-clean-dts.html
also talks about W=1 that you didn't pass.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
Re: [PATCH v2 00/12] Introduce ExynosAutov920 SoC and SADK board
Posted by Jaewon Kim 2 years, 1 month ago
Hello,


On 23. 11. 16. 16:56, Uwe Kleine-König wrote:
> Hello,
>
> On Thu, Nov 16, 2023 at 12:32:30PM +0900, Jaewon Kim wrote:
>> I already checked and there were no warnings or errors as shown below.
>>
>> Did I miss something??
>>
>>
>> $ make CHECK_DTBS=y ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-
>> exynos/exynosautov920-sadk.dtb
>>     LINT    Documentation/devicetree/bindings
>>     CHKDT Documentation/devicetree/bindings/processed-schema.json
>>     SCHEMA Documentation/devicetree/bindings/processed-schema.json
>>     UPD     include/config/kernel.release
>>     DTC_CHK arch/arm64/boot/dts/exynos/exynosautov920-sadk.dtb
> https://www.kernel.org/doc/html/latest/process/maintainer-soc-clean-dts.html
> also talks about W=1 that you didn't pass.

Thanks Uwe,

I found Warning when I add W=1.

I will fix it in next version.

>
> Best regards
> Uwe
>

Thanks

Jaewon Kim