[PATCH] toos:leds: Fix printf format string in uledmon.c

zhujun2 posted 1 patch 2 years, 1 month ago
tools/leds/uledmon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] toos:leds: Fix printf format string in uledmon.c
Posted by zhujun2 2 years, 1 month ago
When the argument type is 'int',printf '%d'
in format string.Problem found during code reading.

Signed-off-by: zhujun2 <zhujun2@cmss.chinamobile.com>
---
 tools/leds/uledmon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/leds/uledmon.c b/tools/leds/uledmon.c
index c15a39c1f271..62befe06eab5 100644
--- a/tools/leds/uledmon.c
+++ b/tools/leds/uledmon.c
@@ -55,7 +55,7 @@ int main(int argc, char const *argv[])
 			return 1;
 		}
 		clock_gettime(CLOCK_MONOTONIC, &ts);
-		printf("[%ld.%09ld] %u\n", ts.tv_sec, ts.tv_nsec, brightness);
+		printf("[%ld.%09ld] %d\n", ts.tv_sec, ts.tv_nsec, brightness);
 	}
 
 	close(fd);
-- 
2.17.1
Re: [PATCH] toos:leds: Fix printf format string in uledmon.c
Posted by Ian Rogers 2 years, 1 month ago
Nit in the subject: toos:leds: -> tools/leds:

On Tue, Nov 14, 2023 at 11:11 PM zhujun2 <zhujun2@cmss.chinamobile.com> wrote:
>
> When the argument type is 'int',printf '%d'
> in format string.Problem found during code reading.
>
> Signed-off-by: zhujun2 <zhujun2@cmss.chinamobile.com>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/leds/uledmon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/leds/uledmon.c b/tools/leds/uledmon.c
> index c15a39c1f271..62befe06eab5 100644
> --- a/tools/leds/uledmon.c
> +++ b/tools/leds/uledmon.c
> @@ -55,7 +55,7 @@ int main(int argc, char const *argv[])
>                         return 1;
>                 }
>                 clock_gettime(CLOCK_MONOTONIC, &ts);
> -               printf("[%ld.%09ld] %u\n", ts.tv_sec, ts.tv_nsec, brightness);
> +               printf("[%ld.%09ld] %d\n", ts.tv_sec, ts.tv_nsec, brightness);
>         }
>
>         close(fd);
> --
> 2.17.1
>
>
>